]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - ip/xfrm_state.c
libnetlink: add size argument to rtnl_talk
[mirror_iproute2.git] / ip / xfrm_state.c
index 9b374ee1f22e0ed4ec202d9a2e7889a879309784..d2831d007ced4a1d8e45051c99c7dbfb2ae99f3e 100644 (file)
@@ -14,8 +14,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ * along with this program; if not, see <http://www.gnu.org/licenses>.
  */
 /*
  * based on iproute.c
@@ -59,8 +58,9 @@ static void usage(void)
        fprintf(stderr, "Usage: ip xfrm state { add | update } ID [ ALGO-LIST ] [ mode MODE ]\n");
        fprintf(stderr, "        [ mark MARK [ mask MASK ] ] [ reqid REQID ] [ seq SEQ ]\n");
        fprintf(stderr, "        [ replay-window SIZE ] [ replay-seq SEQ ] [ replay-oseq SEQ ]\n");
+       fprintf(stderr, "        [ replay-seq-hi SEQ ] [ replay-oseq-hi SEQ ]\n");
        fprintf(stderr, "        [ flag FLAG-LIST ] [ sel SELECTOR ] [ LIMIT-LIST ] [ encap ENCAP ]\n");
-       fprintf(stderr, "        [ coa ADDR[/PLEN] ] [ ctx CTX ]\n");
+       fprintf(stderr, "        [ coa ADDR[/PLEN] ] [ ctx CTX ] [ extra-flag EXTRA-FLAG-LIST ]\n");
        fprintf(stderr, "Usage: ip xfrm state allocspi ID [ mode MODE ] [ mark MARK [ mask MASK ] ]\n");
        fprintf(stderr, "        [ reqid REQID ] [ seq SEQ ] [ min SPI max SPI ]\n");
        fprintf(stderr, "Usage: ip xfrm state { delete | get } ID [ mark MARK [ mask MASK ] ]\n");
@@ -79,16 +79,18 @@ static void usage(void)
        fprintf(stderr, "ALGO := { ");
        fprintf(stderr, "%s | ", strxf_algotype(XFRMA_ALG_CRYPT));
        fprintf(stderr, "%s", strxf_algotype(XFRMA_ALG_AUTH));
-       fprintf(stderr, " } ALGO-NAME ALGO-KEY |\n");
+       fprintf(stderr, " } ALGO-NAME ALGO-KEYMAT |\n");
        fprintf(stderr, "        %s", strxf_algotype(XFRMA_ALG_AUTH_TRUNC));
-       fprintf(stderr, " ALGO-NAME ALGO-KEY ALGO-TRUNC-LEN |\n");
+       fprintf(stderr, " ALGO-NAME ALGO-KEYMAT ALGO-TRUNC-LEN |\n");
        fprintf(stderr, "        %s", strxf_algotype(XFRMA_ALG_AEAD));
-       fprintf(stderr, " ALGO-NAME ALGO-KEY ALGO-ICV-LEN |\n");
+       fprintf(stderr, " ALGO-NAME ALGO-KEYMAT ALGO-ICV-LEN |\n");
        fprintf(stderr, "        %s", strxf_algotype(XFRMA_ALG_COMP));
        fprintf(stderr, " ALGO-NAME\n");
-       fprintf(stderr, "MODE := transport | tunnel | ro | in_trigger | beet\n");
+       fprintf(stderr, "MODE := transport | tunnel | beet | ro | in_trigger\n");
        fprintf(stderr, "FLAG-LIST := [ FLAG-LIST ] FLAG\n");
-       fprintf(stderr, "FLAG := noecn | decap-dscp | nopmtudisc | wildrecv | icmp | af-unspec | align4\n");
+       fprintf(stderr, "FLAG := noecn | decap-dscp | nopmtudisc | wildrecv | icmp | af-unspec | align4 | esn\n");
+       fprintf(stderr, "EXTRA-FLAG-LIST := [ EXTRA-FLAG-LIST ] EXTRA-FLAG\n");
+       fprintf(stderr, "EXTRA-FLAG := dont-encap-dscp\n");
        fprintf(stderr, "SELECTOR := [ src ADDR[/PLEN] ] [ dst ADDR[/PLEN] ] [ dev DEV ] [ UPSPEC ]\n");
        fprintf(stderr, "UPSPEC := proto { { ");
        fprintf(stderr, "%s | ", strxf_proto(IPPROTO_TCP));
@@ -119,7 +121,7 @@ static int xfrm_algo_parse(struct xfrm_algo *alg, enum xfrm_attr_type_t type,
 
 #if 0
        /* XXX: verifying both name and key is required! */
-       fprintf(stderr, "warning: ALGO-NAME/ALGO-KEY will send to kernel promiscuously! (verifying them isn't implemented yet)\n");
+       fprintf(stderr, "warning: ALGO-NAME/ALGO-KEYMAT values will be sent to the kernel promiscuously! (verifying them isn't implemented yet)\n");
 #endif
 
        strncpy(alg->alg_name, name, sizeof(alg->alg_name));
@@ -139,7 +141,7 @@ static int xfrm_algo_parse(struct xfrm_algo *alg, enum xfrm_attr_type_t type,
                /* calculate length of the converted values(real key) */
                len = (plen + 1) / 2;
                if (len > max)
-                       invarg("\"ALGO-KEY\" makes buffer overflow\n", key);
+                       invarg("ALGO-KEYMAT value makes buffer overflow\n", key);
 
                for (i = - (plen % 2), j = 0; j < len; i += 2, j++) {
                        char vbuf[3];
@@ -150,7 +152,7 @@ static int xfrm_algo_parse(struct xfrm_algo *alg, enum xfrm_attr_type_t type,
                        vbuf[2] = '\0';
 
                        if (get_u8(&val, vbuf, 16))
-                               invarg("\"ALGO-KEY\" is invalid", key);
+                               invarg("ALGO-KEYMAT value is invalid", key);
 
                        buf[j] = val;
                }
@@ -158,9 +160,9 @@ static int xfrm_algo_parse(struct xfrm_algo *alg, enum xfrm_attr_type_t type,
                len = slen;
                if (len > 0) {
                        if (len > max)
-                               invarg("\"ALGO-KEY\" makes buffer overflow\n", key);
+                               invarg("ALGO-KEYMAT value makes buffer overflow\n", key);
 
-                       strncpy(buf, key, len);
+                       memcpy(buf, key, len);
                }
        }
 
@@ -175,7 +177,7 @@ static int xfrm_seq_parse(__u32 *seq, int *argcp, char ***argvp)
        char **argv = *argvp;
 
        if (get_u32(seq, *argv, 0))
-               invarg("\"SEQ\" is invalid", *argv);
+               invarg("SEQ value is invalid", *argv);
 
        *seq = htonl(*seq);
 
@@ -195,7 +197,7 @@ static int xfrm_state_flag_parse(__u8 *flags, int *argcp, char ***argvp)
                __u8 val = 0;
 
                if (get_u8(&val, *argv, 16))
-                       invarg("\"FLAG\" is invalid", *argv);
+                       invarg("FLAG value is invalid", *argv);
                *flags = val;
        } else {
                while (1) {
@@ -213,6 +215,41 @@ static int xfrm_state_flag_parse(__u8 *flags, int *argcp, char ***argvp)
                                *flags |= XFRM_STATE_AF_UNSPEC;
                        else if (strcmp(*argv, "align4") == 0)
                                *flags |= XFRM_STATE_ALIGN4;
+                       else if (strcmp(*argv, "esn") == 0)
+                               *flags |= XFRM_STATE_ESN;
+                       else {
+                               PREV_ARG(); /* back track */
+                               break;
+                       }
+
+                       if (!NEXT_ARG_OK())
+                               break;
+                       NEXT_ARG();
+               }
+       }
+
+       *argcp = argc;
+       *argvp = argv;
+
+       return 0;
+}
+
+static int xfrm_state_extra_flag_parse(__u32 *extra_flags, int *argcp, char ***argvp)
+{
+       int argc = *argcp;
+       char **argv = *argvp;
+       int len = strlen(*argv);
+
+       if (len > 2 && strncmp(*argv, "0x", 2) == 0) {
+               __u32 val = 0;
+
+               if (get_u32(&val, *argv, 16))
+                       invarg("\"EXTRA-FLAG\" is invalid", *argv);
+               *extra_flags = val;
+       } else {
+               while (1) {
+                       if (strcmp(*argv, "dont-encap-dscp") == 0)
+                               *extra_flags |= XFRM_SA_XFLAG_DONT_ENCAP_DSCP;
                        else {
                                PREV_ARG(); /* back track */
                                break;
@@ -234,11 +271,14 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
 {
        struct rtnl_handle rth;
        struct {
-               struct nlmsghdr         n;
+               struct nlmsghdr n;
                struct xfrm_usersa_info xsinfo;
-               char                    buf[RTA_BUF_SIZE];
+               char                    buf[RTA_BUF_SIZE];
        } req;
        struct xfrm_replay_state replay;
+       struct xfrm_replay_state_esn replay_esn;
+       __u32 replay_window = 0;
+       __u32 seq = 0, oseq = 0, seq_hi = 0, oseq_hi = 0;
        char *idp = NULL;
        char *aeadop = NULL;
        char *ealgop = NULL;
@@ -246,6 +286,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
        char *calgop = NULL;
        char *coap = NULL;
        char *sctxp = NULL;
+       __u32 extra_flags = 0;
        struct xfrm_mark mark = {0, 0};
        struct {
                struct xfrm_user_sec_ctx sctx;
@@ -254,6 +295,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
 
        memset(&req, 0, sizeof(req));
        memset(&replay, 0, sizeof(replay));
+       memset(&replay_esn, 0, sizeof(replay_esn));
        memset(&ctx, 0, sizeof(ctx));
 
        req.n.nlmsg_len = NLMSG_LENGTH(sizeof(req.xsinfo));
@@ -280,19 +322,30 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                        xfrm_seq_parse(&req.xsinfo.seq, &argc, &argv);
                } else if (strcmp(*argv, "replay-window") == 0) {
                        NEXT_ARG();
-                       if (get_u8(&req.xsinfo.replay_window, *argv, 0))
-                               invarg("\"replay-window\" value is invalid", *argv);
+                       if (get_u32(&replay_window, *argv, 0))
+                               invarg("value after \"replay-window\" is invalid", *argv);
                } else if (strcmp(*argv, "replay-seq") == 0) {
                        NEXT_ARG();
-                       if (get_u32(&replay.seq, *argv, 0))
-                               invarg("\"replay-seq\" value is invalid", *argv);
+                       if (get_u32(&seq, *argv, 0))
+                               invarg("value after \"replay-seq\" is invalid", *argv);
+               } else if (strcmp(*argv, "replay-seq-hi") == 0) {
+                       NEXT_ARG();
+                       if (get_u32(&seq_hi, *argv, 0))
+                               invarg("value after \"replay-seq-hi\" is invalid", *argv);
                } else if (strcmp(*argv, "replay-oseq") == 0) {
                        NEXT_ARG();
-                       if (get_u32(&replay.oseq, *argv, 0))
-                               invarg("\"replay-oseq\" value is invalid", *argv);
+                       if (get_u32(&oseq, *argv, 0))
+                               invarg("value after \"replay-oseq\" is invalid", *argv);
+               } else if (strcmp(*argv, "replay-oseq-hi") == 0) {
+                       NEXT_ARG();
+                       if (get_u32(&oseq_hi, *argv, 0))
+                               invarg("value after \"replay-oseq-hi\" is invalid", *argv);
                } else if (strcmp(*argv, "flag") == 0) {
                        NEXT_ARG();
                        xfrm_state_flag_parse(&req.xsinfo.flags, &argc, &argv);
+               } else if (strcmp(*argv, "extra-flag") == 0) {
+                       NEXT_ARG();
+                       xfrm_state_extra_flag_parse(&extra_flags, &argc, &argv);
                } else if (strcmp(*argv, "sel") == 0) {
                        NEXT_ARG();
                        preferred_family = AF_UNSPEC;
@@ -308,11 +361,11 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                        xfrm_encap_type_parse(&encap.encap_type, &argc, &argv);
                        NEXT_ARG();
                        if (get_u16(&encap.encap_sport, *argv, 0))
-                               invarg("\"encap\" sport value is invalid", *argv);
+                               invarg("SPORT value after \"encap\" is invalid", *argv);
                        encap.encap_sport = htons(encap.encap_sport);
                        NEXT_ARG();
                        if (get_u16(&encap.encap_dport, *argv, 0))
-                               invarg("\"encap\" dport value is invalid", *argv);
+                               invarg("DPORT value after \"encap\" is invalid", *argv);
                        encap.encap_dport = htons(encap.encap_dport);
                        NEXT_ARG();
                        get_addr(&oa, *argv, AF_UNSPEC);
@@ -331,9 +384,9 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
 
                        get_prefix(&coa, *argv, preferred_family);
                        if (coa.family == AF_UNSPEC)
-                               invarg("\"coa\" address family is AF_UNSPEC", *argv);
+                               invarg("value after \"coa\" has an unrecognized address family", *argv);
                        if (coa.bytelen > sizeof(xcoa))
-                               invarg("\"coa\" address length is too large", *argv);
+                               invarg("value after \"coa\" is too large", *argv);
 
                        memset(&xcoa, 0, sizeof(xcoa));
                        memcpy(&xcoa, &coa.data, coa.bytelen);
@@ -402,7 +455,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                                        break;
                                default:
                                        /* not reached */
-                                       invarg("\"ALGO-TYPE\" is invalid\n", *argv);
+                                       invarg("ALGO-TYPE value is invalid\n", *argv);
                                }
 
                                if (!NEXT_ARG_OK())
@@ -416,7 +469,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                                case XFRMA_ALG_AUTH:
                                case XFRMA_ALG_AUTH_TRUNC:
                                        if (!NEXT_ARG_OK())
-                                               missarg("ALGO-KEY");
+                                               missarg("ALGO-KEYMAT");
                                        NEXT_ARG();
                                        key = *argv;
                                        break;
@@ -431,7 +484,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                                                missarg("ALGO-ICV-LEN");
                                        NEXT_ARG();
                                        if (get_u32(&icvlen, *argv, 0))
-                                               invarg("\"aead\" ICV length is invalid",
+                                               invarg("ALGO-ICV-LEN value is invalid",
                                                       *argv);
                                        alg.u.aead.alg_icv_len = icvlen;
 
@@ -443,7 +496,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                                                missarg("ALGO-TRUNC-LEN");
                                        NEXT_ARG();
                                        if (get_u32(&trunclen, *argv, 0))
-                                               invarg("\"auth\" trunc length is invalid",
+                                               invarg("ALGO-TRUNC-LEN value is invalid",
                                                       *argv);
                                        alg.u.auth.alg_trunc_len = trunclen;
 
@@ -476,16 +529,50 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
                argc--; argv++;
        }
 
-       if (replay.seq || replay.oseq)
-               addattr_l(&req.n, sizeof(req.buf), XFRMA_REPLAY_VAL,
-                         (void *)&replay, sizeof(replay));
+       if (req.xsinfo.flags & XFRM_STATE_ESN &&
+           replay_window == 0) {
+               fprintf(stderr, "Error: esn flag set without replay-window.\n");
+               exit(-1);
+       }
+
+       if (replay_window > XFRMA_REPLAY_ESN_MAX) {
+               fprintf(stderr,
+                       "Error: replay-window (%u) > XFRMA_REPLAY_ESN_MAX (%u).\n",
+                       replay_window, XFRMA_REPLAY_ESN_MAX);
+               exit(-1);
+       }
+
+       if (req.xsinfo.flags & XFRM_STATE_ESN ||
+           replay_window > (sizeof(replay.bitmap) * 8)) {
+               replay_esn.seq = seq;
+               replay_esn.oseq = oseq;
+               replay_esn.seq_hi = seq_hi;
+               replay_esn.oseq_hi = oseq_hi;
+               replay_esn.replay_window = replay_window;
+               replay_esn.bmp_len = (replay_window + sizeof(__u32) * 8 - 1) /
+                                    (sizeof(__u32) * 8);
+               addattr_l(&req.n, sizeof(req.buf), XFRMA_REPLAY_ESN_VAL,
+                         &replay_esn, sizeof(replay_esn));
+       } else {
+               if (seq || oseq) {
+                       replay.seq = seq;
+                       replay.oseq = oseq;
+                       addattr_l(&req.n, sizeof(req.buf), XFRMA_REPLAY_VAL,
+                                 &replay, sizeof(replay));
+               }
+               req.xsinfo.replay_window = replay_window;
+       }
+
+       if (extra_flags)
+               addattr32(&req.n, sizeof(req.buf), XFRMA_SA_EXTRA_FLAGS,
+                         extra_flags);
 
        if (!idp) {
-               fprintf(stderr, "Not enough information: \"ID\" is required\n");
+               fprintf(stderr, "Not enough information: ID is required\n");
                exit(1);
        }
 
-       if (mark.m & mark.v) {
+       if (mark.m) {
                int r = addattr_l(&req.n, sizeof(req.buf), XFRMA_MARK,
                                  (void *)&mark, sizeof(mark));
                if (r < 0) {
@@ -601,7 +688,7 @@ static int xfrm_state_modify(int cmd, unsigned flags, int argc, char **argv)
        if (req.xsinfo.family == AF_UNSPEC)
                req.xsinfo.family = AF_INET;
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, NULL) < 0)
+       if (rtnl_talk(&rth, &req.n, NULL, 0) < 0)
                exit(2);
 
        rtnl_close(&rth);
@@ -613,9 +700,9 @@ static int xfrm_state_allocspi(int argc, char **argv)
 {
        struct rtnl_handle rth;
        struct {
-               struct nlmsghdr         n;
+               struct nlmsghdr n;
                struct xfrm_userspi_info xspi;
-               char                    buf[RTA_BUF_SIZE];
+               char                    buf[RTA_BUF_SIZE];
        } req;
        char *idp = NULL;
        char *minp = NULL;
@@ -660,7 +747,7 @@ static int xfrm_state_allocspi(int argc, char **argv)
                        NEXT_ARG();
 
                        if (get_u32(&req.xspi.min, *argv, 0))
-                               invarg("\"min\" value is invalid", *argv);
+                               invarg("value after \"min\" is invalid", *argv);
                } else if (strcmp(*argv, "max") == 0) {
                        if (maxp)
                                duparg("max", *argv);
@@ -669,7 +756,7 @@ static int xfrm_state_allocspi(int argc, char **argv)
                        NEXT_ARG();
 
                        if (get_u32(&req.xspi.max, *argv, 0))
-                               invarg("\"max\" value is invalid", *argv);
+                               invarg("value after \"max\" is invalid", *argv);
                } else {
                        /* try to assume ID */
                        if (idp)
@@ -680,7 +767,7 @@ static int xfrm_state_allocspi(int argc, char **argv)
                        xfrm_id_parse(&req.xspi.info.saddr, &req.xspi.info.id,
                                      &req.xspi.info.family, 0, &argc, &argv);
                        if (req.xspi.info.id.spi) {
-                               fprintf(stderr, "\"SPI\" must be zero\n");
+                               fprintf(stderr, "\"spi\" is invalid\n");
                                exit(1);
                        }
                        if (preferred_family == AF_UNSPEC)
@@ -690,7 +777,7 @@ static int xfrm_state_allocspi(int argc, char **argv)
        }
 
        if (!idp) {
-               fprintf(stderr, "Not enough information: \"ID\" is required\n");
+               fprintf(stderr, "Not enough information: ID is required\n");
                exit(1);
        }
 
@@ -700,7 +787,7 @@ static int xfrm_state_allocspi(int argc, char **argv)
                        exit(1);
                }
                if (req.xspi.min > req.xspi.max) {
-                       fprintf(stderr, "\"min\" value is larger than \"max\" value\n");
+                       fprintf(stderr, "value after \"min\" is larger than value after \"max\"\n");
                        exit(1);
                }
        } else {
@@ -738,7 +825,7 @@ static int xfrm_state_allocspi(int argc, char **argv)
                req.xspi.info.family = AF_INET;
 
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, res_n) < 0)
+       if (rtnl_talk(&rth, &req.n, res_n, sizeof(res_buf)) < 0)
                exit(2);
 
        if (xfrm_state_print(NULL, res_n, (void*)stdout) < 0) {
@@ -870,9 +957,9 @@ static int xfrm_state_get_or_delete(int argc, char **argv, int delete)
 {
        struct rtnl_handle rth;
        struct {
-               struct nlmsghdr         n;
+               struct nlmsghdr n;
                struct xfrm_usersa_id   xsid;
-               char                    buf[RTA_BUF_SIZE];
+               char                    buf[RTA_BUF_SIZE];
        } req;
        struct xfrm_id id;
        char *idp = NULL;
@@ -928,7 +1015,7 @@ static int xfrm_state_get_or_delete(int argc, char **argv, int delete)
                req.xsid.family = AF_INET;
 
        if (delete) {
-               if (rtnl_talk(&rth, &req.n, 0, 0, NULL) < 0)
+               if (rtnl_talk(&rth, &req.n, NULL, 0) < 0)
                        exit(2);
        } else {
                char buf[NLMSG_BUF_SIZE];
@@ -936,7 +1023,7 @@ static int xfrm_state_get_or_delete(int argc, char **argv, int delete)
 
                memset(buf, 0, sizeof(buf));
 
-               if (rtnl_talk(&rth, &req.n, 0, 0, res_n) < 0)
+               if (rtnl_talk(&rth, &req.n, res_n, sizeof(req)) < 0)
                        exit(2);
 
                if (xfrm_state_print(NULL, res_n, (void*)stdout) < 0) {
@@ -1061,13 +1148,23 @@ static int xfrm_state_list_or_deleteall(int argc, char **argv, int deleteall)
                xb.rth = &rth;
 
                for (i = 0; ; i++) {
+                       struct {
+                               struct nlmsghdr n;
+                               char buf[NLMSG_BUF_SIZE];
+                       } req = {
+                               .n.nlmsg_len = NLMSG_HDRLEN,
+                               .n.nlmsg_flags = NLM_F_DUMP | NLM_F_REQUEST,
+                               .n.nlmsg_type = XFRM_MSG_GETSA,
+                               .n.nlmsg_seq = rth.dump = ++rth.seq,
+                       };
+
                        xb.offset = 0;
                        xb.nlmsg_count = 0;
 
                        if (show_stats > 1)
                                fprintf(stderr, "Delete-all round = %d\n", i);
 
-                       if (rtnl_wilddump_request(&rth, preferred_family, XFRM_MSG_GETSA) < 0) {
+                       if (rtnl_send(&rth, (void *)&req, req.n.nlmsg_len) < 0) {
                                perror("Cannot send dump request");
                                exit(1);
                        }
@@ -1094,7 +1191,30 @@ static int xfrm_state_list_or_deleteall(int argc, char **argv, int deleteall)
                }
 
        } else {
-               if (rtnl_wilddump_request(&rth, preferred_family, XFRM_MSG_GETSA) < 0) {
+               struct xfrm_address_filter addrfilter = {
+                       .saddr = filter.xsinfo.saddr,
+                       .daddr = filter.xsinfo.id.daddr,
+                       .family = filter.xsinfo.family,
+                       .splen = filter.id_src_mask,
+                       .dplen = filter.id_dst_mask,
+               };
+               struct {
+                       struct nlmsghdr n;
+                       char buf[NLMSG_BUF_SIZE];
+               } req = {
+                       .n.nlmsg_len = NLMSG_HDRLEN,
+                       .n.nlmsg_flags = NLM_F_DUMP | NLM_F_REQUEST,
+                       .n.nlmsg_type = XFRM_MSG_GETSA,
+                       .n.nlmsg_seq = rth.dump = ++rth.seq,
+               };
+
+               if (filter.xsinfo.id.proto)
+                       addattr8(&req.n, sizeof(req), XFRMA_PROTO,
+                                filter.xsinfo.id.proto);
+               addattr_l(&req.n, sizeof(req), XFRMA_ADDRESS_FILTER,
+                         &addrfilter, sizeof(addrfilter));
+
+               if (rtnl_send(&rth, (void *)&req, req.n.nlmsg_len) < 0) {
                        perror("Cannot send dump request");
                        exit(1);
                }
@@ -1146,7 +1266,7 @@ static int print_sadinfo(struct nlmsghdr *n, void *arg)
                                fprintf(fp,"BAD SAD length returned\n");
                                return -1;
                        }
-                               
+
                        si = RTA_DATA(tb[XFRMA_SAD_HINFO]);
                        fprintf(fp," (buckets ");
                        fprintf(fp,"count %d", si->sadhcnt);
@@ -1177,7 +1297,7 @@ static int xfrm_sad_getinfo(int argc, char **argv)
        if (rtnl_open_byproto(&rth, 0, NETLINK_XFRM) < 0)
                exit(1);
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, &req.n) < 0)
+       if (rtnl_talk(&rth, &req.n, &req.n, sizeof(req)) < 0)
                exit(2);
 
        print_sadinfo(&req.n, (void*)stdout);
@@ -1215,7 +1335,7 @@ static int xfrm_state_flush(int argc, char **argv)
 
                        ret = xfrm_xfrmproto_getbyname(*argv);
                        if (ret < 0)
-                               invarg("\"XFRM-PROTO\" is invalid", *argv);
+                               invarg("XFRM-PROTO value is invalid", *argv);
 
                        req.xsf.proto = (__u8)ret;
                } else
@@ -1228,10 +1348,10 @@ static int xfrm_state_flush(int argc, char **argv)
                exit(1);
 
        if (show_stats > 1)
-               fprintf(stderr, "Flush state proto=%s\n",
+               fprintf(stderr, "Flush state with XFRM-PROTO value \"%s\"\n",
                        strxf_xfrmproto(req.xsf.proto));
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, NULL) < 0)
+       if (rtnl_talk(&rth, &req.n, NULL, 0) < 0)
                exit(2);
 
        rtnl_close(&rth);