Merge pull request #6263 from opensourcerouting/zlog-coverity-20200420

[mirror_frr.git] / lib / lib_errors.c

diff --git a/lib/lib_errors.c b/lib/lib_errors.c
index b1ed7d2f6b15f159696996b153ac34060a5127fd..6e5088142a10c3985d09c4048d9671ff2afc959e 100644 (file)
--- a/lib/lib_errors.c
+++ b/lib/lib_errors.c
@@ -50,6 +50,12 @@ static struct log_ref ferr_lib_warn[] = {
                .description = "The Event subsystem has detected a slow process, this typically indicates that FRR is having trouble completing work in a timely manner.  This can be either a misconfiguration, bug, or some combination therof.",
                .suggestion = "Gather log data and open an Issue",
        },
+       {
+               .code = EC_LIB_NO_THREAD,
+               .title = "The Event subsystem has detected an internal FD problem",
+               .description = "The Event subsystem has detected a file descriptor read/write event without an associated handling function.  This is a bug, please collect log data and open an issue.",
+               .suggestion = "Gather log data and open an Issue",
+       },
        {
                .code = EC_LIB_RMAP_RECURSION_LIMIT,
                .title = "Reached the Route-Map Recursion Limit",
@@ -102,13 +108,19 @@ static struct log_ref ferr_lib_warn[] = {
                .code = EC_LIB_NB_CB_UNNEEDED,
                .title = "Unneeded northbound callback",
                .description = "The northbound subsystem, during initialization, has detected a callback that doesn't need to be implemented",
-               .suggestion = "Check if the installed FRR YANG modules are in sync with the FRR binaries",
+               .suggestion = "This is a bug; please report it"
        },
        {
-               .code = EC_LIB_NB_CB_CONFIG,
-               .title = "A northbound configuration callback has failed",
-               .description = "The northbound subsystem has detected that a callback used to process a configuration change has returned an error",
-               .suggestion = "The log message should contain further details on the specific error that occurred; investigate the reported error.",
+               .code = EC_LIB_NB_CB_CONFIG_VALIDATE,
+               .title = "A northbound configuration callback has failed in the VALIDATE phase",
+               .description = "A callback used to process a configuration change has returned a validation error",
+               .suggestion = "The provided configuration is invalid. Fix any inconsistency and try again.",
+       },
+       {
+               .code = EC_LIB_NB_CB_CONFIG_PREPARE,
+               .title = "A northbound configuration callback has failed in the PREPARE phase",
+               .description = "A callback used to process a configuration change has returned a resource allocation error",
+               .suggestion = "The system might be running out of resources. Check the log for more details.",
        },
        {
                .code = EC_LIB_NB_CB_STATE,
@@ -264,19 +276,19 @@ static struct log_ref ferr_lib_err[] = {
                .code = EC_LIB_NB_CB_MISSING,
                .title = "Missing northbound callback",
                .description = "The northbound subsystem, during initialization, has detected a missing callback for one node of the loaded YANG modules",
-               .suggestion = "Check if the installed FRR YANG modules are in sync with the FRR binaries",
+               .suggestion = "This is a bug; please report it"
        },
        {
                .code = EC_LIB_NB_CB_INVALID_PRIO,
                .title = "Norhtbound callback has an invalid priority",
                .description = "The northbound subsystem, during initialization, has detected a callback whose priority is invalid",
-               .suggestion = "Check if the installed FRR YANG modules are in sync with the FRR binaries",
+               .suggestion = "This is a bug; please report it"
        },
        {
                .code = EC_LIB_NB_CBS_VALIDATION,
                .title = "Failure to validate the northbound callbacks",
                .description = "The northbound subsystem, during initialization, has detected one or more errors while loading the northbound callbacks",
-               .suggestion = "Check if the installed FRR YANG modules are in sync with the FRR binaries",
+               .suggestion = "This is a bug; please report it"
        },
        {
                .code = EC_LIB_LIBYANG,
@@ -326,6 +338,30 @@ static struct log_ref ferr_lib_err[] = {
                .description = "The northbound subsystem has detected that the libsysrepo library returned an error",
                .suggestion = "Open an Issue with all relevant log files and restart FRR"
        },
+       {
+               .code = EC_LIB_GRPC_INIT,
+               .title = "gRPC initialization error",
+               .description = "Upon startup FRR failed to properly initialize and startup the gRPC northbound plugin",
+               .suggestion = "Check if the gRPC libraries are installed correctly in the system.",
+       },
+       {
+               .code = EC_LIB_NB_CB_CONFIG_ABORT,
+               .title = "A northbound configuration callback has failed in the ABORT phase",
+               .description = "A callback used to process a configuration change has returned an error while trying to abort a change",
+               .suggestion = "Gather log data and open an Issue.",
+       },
+       {
+               .code = EC_LIB_NB_CB_CONFIG_APPLY,
+               .title = "A northbound configuration callback has failed in the APPLY phase",
+               .description = "A callback used to process a configuration change has returned an error while applying the changes",
+               .suggestion = "Gather log data and open an Issue.",
+       },
+       {
+               .code = EC_LIB_RESOLVER,
+               .title = "DNS Resolution",
+               .description = "An error was detected while attempting to resolve a hostname",
+               .suggestion = "Ensure that DNS is working properly and the hostname is configured in dns.  If you are still seeing this error, open an issue"
+       },
        {
                .code = END_FERR,
        }