]> git.proxmox.com Git - mirror_frr.git/blobdiff - lib/link_state.c
Merge pull request #13649 from donaldsharp/unlock_the_node_or_else
[mirror_frr.git] / lib / link_state.c
index 9649a5f375093583adb034327d39c0c2872d7740..58727a568b5304039631b31747966d954e125018 100644 (file)
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * Link State Database - link_state.c
  *
@@ -6,20 +7,6 @@
  * Copyright (C) 2020 Orange http://www.orange.com
  *
  * This file is part of Free Range Routing (FRR).
- *
- * FRR is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2, or (at your option) any
- * later version.
- *
- * FRR is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; see the file COPYING; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
 #include <zebra.h>
@@ -39,6 +26,7 @@
 #include "printfrr.h"
 #include <lib/json.h>
 #include "link_state.h"
+#include "iso.h"
 
 /* Link State Memory allocation */
 DEFINE_MTYPE_STATIC(LIB, LS_DB, "Link State Database");
@@ -346,7 +334,7 @@ int ls_attributes_same(struct ls_attributes *l1, struct ls_attributes *l2)
 /**
  *  Link State prefix management functions
  */
-struct ls_prefix *ls_prefix_new(struct ls_node_id adv, struct prefix p)
+struct ls_prefix *ls_prefix_new(struct ls_node_id adv, struct prefix *p)
 {
        struct ls_prefix *new;
 
@@ -355,7 +343,7 @@ struct ls_prefix *ls_prefix_new(struct ls_node_id adv, struct prefix p)
 
        new = XCALLOC(MTYPE_LS_DB, sizeof(struct ls_prefix));
        new->adv = adv;
-       new->pref = p;
+       new->pref = *p;
 
        return new;
 }
@@ -509,7 +497,6 @@ void ls_vertex_del(struct ls_ted *ted, struct ls_vertex *vertex)
        /* Then remove Vertex from Link State Data Base and free memory */
        vertices_del(&ted->vertices, vertex);
        XFREE(MTYPE_LS_DB, vertex);
-       vertex = NULL;
 }
 
 void ls_vertex_del_all(struct ls_ted *ted, struct ls_vertex *vertex)
@@ -686,9 +673,9 @@ static void ls_edge_connect_to(struct ls_ted *ted, struct ls_edge *edge)
        }
 }
 
-static uint64_t get_edge_key(struct ls_attributes *attr, bool dst)
+static struct ls_edge_key get_edge_key(struct ls_attributes *attr, bool dst)
 {
-       uint64_t key = 0;
+       struct ls_edge_key key = {.family = AF_UNSPEC};
        struct ls_standard *std;
 
        if (!attr)
@@ -697,30 +684,37 @@ static uint64_t get_edge_key(struct ls_attributes *attr, bool dst)
        std = &attr->standard;
 
        if (dst) {
-               /* Key is the IPv4 remote address */
-               if (CHECK_FLAG(attr->flags, LS_ATTR_NEIGH_ADDR))
-                       key = ((uint64_t)ntohl(std->remote.s_addr))
-                             & 0xffffffff;
-               /* or the 64 bits LSB of IPv6 remote address */
-               else if (CHECK_FLAG(attr->flags, LS_ATTR_NEIGH_ADDR6))
-                       key = ((uint64_t)ntohl(std->remote6.s6_addr32[2]) << 32
-                              | (uint64_t)ntohl(std->remote6.s6_addr32[3]));
-               /* of remote identifier if no IP addresses are defined */
-               else if (CHECK_FLAG(attr->flags, LS_ATTR_NEIGH_ID))
-                       key = (((uint64_t)std->remote_id) & 0xffffffff)
-                             | ((uint64_t)std->local_id << 32);
+               if (CHECK_FLAG(attr->flags, LS_ATTR_NEIGH_ADDR)) {
+                       /* Key is the IPv4 remote address */
+                       key.family = AF_INET;
+                       IPV4_ADDR_COPY(&key.k.addr, &std->remote);
+               } else if (CHECK_FLAG(attr->flags, LS_ATTR_NEIGH_ADDR6)) {
+                       /* or the IPv6 remote address */
+                       key.family = AF_INET6;
+                       IPV6_ADDR_COPY(&key.k.addr6, &std->remote6);
+               } else if (CHECK_FLAG(attr->flags, LS_ATTR_NEIGH_ID)) {
+                       /* or Remote identifier if IP addr. are not defined */
+                       key.family = AF_LOCAL;
+                       key.k.link_id =
+                               (((uint64_t)std->remote_id) & 0xffffffff) |
+                               ((uint64_t)std->local_id << 32);
+               }
        } else {
-               /* Key is the IPv4 local address */
-               if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ADDR))
-                       key = ((uint64_t)ntohl(std->local.s_addr)) & 0xffffffff;
-               /* or the 64 bits LSB of IPv6 local address */
-               else if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ADDR6))
-                       key = ((uint64_t)ntohl(std->local6.s6_addr32[2]) << 32
-                              | (uint64_t)ntohl(std->local6.s6_addr32[3]));
-               /* of local identifier if no IP addresses are defined */
-               else if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ID))
-                       key = (((uint64_t)std->local_id) & 0xffffffff)
-                             | ((uint64_t)std->remote_id << 32);
+               if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ADDR)) {
+                       /* Key is the IPv4 local address */
+                       key.family = AF_INET;
+                       IPV4_ADDR_COPY(&key.k.addr, &std->local);
+               } else if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ADDR6)) {
+                       /* or the 64 bits LSB of IPv6 local address */
+                       key.family = AF_INET6;
+                       IPV6_ADDR_COPY(&key.k.addr6, &std->local6);
+               } else if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ID)) {
+                       /* or Remote identifier if IP addr. are not defined */
+                       key.family = AF_LOCAL;
+                       key.k.link_id =
+                               (((uint64_t)std->local_id) & 0xffffffff) |
+                               ((uint64_t)std->remote_id << 32);
+               }
        }
 
        return key;
@@ -730,13 +724,13 @@ struct ls_edge *ls_edge_add(struct ls_ted *ted,
                            struct ls_attributes *attributes)
 {
        struct ls_edge *new;
-       uint64_t key = 0;
+       struct ls_edge_key key;
 
        if (attributes == NULL)
                return NULL;
 
        key = get_edge_key(attributes, false);
-       if (key == 0)
+       if (key.family == AF_UNSPEC)
                return NULL;
 
        /* Create Edge and add it to the TED */
@@ -754,11 +748,12 @@ struct ls_edge *ls_edge_add(struct ls_ted *ted,
        return new;
 }
 
-struct ls_edge *ls_find_edge_by_key(struct ls_ted *ted, const uint64_t key)
+struct ls_edge *ls_find_edge_by_key(struct ls_ted *ted,
+                                   const struct ls_edge_key key)
 {
        struct ls_edge edge = {};
 
-       if (key == 0)
+       if (key.family == AF_UNSPEC)
                return NULL;
 
        edge.key = key;
@@ -774,7 +769,7 @@ struct ls_edge *ls_find_edge_by_source(struct ls_ted *ted,
                return NULL;
 
        edge.key = get_edge_key(attributes, false);
-       if (edge.key == 0)
+       if (edge.key.family == AF_UNSPEC)
                return NULL;
 
        return edges_find(&ted->edges, &edge);
@@ -789,7 +784,7 @@ struct ls_edge *ls_find_edge_by_destination(struct ls_ted *ted,
                return NULL;
 
        edge.key = get_edge_key(attributes, true);
-       if (edge.key == 0)
+       if (edge.key.family == AF_UNSPEC)
                return NULL;
 
        return edges_find(&ted->edges, &edge);
@@ -827,7 +822,7 @@ int ls_edge_same(struct ls_edge *e1, struct ls_edge *e2)
        if (!e1 && !e2)
                return 1;
 
-       if (e1->key != e2->key)
+       if (edge_cmp(e1, e2) != 0)
                return 0;
 
        if (e1->attributes == e2->attributes)
@@ -902,7 +897,7 @@ struct ls_subnet *ls_subnet_update(struct ls_ted *ted, struct ls_prefix *pref)
        if (pref == NULL)
                return NULL;
 
-       old = ls_find_subnet(ted, pref->pref);
+       old = ls_find_subnet(ted, &pref->pref);
        if (old) {
                if (!ls_prefix_same(old->ls_pref, pref)) {
                        ls_prefix_del(old->ls_pref);
@@ -955,11 +950,15 @@ void ls_subnet_del_all(struct ls_ted *ted, struct ls_subnet *subnet)
        ls_subnet_del(ted, subnet);
 }
 
-struct ls_subnet *ls_find_subnet(struct ls_ted *ted, const struct prefix prefix)
+struct ls_subnet *ls_find_subnet(struct ls_ted *ted,
+                                const struct prefix *prefix)
 {
        struct ls_subnet subnet = {};
 
-       subnet.key = prefix;
+       if (!prefix)
+               return NULL;
+
+       prefix_copy(&subnet.key, prefix);
        return subnets_find(&ted->subnets, &subnet);
 }
 
@@ -1782,9 +1781,10 @@ struct ls_vertex *ls_msg2vertex(struct ls_ted *ted, struct ls_message *msg,
        case LS_MSG_EVENT_DELETE:
                vertex = ls_find_vertex_by_id(ted, node->adv);
                if (vertex) {
-                       if (delete)
+                       if (delete) {
                                ls_vertex_del_all(ted, vertex);
-                       else
+                               vertex = NULL;
+                       } else
                                vertex->status = DELETE;
                }
                break;
@@ -1859,11 +1859,12 @@ struct ls_subnet *ls_msg2subnet(struct ls_ted *ted, struct ls_message *msg,
                        subnet->status = UPDATE;
                break;
        case LS_MSG_EVENT_DELETE:
-               subnet = ls_find_subnet(ted, pref->pref);
+               subnet = ls_find_subnet(ted, &pref->pref);
                if (subnet) {
-                       if (delete)
+                       if (delete) {
                                ls_subnet_del_all(ted, subnet);
-                       else
+                               subnet = NULL;
+                       } else
                                subnet->status = DELETE;
                }
                break;
@@ -1918,6 +1919,20 @@ void ls_delete_msg(struct ls_message *msg)
        if (msg == NULL)
                return;
 
+       if (msg->event == LS_MSG_EVENT_DELETE) {
+               switch (msg->type) {
+               case LS_MSG_TYPE_NODE:
+                       ls_node_del(msg->data.node);
+                       break;
+               case LS_MSG_TYPE_ATTRIBUTES:
+                       ls_attributes_del(msg->data.attr);
+                       break;
+               case LS_MSG_TYPE_PREFIX:
+                       ls_prefix_del(msg->data.prefix);
+                       break;
+               }
+       }
+
        XFREE(MTYPE_LS_DB, msg);
 }
 
@@ -1978,13 +1993,9 @@ static const char *const status2txt[] = {
 static const char *ls_node_id_to_text(struct ls_node_id lnid, char *str,
                                      size_t size)
 {
-       if (lnid.origin == ISIS_L1 || lnid.origin == ISIS_L2) {
-               uint8_t *id;
-
-               id = lnid.id.iso.sys_id;
-               snprintfrr(str, size, "%02x%02x.%02x%02x.%02x%02x", id[0],
-                          id[1], id[2], id[3], id[4], id[5]);
-       } else
+       if (lnid.origin == ISIS_L1 || lnid.origin == ISIS_L2)
+               snprintfrr(str, size, "%pSY", lnid.id.iso.sys_id);
+       else
                snprintfrr(str, size, "%pI4", &lnid.id.ip.addr);
 
        return str;
@@ -2190,6 +2201,34 @@ void ls_show_vertices(struct ls_ted *ted, struct vty *vty,
        }
 }
 
+static const char *edge_key_to_text(struct ls_edge_key key)
+{
+#define FORMAT_BUF_COUNT 4
+       static char buf_ring[FORMAT_BUF_COUNT][INET6_BUFSIZ];
+       static size_t cur_buf = 0;
+       char *rv;
+
+       rv = buf_ring[cur_buf];
+       cur_buf = (cur_buf + 1) % FORMAT_BUF_COUNT;
+
+       switch (key.family) {
+       case AF_INET:
+               snprintfrr(rv, INET6_BUFSIZ, "%pI4", &key.k.addr);
+               break;
+       case AF_INET6:
+               snprintfrr(rv, INET6_BUFSIZ, "%pI6", &key.k.addr6);
+               break;
+       case AF_LOCAL:
+               snprintfrr(rv, INET6_BUFSIZ, "%" PRIu64, key.k.link_id);
+               break;
+       default:
+               snprintfrr(rv, INET6_BUFSIZ, "(Unknown)");
+               break;
+       }
+
+       return rv;
+}
+
 static void ls_show_edge_vty(struct ls_edge *edge, struct vty *vty,
                             bool verbose)
 {
@@ -2202,7 +2241,7 @@ static void ls_show_edge_vty(struct ls_edge *edge, struct vty *vty,
        attr = edge->attributes;
        sbuf_init(&sbuf, NULL, 0);
 
-       sbuf_push(&sbuf, 2, "Edge (%" PRIu64 "): ", edge->key);
+       sbuf_push(&sbuf, 2, "Edge (%s): ", edge_key_to_text(edge->key));
        if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ADDR))
                sbuf_push(&sbuf, 0, "%pI4", &attr->standard.local);
        else if (CHECK_FLAG(attr->flags, LS_ATTR_LOCAL_ADDR6))
@@ -2361,7 +2400,7 @@ static void ls_show_edge_json(struct ls_edge *edge, struct json_object *json)
 
        attr = edge->attributes;
 
-       json_object_int_add(json, "edge-id", edge->key);
+       json_object_string_add(json, "edge-id", edge_key_to_text(edge->key));
        json_object_string_add(json, "status", status2txt[edge->status]);
        json_object_string_add(json, "origin", origin2txt[attr->adv.origin]);
        ls_node_id_to_text(attr->adv, buf, INET6_BUFSIZ);
@@ -2739,8 +2778,8 @@ void ls_dump_ted(struct ls_ted *ted)
                for (ALL_LIST_ELEMENTS_RO(vertex->incoming_edges, lst_node,
                                          vertex_edge)) {
                        zlog_debug(
-                               "        inc edge key:%" PRIu64 " attr key:%pI4 loc:(%pI4) rmt:(%pI4)",
-                               vertex_edge->key,
+                               "        inc edge key:%s attr key:%pI4 loc:(%pI4) rmt:(%pI4)",
+                               edge_key_to_text(vertex_edge->key),
                                &vertex_edge->attributes->adv.id.ip.addr,
                                &vertex_edge->attributes->standard.local,
                                &vertex_edge->attributes->standard.remote);
@@ -2748,15 +2787,16 @@ void ls_dump_ted(struct ls_ted *ted)
                for (ALL_LIST_ELEMENTS_RO(vertex->outgoing_edges, lst_node,
                                          vertex_edge)) {
                        zlog_debug(
-                               "        out edge key:%" PRIu64 " attr key:%pI4  loc:(%pI4) rmt:(%pI4)",
-                               vertex_edge->key,
+                               "        out edge key:%s attr key:%pI4  loc:(%pI4) rmt:(%pI4)",
+                               edge_key_to_text(vertex_edge->key),
                                &vertex_edge->attributes->adv.id.ip.addr,
                                &vertex_edge->attributes->standard.local,
                                &vertex_edge->attributes->standard.remote);
                }
        }
        frr_each (edges, &ted->edges, edge) {
-               zlog_debug("    Ted edge key:%" PRIu64 "src:%pI4 dst:%pI4", edge->key,
+               zlog_debug("    Ted edge key:%s src:%pI4 dst:%pI4",
+                          edge_key_to_text(edge->key),
                           edge->source ? &edge->source->node->router_id
                                        : &inaddr_any,
                           edge->destination