/*
- * Copyright (c) 2010, 2011, 2012, 2013 Nicira, Inc.
+ * Copyright (c) 2010, 2011, 2012, 2013, 2014, 2016, 2017, 2019 Nicira, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
#include <config.h>
#include "multipath.h"
-#include <arpa/inet.h>
-#include <inttypes.h>
#include <sys/types.h>
#include <netinet/in.h>
-#include "dynamic-string.h"
+#include <arpa/inet.h>
+#include <inttypes.h>
+#include "colors.h"
#include "nx-match.h"
-#include "ofp-actions.h"
-#include "ofp-errors.h"
-#include "ofp-util.h"
#include "openflow/nicira-ext.h"
+#include "openvswitch/dynamic-string.h"
+#include "openvswitch/ofp-actions.h"
+#include "openvswitch/ofp-errors.h"
#include "packets.h"
-#include "vlog.h"
-
-VLOG_DEFINE_THIS_MODULE(multipath);
-
-static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
+#include "util.h"
\f
-/* Converts 'nam' into 'mp'. Returns 0 if successful, otherwise an
- * OFPERR_*. */
-enum ofperr
-multipath_from_openflow(const struct nx_action_multipath *nam,
- struct ofpact_multipath *mp)
-{
- uint32_t n_links = ntohs(nam->max_link) + 1;
- size_t min_n_bits = log_2_ceil(n_links);
-
- ofpact_init_MULTIPATH(mp);
- mp->fields = ntohs(nam->fields);
- mp->basis = ntohs(nam->basis);
- mp->algorithm = ntohs(nam->algorithm);
- mp->max_link = ntohs(nam->max_link);
- mp->arg = ntohl(nam->arg);
- mp->dst.field = mf_from_nxm_header(ntohl(nam->dst));
- mp->dst.ofs = nxm_decode_ofs(nam->ofs_nbits);
- mp->dst.n_bits = nxm_decode_n_bits(nam->ofs_nbits);
-
- if (!flow_hash_fields_valid(mp->fields)) {
- VLOG_WARN_RL(&rl, "unsupported fields %d", (int) mp->fields);
- return OFPERR_OFPBAC_BAD_ARGUMENT;
- } else if (mp->algorithm != NX_MP_ALG_MODULO_N
- && mp->algorithm != NX_MP_ALG_HASH_THRESHOLD
- && mp->algorithm != NX_MP_ALG_HRW
- && mp->algorithm != NX_MP_ALG_ITER_HASH) {
- VLOG_WARN_RL(&rl, "unsupported algorithm %d", (int) mp->algorithm);
- return OFPERR_OFPBAC_BAD_ARGUMENT;
- } else if (mp->dst.n_bits < min_n_bits) {
- VLOG_WARN_RL(&rl, "multipath action requires at least %"PRIuSIZE" bits for "
- "%"PRIu32" links", min_n_bits, n_links);
- return OFPERR_OFPBAC_BAD_ARGUMENT;
- }
-
- return multipath_check(mp, NULL);
-}
-
/* Checks that 'mp' is valid on flow. Returns 0 if it is valid, otherwise an
* OFPERR_*. */
enum ofperr
multipath_check(const struct ofpact_multipath *mp,
- const struct flow *flow)
+ const struct match *match)
{
- return mf_check_dst(&mp->dst, flow);
-}
-
-/* Converts 'mp' into an OpenFlow NXAST_MULTIPATH action, which it appends to
- * 'openflow'. */
-void
-multipath_to_nxast(const struct ofpact_multipath *mp, struct ofpbuf *openflow)
-{
- struct nx_action_multipath *nam = ofputil_put_NXAST_MULTIPATH(openflow);
-
- nam->fields = htons(mp->fields);
- nam->basis = htons(mp->basis);
- nam->algorithm = htons(mp->algorithm);
- nam->max_link = htons(mp->max_link);
- nam->arg = htonl(mp->arg);
- nam->ofs_nbits = nxm_encode_ofs_nbits(mp->dst.ofs, mp->dst.n_bits);
- nam->dst = htonl(mp->dst.field->nxm_header);
+ return mf_check_dst(&mp->dst, match);
}
\f
/* multipath_execute(). */
return algorithm_iter_hash(hash, n_links, arg);
}
- NOT_REACHED();
+ OVS_NOT_REACHED();
}
\f
/* Parses 's_' as a set of arguments to the "multipath" action and initializes
- * 'mp' accordingly. ovs-ofctl(8) describes the format parsed.
+ * 'mp' accordingly. ovs-actions(7) describes the format parsed.
*
* Returns NULL if successful, otherwise a malloc()'d string describing the
* error. The caller is responsible for freeing the returned string.*/
-static char * WARN_UNUSED_RESULT
+static char * OVS_WARN_UNUSED_RESULT
multipath_parse__(struct ofpact_multipath *mp, const char *s_, char *s)
{
char *save_ptr = NULL;
mp->fields = NX_HASH_FIELDS_ETH_SRC;
} else if (!strcasecmp(fields, "symmetric_l4")) {
mp->fields = NX_HASH_FIELDS_SYMMETRIC_L4;
+ } else if (!strcasecmp(fields, "symmetric_l3l4")) {
+ mp->fields = NX_HASH_FIELDS_SYMMETRIC_L3L4;
+ } else if (!strcasecmp(fields, "symmetric_l3l4+udp")) {
+ mp->fields = NX_HASH_FIELDS_SYMMETRIC_L3L4_UDP;
+ } else if (!strcasecmp(fields, "nw_src")) {
+ mp->fields = NX_HASH_FIELDS_NW_SRC;
+ } else if (!strcasecmp(fields, "nw_dst")) {
+ mp->fields = NX_HASH_FIELDS_NW_DST;
+ } else if (!strcasecmp(fields, "symmetric_l3")) {
+ mp->fields = NX_HASH_FIELDS_SYMMETRIC_L3;
} else {
return xasprintf("%s: unknown fields `%s'", s_, fields);
}
if (error) {
return error;
}
+ if (!mf_nxm_header(mp->dst.field->id)) {
+ return xasprintf("%s: experimenter OXM field '%s' not supported",
+ s_, dst);
+ }
if (mp->dst.n_bits < 16 && n_links > (1u << mp->dst.n_bits)) {
return xasprintf("%s: %d-bit destination field has %u possible "
"values, less than specified n_links %d",
}
/* Parses 's_' as a set of arguments to the "multipath" action and initializes
- * 'mp' accordingly. ovs-ofctl(8) describes the format parsed.
+ * 'mp' accordingly. ovs-actions(7) describes the format parsed.
*
* Returns NULL if successful, otherwise a malloc()'d string describing the
* error. The caller is responsible for freeing the returned string. */
-char * WARN_UNUSED_RESULT
+char * OVS_WARN_UNUSED_RESULT
multipath_parse(struct ofpact_multipath *mp, const char *s_)
{
char *s = xstrdup(s_);
return error;
}
-/* Appends a description of 'mp' to 's', in the format that ovs-ofctl(8)
+/* Appends a description of 'mp' to 's', in the format that ovs-actions(7)
* describes. */
void
multipath_format(const struct ofpact_multipath *mp, struct ds *s)
algorithm = "<unknown>";
}
- ds_put_format(s, "multipath(%s,%"PRIu16",%s,%d,%"PRIu16",",
- fields, mp->basis, algorithm, mp->max_link + 1,
- mp->arg);
+ ds_put_format(s, "%smultipath(%s%s,%"PRIu16",%s,%d,%"PRIu32",",
+ colors.paren, colors.end, fields, mp->basis, algorithm,
+ mp->max_link + 1, mp->arg);
mf_format_subfield(&mp->dst, s);
- ds_put_char(s, ')');
+ ds_put_format(s, "%s)%s", colors.paren, colors.end);
}