ALSA: usb-audio: Carve out connector value checking into a helper

[mirror_ubuntu-jammy-kernel.git] / sound / usb / mixer.c

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index b1c78db0d4700e8e0a12127b6f548723ae10b7f1..5a2d9a768f703c121f1c191a79a3e822d6e9e10e 100644 (file)
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -1307,6 +1307,17 @@ no_res_check:
                        /* totally crap, return an error */
                        return -EINVAL;
                }
+       } else {
+               /* if the max volume is too low, it's likely a bogus range;
+                * here we use -96dB as the threshold
+                */
+               if (cval->dBmax <= -9600) {
+                       usb_audio_info(cval->head.mixer->chip,
+                                      "%d:%d: bogus dB values (%d/%d), disabling dB reporting\n",
+                                      cval->head.id, mixer_ctrl_intf(cval->head.mixer),
+                                      cval->dBmin, cval->dBmax);
+                       cval->dBmin = cval->dBmax = 0;
+               }
        }
 
        return 0;
@@ -1435,13 +1446,11 @@ static int mixer_ctl_master_bool_get(struct snd_kcontrol *kcontrol,
        return 0;
 }
 
-/* get the connectors status and report it as boolean type */
-static int mixer_ctl_connector_get(struct snd_kcontrol *kcontrol,
-                                  struct snd_ctl_elem_value *ucontrol)
+static int get_connector_value(struct usb_mixer_elem_info *cval,
+                              char *name, int *val)
 {
-       struct usb_mixer_elem_info *cval = kcontrol->private_data;
        struct snd_usb_audio *chip = cval->head.mixer->chip;
-       int idx = 0, validx, ret, val;
+       int idx = 0, validx, ret;
 
        validx = cval->control << 8 | 0;
 
@@ -1456,21 +1465,24 @@ static int mixer_ctl_connector_get(struct snd_kcontrol *kcontrol,
                ret = snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0), UAC2_CS_CUR,
                                      USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN,
                                      validx, idx, &uac2_conn, sizeof(uac2_conn));
-               val = !!uac2_conn.bNrChannels;
+               if (val)
+                       *val = !!uac2_conn.bNrChannels;
        } else { /* UAC_VERSION_3 */
                struct uac3_insertion_ctl_blk uac3_conn;
 
                ret = snd_usb_ctl_msg(chip->dev, usb_rcvctrlpipe(chip->dev, 0), UAC2_CS_CUR,
                                      USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN,
                                      validx, idx, &uac3_conn, sizeof(uac3_conn));
-               val = !!uac3_conn.bmConInserted;
+               if (val)
+                       *val = !!uac3_conn.bmConInserted;
        }
 
        snd_usb_unlock_shutdown(chip);
 
        if (ret < 0) {
-               if (strstr(kcontrol->id.name, "Speaker")) {
-                       ucontrol->value.integer.value[0] = 1;
+               if (name && strstr(name, "Speaker")) {
+                       if (val)
+                               *val = 1;
                        return 0;
                }
 error:
@@ -1480,6 +1492,21 @@ error:
                return filter_error(cval, ret);
        }
 
+       return ret;
+}
+
+/* get the connectors status and report it as boolean type */
+static int mixer_ctl_connector_get(struct snd_kcontrol *kcontrol,
+                                  struct snd_ctl_elem_value *ucontrol)
+{
+       struct usb_mixer_elem_info *cval = kcontrol->private_data;
+       int ret, val;
+
+       ret = get_connector_value(cval, kcontrol->id.name, &val);
+
+       if (ret < 0)
+               return ret;
+
        ucontrol->value.integer.value[0] = val;
        return 0;
 }