api: cluster/update-fingerprint: code cleanups and iterate sorted

[pmg-api.git] / src / PMG / API2 / Cluster.pm

diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
index 07aa8fa7b12386c36d67c0e11e0652d64fbd14fb..eda382ccc7aedb561dc4b897e2732050c2ad2c5c 100644 (file)
--- a/src/PMG/API2/Cluster.pm
+++ b/src/PMG/API2/Cluster.pm
@@ -473,15 +473,14 @@ __PACKAGE__->register_method({
 
            my $localcid = $cinfo->{local}->{cid};
 
-           foreach my $cid (keys %{$cinfo->{ids}}) {
-               my $d = $cinfo->{ids}->{$cid};
+           foreach my $cid (sort keys %{$cinfo->{ids}}) {
                my $fp;
-               if ($d->{cid} == $localcid) {
+               if ($cid == $localcid) {
                    $fp = PMG::Cluster::read_local_ssl_cert_fingerprint();
                } else {
-                   $fp = PMG::Cluster::get_remote_cert_fingerprint($d);
+                   $fp = PMG::Cluster::get_remote_cert_fingerprint($cinfo->{ids}->{$cid});
                }
-               $cinfo->{ids}->{$d->{cid}}->{fingerprint} = $fp;
+               $cinfo->{ids}->{$cid}->{fingerprint} = $fp;
            }
 
            $cinfo->write();