refuse to add non-replicatable disks to replicating VMs

[pve-container.git] / src / PVE / API2 / LXC / Config.pm

diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm
index 95eafaae7a922ce8b55ffa1608289d6c58aadf57..fc027d7ffdc6bd0712943ca51f122f16cc571022 100644 (file)
--- a/src/PVE/API2/LXC/Config.pm
+++ b/src/PVE/API2/LXC/Config.pm
@@ -15,7 +15,6 @@ use PVE::RESTHandler;
 use PVE::RPCEnvironment;
 use PVE::LXC;
 use PVE::LXC::Create;
-use PVE::HA::Config;
 use PVE::JSONSchema qw(get_standard_option);
 use base qw(PVE::RESTHandler);
 
@@ -49,10 +48,9 @@ __PACKAGE__->register_method({
     code => sub {
        my ($param) = @_;
 
-       my $conf = PVE::LXC::load_config($param->{vmid});
+       my $conf = PVE::LXC::Config->load_config($param->{vmid});
 
        delete $conf->{snapshots};
-       delete $conf->{lxc};
 
        return $conf;
     }});
@@ -74,10 +72,11 @@ __PACKAGE__->register_method({
     description => "Set container options.",
     permissions => {
        check => ['perm', '/vms/{vmid}', $vm_config_perm_list, any => 1],
+       description => 'non-volume mount points in rootfs and mp[n] are restricted to root@pam',
     },
     parameters => {
        additionalProperties => 0,
-       properties => PVE::LXC::json_config_properties(
+       properties => PVE::LXC::Config->json_config_properties(
            {
                node => get_standard_option('pve-node'),
                vmid => get_standard_option('pve-vmid', { completion => \&PVE::LXC::complete_ctid }),
@@ -113,38 +112,60 @@ __PACKAGE__->register_method({
        my $delete_str = extract_param($param, 'delete');
        my @delete = PVE::Tools::split_list($delete_str);
 
-       PVE::LXC::check_ct_modify_config_perm($rpcenv, $authuser, $vmid, undef, [@delete]);
+       PVE::LXC::check_ct_modify_config_perm($rpcenv, $authuser, $vmid, undef, {}, [@delete]);
 
        foreach my $opt (@delete) {
            raise_param_exc({ delete => "you can't use '-$opt' and " .
                                  "-delete $opt' at the same time" })
                if defined($param->{$opt});
 
-           if (!PVE::LXC::option_exists($opt)) {
+           if (!PVE::LXC::Config->option_exists($opt)) {
                raise_param_exc({ delete => "unknown option '$opt'" });
            }
        }
 
-       PVE::LXC::check_ct_modify_config_perm($rpcenv, $authuser, $vmid, undef, [keys %$param]);
+       PVE::LXC::check_ct_modify_config_perm($rpcenv, $authuser, $vmid, undef, $param, []);
 
        my $storage_cfg = cfs_read_file("storage.cfg");
 
+       my $repl_conf = PVE::ReplicationConfig->new();
+       my $is_replicated = $repl_conf->check_for_existing_jobs($vmid, 1);
+       if ($is_replicated) {
+           PVE::LXC::Config->foreach_mountpoint_full($param, 0, sub {
+               my ($opt, $mountpoint) = @_;
+               my $volid = $mountpoint->{volume};
+               return if !$volid || !($mountpoint->{replicate}//1);
+               if ($mountpoint->{type} eq 'volume') {
+                   my ($storeid, $format);
+                   if ($volid =~ $PVE::LXC::NEW_DISK_RE) {
+                       $storeid = $1;
+                       $format = $mountpoint->{format} || PVE::Storage::storage_default_format($storage_cfg, $storeid);
+                   } else {
+                       ($storeid, undef) = PVE::Storage::parse_volume_id($volid, 1);
+                       $format = (PVE::Storage::parse_volname($storage_cfg, $volid))[6];
+                   }
+                   return if PVE::Storage::storage_can_replicate($storage_cfg, $storeid, $format);
+               }
+               die "cannot add non-replicatable volume to a replicated VM\n";
+           });
+       }
+
        my $code = sub {
 
-           my $conf = PVE::LXC::load_config($vmid);
-           PVE::LXC::check_lock($conf);
+           my $conf = PVE::LXC::Config->load_config($vmid);
+           PVE::LXC::Config->check_lock($conf);
 
            PVE::Tools::assert_if_modified($digest, $conf->{digest});
 
            my $running = PVE::LXC::check_running($vmid);
 
-           PVE::LXC::update_pct_config($vmid, $conf, $running, $param, \@delete);
+           PVE::LXC::Config->update_pct_config($vmid, $conf, $running, $param, \@delete);
 
-           PVE::LXC::write_config($vmid, $conf);
-           PVE::LXC::update_lxc_config($storage_cfg, $vmid, $conf);
+           PVE::LXC::Config->write_config($vmid, $conf);
+           PVE::LXC::update_lxc_config($vmid, $conf);
        };
 
-       PVE::LXC::lock_container($vmid, undef, $code);
+       PVE::LXC::Config->lock_config($vmid, $code);
 
        return undef;
     }});