use strict;
use warnings;
-use Data::Dumper;
use PVE::SafeSyslog;
use PVE::Exception qw(raise raise_param_exc);
my $exename;
my $cli_handler_class;
+my $assert_initialized = sub {
+ my @caller = caller;
+ die "$caller[0]:$caller[2] - not initialized\n"
+ if !($cmddef && $exename && $cli_handler_class);
+};
+
+my $abort = sub {
+ my ($reason, $cmd) = @_;
+ print_usage_short (\*STDERR, $reason, $cmd);
+ exit (-1);
+};
+
my $expand_command_name = sub {
my ($def, $cmd) = @_;
if (!$def->{$cmd}) {
- my $expanded;
- for my $k (keys(%$def)) {
- if ($k =~ m/^$cmd/) {
- if ($expanded) {
- $expanded = undef; # more than one match
- last;
- } else {
- $expanded = $k;
- }
- }
- }
- $cmd = $expanded if $expanded;
+ my @expanded = grep { /^\Q$cmd\E/ } keys %$def;
+ return $expanded[0] if scalar(@expanded) == 1; # enforce exact match
}
return $cmd;
};
my $complete_command_names = sub {
- my $res = [];
-
- return if ref($cmddef) ne 'HASH';
-
- foreach my $cmd (keys %$cmddef) {
- next if $cmd eq 'help';
- push @$res, $cmd;
- }
-
- return $res;
+ return [ sort keys %$cmddef ];
};
__PACKAGE__->register_method ({
- name => 'help',
+ name => 'help',
path => 'help',
method => 'GET',
description => "Get help about specified command.",
parameters => {
- additionalProperties => 0,
+ additionalProperties => 0,
properties => {
cmd => {
description => "Command name",
},
},
returns => { type => 'null' },
-
+
code => sub {
my ($param) = @_;
- die "not initialized" if !($cmddef && $exename && $cli_handler_class);
+ $assert_initialized->();
my $cmd = $param->{cmd};
if (!$cmd) {
if ($verbose) {
print_usage_verbose();
- } else {
+ } else {
print_usage_short(\*STDOUT);
}
return undef;
sub print_simple_asciidoc_synopsis {
my ($class, $name, $arg_param, $uri_param) = @_;
- die "not initialized" if !$cli_handler_class;
+ $assert_initialized->();
my $pwcallback = $cli_handler_class->can('read_password');
my $stringfilemap = $cli_handler_class->can('string_param_file_mapping');
sub print_asciidoc_synopsis {
- die "not initialized" if !($cmddef && $exename && $cli_handler_class);
+ $assert_initialized->();
my $pwcallback = $cli_handler_class->can('read_password');
my $stringfilemap = $cli_handler_class->can('string_param_file_mapping');
sub print_usage_verbose {
- die "not initialized" if !($cmddef && $exename && $cli_handler_class);
+ $assert_initialized->();
my $pwcallback = $cli_handler_class->can('read_password');
my $stringfilemap = $cli_handler_class->can('string_param_file_mapping');
sub print_usage_short {
my ($fd, $msg) = @_;
- die "not initialized" if !($cmddef && $exename && $cli_handler_class);
+ $assert_initialized->();
my $pwcallback = $cli_handler_class->can('read_password');
my $stringfilemap = $cli_handler_class->can('string_param_file_mapping');
}
my $print_bash_completion = sub {
- my ($cmddef, $simple_cmd, $bash_command, $cur, $prev) = @_;
+ my ($simple_cmd, $bash_command, $cur, $prev) = @_;
my $debug = 0;
my $get_exe_name = sub {
my ($class) = @_;
-
+
my $name = $class;
$name =~ s/^.*:://;
$name =~ s/_/-/g;
__EOD__
}
-sub find_cli_class_source {
- my ($name) = @_;
-
- my $filename;
-
- $name =~ s/-/_/g;
-
- my $cpath = "PVE/CLI/${name}.pm";
- my $spath = "PVE/Service/${name}.pm";
- foreach my $p (@INC) {
- foreach my $s (($cpath, $spath)) {
- my $testfn = "$p/$s";
- if (-f $testfn) {
- $filename = $testfn;
- last;
- }
- }
- last if defined($filename);
- }
-
- return $filename;
-}
-
sub generate_asciidoc_synopsys {
my ($class) = @_;
$class->generate_asciidoc_synopsis();
no strict 'refs';
my $def = ${"${class}::cmddef"};
+ $cmddef = $def;
if (ref($def) eq 'ARRAY') {
print_simple_asciidoc_synopsis(@$def);
} else {
- $cmddef = $def;
-
$cmddef->{help} = [ __PACKAGE__, 'help', ['cmd'] ];
print_asciidoc_synopsis();
}
}
-my $handle_cmd = sub {
- my ($def, $cmdname, $cmd, $args, $pwcallback, $preparefunc, $stringfilemap) = @_;
+# overwrite this if you want to run/setup things early
+sub setup_environment {
+ my ($class) = @_;
- $cmddef = $def;
- $exename = $cmdname;
+ # do nothing by default
+}
+
+my $handle_cmd = sub {
+ my ($args, $pwcallback, $preparefunc, $stringfilemap) = @_;
$cmddef->{help} = [ __PACKAGE__, 'help', ['cmd'] ];
- if (!$cmd) {
- print_usage_short (\*STDERR, "no command specified");
- exit (-1);
- } elsif ($cmd eq 'verifyapi') {
+
+ my $cmd = shift @$args;
+ $abort->("no command specified") if !$cmd;
+
+ # call verifyapi before setup_environment(), don't execute any real code in
+ # this case
+ if ($cmd eq 'verifyapi') {
PVE::RESTHandler::validate_method_schemas();
return;
- } elsif ($cmd eq 'bashcomplete') {
- &$print_bash_completion($cmddef, 0, @$args);
+ }
+
+ $cli_handler_class->setup_environment();
+
+ if ($cmd eq 'bashcomplete') {
+ &$print_bash_completion(undef, @$args);
return;
}
$cmd = &$expand_command_name($cmddef, $cmd);
my ($class, $name, $arg_param, $uri_param, $outsub) = @{$cmddef->{$cmd} || []};
-
- if (!$class) {
- print_usage_short (\*STDERR, "unknown command '$cmd'");
- exit (-1);
- }
+ $abort->("unknown command '$cmd'") if !$class;
my $prefix = "$exename $cmd";
my $res = $class->cli_handler($prefix, $name, \@ARGV, $arg_param, $uri_param, $pwcallback, $stringfilemap);
};
my $handle_simple_cmd = sub {
- my ($def, $args, $pwcallback, $preparefunc, $stringfilemap) = @_;
+ my ($args, $pwcallback, $preparefunc, $stringfilemap) = @_;
- my ($class, $name, $arg_param, $uri_param, $outsub) = @{$def};
+ my ($class, $name, $arg_param, $uri_param, $outsub) = @{$cmddef};
die "no class specified" if !$class;
if (scalar(@$args) >= 1) {
$str .= $class->usage_str($name, $name, $arg_param, $uri_param, 'long', $pwcallback, $stringfilemap);
print STDERR "$str\n\n";
return;
- } elsif ($args->[0] eq 'bashcomplete') {
- shift @$args;
- &$print_bash_completion({ $name => $def }, $name, @$args);
- return;
} elsif ($args->[0] eq 'verifyapi') {
PVE::RESTHandler::validate_method_schemas();
return;
}
}
+ $cli_handler_class->setup_environment();
+
+ if (scalar(@$args) >= 1) {
+ if ($args->[0] eq 'bashcomplete') {
+ shift @$args;
+ &$print_bash_completion($name, @$args);
+ return;
+ }
+ }
+
&$preparefunc() if $preparefunc;
my $res = $class->cli_handler($name, $name, \@ARGV, $arg_param, $uri_param, $pwcallback, $stringfilemap);
&$outsub($res) if $outsub;
};
-sub run_cli {
- my ($class, $pwcallback, $podfn, $preparefunc) = @_;
-
- # Note: "depreciated function run_cli - use run_cli_handler instead";
- # silently ignore $podfn , which is no longer supported.
-
- die "password callback is no longer supported" if $pwcallback;
-
- run_cli_handler($class, prepare => $preparefunc);
-}
-
sub run_cli_handler {
my ($class, %params) = @_;
foreach my $key (keys %params) {
next if $key eq 'prepare';
- next if $key eq 'no_init'; # used by lxc hooks
- next if $key eq 'no_rpcenv';
+ next if $key eq 'no_init'; # not used anymore
+ next if $key eq 'no_rpcenv'; # not used anymore
die "unknown parameter '$key'";
}
my $preparefunc = $params{prepare};
- my $no_init = $params{no_init};
- my $no_rpcenv = $params{no_rpcenv};
my $pwcallback = $class->can('read_password');
my $stringfilemap = $class->can('string_param_file_mapping');
initlog($exename);
- if ($class !~ m/^PVE::Service::/) {
- die "please run as root\n" if $> != 0;
-
- PVE::INotify::inotify_init() if !$no_init;
-
- if (!$no_rpcenv) {
- my $rpcenv = PVE::RPCEnvironment->init('cli');
- $rpcenv->init_request() if !$no_init;
- $rpcenv->set_language($ENV{LANG});
- $rpcenv->set_user('root@pam');
- }
- }
-
no strict 'refs';
- my $def = ${"${class}::cmddef"};
+ $cmddef = ${"${class}::cmddef"};
- if (ref($def) eq 'ARRAY') {
- &$handle_simple_cmd($def, \@ARGV, $pwcallback, $preparefunc, $stringfilemap);
+ if (ref($cmddef) eq 'ARRAY') {
+ &$handle_simple_cmd(\@ARGV, $pwcallback, $preparefunc, $stringfilemap);
} else {
- $cmddef = $def;
- my $cmd = shift @ARGV;
- &$handle_cmd($cmddef, $exename, $cmd, \@ARGV, $pwcallback, $preparefunc, $stringfilemap);
+ &$handle_cmd(\@ARGV, $pwcallback, $preparefunc, $stringfilemap);
}
exit 0;