//! Sync datastore from remote server
-use std::sync::{Arc};
+use std::convert::TryFrom;
use anyhow::{format_err, Error};
use futures::{select, future::FutureExt};
-use proxmox::api::api;
-use proxmox::api::{ApiMethod, Router, RpcEnvironment, Permission};
-
-use crate::server::{WorkerTask, jobstate::Job};
-use crate::backup::DataStore;
-use crate::client::{HttpClient, HttpClientOptions, BackupRepository, pull::pull_store};
-use crate::api2::types::*;
-use crate::config::{
- remote,
- sync::SyncJobConfig,
- acl::{PRIV_DATASTORE_BACKUP, PRIV_DATASTORE_PRUNE, PRIV_REMOTE_READ},
- cached_user_info::CachedUserInfo,
+use proxmox_schema::api;
+use proxmox_router::{ApiMethod, Router, RpcEnvironment, Permission};
+use proxmox_sys::task_log;
+
+use pbs_api_types::{
+ Authid, SyncJobConfig, GroupFilter, RateLimitConfig, GROUP_FILTER_LIST_SCHEMA,
+ DATASTORE_SCHEMA, REMOTE_ID_SCHEMA, REMOVE_VANISHED_BACKUPS_SCHEMA,
+ PRIV_DATASTORE_BACKUP, PRIV_DATASTORE_PRUNE, PRIV_REMOTE_READ,
};
+use proxmox_rest_server::WorkerTask;
+use pbs_config::CachedUserInfo;
+
+use crate::server::pull::{PullParameters, pull_store};
+use crate::server::jobstate::Job;
pub fn check_pull_privs(
Ok(())
}
-pub async fn get_pull_parameters(
- store: &str,
- remote: &str,
- remote_store: &str,
-) -> Result<(HttpClient, BackupRepository, Arc<DataStore>), Error> {
-
- let tgt_store = DataStore::lookup_datastore(store)?;
-
- let (remote_config, _digest) = remote::config()?;
- let remote: remote::Remote = remote_config.lookup("remote", remote)?;
-
- let options = HttpClientOptions::new()
- .password(Some(remote.password.clone()))
- .fingerprint(remote.fingerprint.clone());
-
- let src_repo = BackupRepository::new(Some(remote.userid.clone()), Some(remote.host.clone()), remote.port, remote_store.to_string());
-
- let client = HttpClient::new(&src_repo.host(), src_repo.port(), &src_repo.auth_id(), options)?;
- let _auth_info = client.login() // make sure we can auth
- .await
- .map_err(|err| format_err!("remote connection to '{}' failed - {}", remote.host, err))?;
-
-
- Ok((client, src_repo, tgt_store))
+impl TryFrom<&SyncJobConfig> for PullParameters {
+ type Error = Error;
+
+ fn try_from(sync_job: &SyncJobConfig) -> Result<Self, Self::Error> {
+ PullParameters::new(
+ &sync_job.store,
+ &sync_job.remote,
+ &sync_job.remote_store,
+ sync_job.owner.as_ref().unwrap_or_else(|| Authid::root_auth_id()).clone(),
+ sync_job.remove_vanished,
+ sync_job.group_filter.clone(),
+ sync_job.limit.clone(),
+ )
+ }
}
pub fn do_sync_job(
sync_job: SyncJobConfig,
auth_id: &Authid,
schedule: Option<String>,
+ to_stdout: bool,
) -> Result<String, Error> {
- let job_id = job.jobname().to_string();
+ let job_id = format!("{}:{}:{}:{}",
+ sync_job.remote,
+ sync_job.remote_store,
+ sync_job.store,
+ job.jobname());
let worker_type = job.jobtype().to_string();
let (email, notify) = crate::server::lookup_datastore_notify_settings(&sync_job.store);
let upid_str = WorkerTask::spawn(
&worker_type,
- Some(job.jobname().to_string()),
- auth_id.clone(),
- false,
+ Some(job_id.clone()),
+ auth_id.to_string(),
+ to_stdout,
move |worker| async move {
job.start(&worker.upid().to_string())?;
let worker_future = async move {
- let delete = sync_job.remove_vanished.unwrap_or(true);
- let sync_owner = sync_job.owner.unwrap_or(Authid::backup_auth_id().clone());
- let (client, src_repo, tgt_store) = get_pull_parameters(&sync_job.store, &sync_job.remote, &sync_job.remote_store).await?;
+ let pull_params = PullParameters::try_from(&sync_job)?;
+ let client = pull_params.client().await?;
- worker.log(format!("Starting datastore sync job '{}'", job_id));
+ task_log!(worker, "Starting datastore sync job '{}'", job_id);
if let Some(event_str) = schedule {
- worker.log(format!("task triggered by schedule '{}'", event_str));
+ task_log!(worker, "task triggered by schedule '{}'", event_str);
}
- worker.log(format!("Sync datastore '{}' from '{}/{}'",
- sync_job.store, sync_job.remote, sync_job.remote_store));
+ task_log!(
+ worker,
+ "sync datastore '{}' from '{}/{}'",
+ sync_job.store,
+ sync_job.remote,
+ sync_job.remote_store,
+ );
- crate::client::pull::pull_store(&worker, &client, &src_repo, tgt_store.clone(), delete, sync_owner).await?;
+ pull_store(&worker, &client, &pull_params).await?;
- worker.log(format!("sync job '{}' end", &job_id));
+ task_log!(worker, "sync job '{}' end", &job_id);
Ok(())
};
schema: REMOVE_VANISHED_BACKUPS_SCHEMA,
optional: true,
},
+ "group-filter": {
+ schema: GROUP_FILTER_LIST_SCHEMA,
+ optional: true,
+ },
+ limit: {
+ type: RateLimitConfig,
+ flatten: true,
+ }
},
},
access: {
remote: String,
remote_store: String,
remove_vanished: Option<bool>,
+ group_filter: Option<Vec<GroupFilter>>,
+ limit: RateLimitConfig,
_info: &ApiMethod,
rpcenv: &mut dyn RpcEnvironment,
) -> Result<String, Error> {
let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?;
- let delete = remove_vanished.unwrap_or(true);
+ let delete = remove_vanished.unwrap_or(false);
check_pull_privs(&auth_id, &store, &remote, &remote_store, delete)?;
- let (client, src_repo, tgt_store) = get_pull_parameters(&store, &remote, &remote_store).await?;
+ let pull_params = PullParameters::new(
+ &store,
+ &remote,
+ &remote_store,
+ auth_id.clone(),
+ remove_vanished,
+ group_filter,
+ limit,
+ )?;
+ let client = pull_params.client().await?;
// fixme: set to_stdout to false?
- let upid_str = WorkerTask::spawn("sync", Some(store.clone()), auth_id.clone(), true, move |worker| async move {
+ let upid_str = WorkerTask::spawn("sync", Some(store.clone()), auth_id.to_string(), true, move |worker| async move {
- worker.log(format!("sync datastore '{}' start", store));
+ task_log!(worker, "sync datastore '{}' start", store);
- let pull_future = pull_store(&worker, &client, &src_repo, tgt_store.clone(), delete, auth_id);
+ let pull_future = pull_store(&worker, &client, &pull_params);
let future = select!{
success = pull_future.fuse() => success,
abort = worker.abort_future().map(|_| Err(format_err!("pull aborted"))) => abort,
let _ = future?;
- worker.log(format!("sync datastore '{}' end", store));
+ task_log!(worker, "sync datastore '{}' end", store);
Ok(())
})?;
projects / proxmox-backup.git / blobdiff