-use std::sync::{Arc};
+use std::sync::Arc;
use std::path::{Path, PathBuf};
use std::os::unix::io::AsRawFd;
use anyhow::{bail, format_err, Error};
use futures::*;
-use hyper;
+
use openssl::ssl::{SslMethod, SslAcceptor, SslFiletype};
+use tokio_stream::wrappers::ReceiverStream;
use proxmox::try_block;
use proxmox::api::RpcEnvironmentType;
use proxmox_backup::{
backup::DataStore,
server::{
- UPID,
WorkerTask,
ApiConfig,
rest::*,
DiskManage,
zfs_pool_stats,
},
+ logrotate::LogRotate,
socket::{
set_tcp_keepalive,
PROXMOX_BACKUP_TCP_KEEPALIVE_TIME,
bail!("unable to inititialize syslog - {}", err);
}
+ // Note: To debug early connection error use
+ // PROXMOX_DEBUG=1 ./target/release/proxmox-backup-proxy
+ let debug = std::env::var("PROXMOX_DEBUG").is_ok();
+
let _ = public_auth_key(); // load with lazy_static
let _ = csrf_secret(); // load with lazy_static
config.add_alias("novnc", "/usr/share/novnc-pve");
config.add_alias("extjs", "/usr/share/javascript/extjs");
+ config.add_alias("qrcodejs", "/usr/share/javascript/qrcodejs");
config.add_alias("fontawesome", "/usr/share/fonts-font-awesome");
config.add_alias("xtermjs", "/usr/share/pve-xtermjs");
config.add_alias("locale", "/usr/share/pbs-i18n");
config.add_alias("widgettoolkit", "/usr/share/javascript/proxmox-widget-toolkit");
- config.add_alias("css", "/usr/share/javascript/proxmox-backup/css");
config.add_alias("docs", "/usr/share/doc/proxmox-backup/html");
let mut indexpath = PathBuf::from(buildcfg::JS_DIR);
let mut commando_sock = server::CommandoSocket::new(server::our_ctrl_sock());
- config.enable_file_log(buildcfg::API_ACCESS_LOG_FN)?;
+ config.enable_file_log(buildcfg::API_ACCESS_LOG_FN, &mut commando_sock)?;
let rest_server = RestServer::new(config);
let server = daemon::create_daemon(
([0,0,0,0,0,0,0,0], 8007).into(),
|listener, ready| {
- let connections = proxmox_backup::tools::async_io::StaticIncoming::from(listener)
- .map_err(Error::from)
- .try_filter_map(move |(sock, _addr)| {
- let acceptor = Arc::clone(&acceptor);
- async move {
- sock.set_nodelay(true).unwrap();
- let _ = set_tcp_keepalive(sock.as_raw_fd(), PROXMOX_BACKUP_TCP_KEEPALIVE_TIME);
-
- Ok(tokio_openssl::accept(&acceptor, sock)
- .await
- .ok() // handshake errors aren't be fatal, so return None to filter
- )
- }
- });
- let connections = proxmox_backup::tools::async_io::HyperAccept(connections);
+ let connections = accept_connections(listener, acceptor, debug);
+ let connections = hyper::server::accept::from_stream(ReceiverStream::new(connections));
Ok(ready
- .and_then(|_| hyper::Server::builder(connections)
+ .and_then(|_| hyper::Server::builder(connections)
.serve(rest_server)
.with_graceful_shutdown(server::shutdown_future())
.map_err(Error::from)
.map(|_| ())
)
},
+ "proxmox-backup-proxy.service",
);
server::write_pid(buildcfg::PROXMOX_BACKUP_PROXY_PID_FN)?;
Ok(())
}
+fn accept_connections(
+ listener: tokio::net::TcpListener,
+ acceptor: Arc<openssl::ssl::SslAcceptor>,
+ debug: bool,
+) -> tokio::sync::mpsc::Receiver<Result<std::pin::Pin<Box<tokio_openssl::SslStream<tokio::net::TcpStream>>>, Error>> {
+
+ const MAX_PENDING_ACCEPTS: usize = 1024;
+
+ let (sender, receiver) = tokio::sync::mpsc::channel(MAX_PENDING_ACCEPTS);
+
+ let accept_counter = Arc::new(());
+
+ tokio::spawn(async move {
+ loop {
+ match listener.accept().await {
+ Err(err) => {
+ eprintln!("error accepting tcp connection: {}", err);
+ }
+ Ok((sock, _addr)) => {
+ sock.set_nodelay(true).unwrap();
+ let _ = set_tcp_keepalive(sock.as_raw_fd(), PROXMOX_BACKUP_TCP_KEEPALIVE_TIME);
+ let acceptor = Arc::clone(&acceptor);
+
+ let ssl = match openssl::ssl::Ssl::new(acceptor.context()) {
+ Ok(ssl) => ssl,
+ Err(err) => {
+ eprintln!("failed to create Ssl object from Acceptor context - {}", err);
+ continue;
+ },
+ };
+ let stream = match tokio_openssl::SslStream::new(ssl, sock) {
+ Ok(stream) => stream,
+ Err(err) => {
+ eprintln!("failed to create SslStream using ssl and connection socket - {}", err);
+ continue;
+ },
+ };
+
+ let mut stream = Box::pin(stream);
+ let sender = sender.clone();
+
+ if Arc::strong_count(&accept_counter) > MAX_PENDING_ACCEPTS {
+ eprintln!("connection rejected - to many open connections");
+ continue;
+ }
+
+ let accept_counter = accept_counter.clone();
+ tokio::spawn(async move {
+ let accept_future = tokio::time::timeout(
+ Duration::new(10, 0), stream.as_mut().accept());
+
+ let result = accept_future.await;
+
+ match result {
+ Ok(Ok(())) => {
+ if sender.send(Ok(stream)).await.is_err() && debug {
+ eprintln!("detect closed connection channel");
+ }
+ }
+ Ok(Err(err)) => {
+ if debug {
+ eprintln!("https handshake failed - {}", err);
+ }
+ }
+ Err(_) => {
+ if debug {
+ eprintln!("https handshake timeout");
+ }
+ }
+ }
+
+ drop(accept_counter); // decrease reference count
+ });
+ }
+ }
+ }
+ });
+
+ receiver
+}
+
fn start_stat_generator() {
let abort_future = server::shutdown_future();
let future = Box::pin(run_stat_generator());
Ok(d) => d,
Err(err) => {
eprintln!("task scheduler: compute next minute failed - {}", err);
- tokio::time::delay_until(tokio::time::Instant::from_std(Instant::now() + Duration::from_secs(60))).await;
+ tokio::time::sleep_until(tokio::time::Instant::from_std(Instant::now() + Duration::from_secs(60))).await;
continue;
}
};
}
}
- tokio::time::delay_until(tokio::time::Instant::from_std(delay_target)).await;
+ tokio::time::sleep_until(tokio::time::Instant::from_std(delay_target)).await;
}
}
let worker_type = "garbage_collection";
- let stat = datastore.last_gc_status();
- let last = if let Some(upid_str) = stat.upid {
- match upid_str.parse::<UPID>() {
- Ok(upid) => upid.starttime,
- Err(err) => {
- eprintln!("unable to parse upid '{}' - {}", upid_str, err);
- continue;
- }
- }
- } else {
- match jobstate::last_run_time(worker_type, &store) {
- Ok(time) => time,
- Err(err) => {
- eprintln!("could not get last run time of {} {}: {}", worker_type, store, err);
- continue;
- }
+ let last = match jobstate::last_run_time(worker_type, &store) {
+ Ok(time) => time,
+ Err(err) => {
+ eprintln!("could not get last run time of {} {}: {}", worker_type, store, err);
+ continue;
}
};
Err(_) => continue, // could not get lock
};
- let auth_id = Authid::backup_auth_id();
+ let auth_id = Authid::root_auth_id();
- if let Err(err) = crate::server::do_garbage_collection_job(job, datastore, auth_id, Some(event_str)) {
+ if let Err(err) = crate::server::do_garbage_collection_job(job, datastore, auth_id, Some(event_str), false) {
eprintln!("unable to start garbage collection job on datastore {} - {}", store, err);
}
}
Err(_) => continue, // could not get lock
};
- let auth_id = Authid::backup_auth_id().clone();
+ let auth_id = Authid::root_auth_id().clone();
if let Err(err) = do_prune_job(job, prune_options, store.clone(), &auth_id, Some(event_str)) {
eprintln!("unable to start datastore prune job {} - {}", &store, err);
}
Err(_) => continue, // could not get lock
};
- let auth_id = Authid::backup_auth_id().clone();
+ let auth_id = Authid::root_auth_id().clone();
if let Err(err) = do_sync_job(job, job_config, &auth_id, Some(event_str)) {
eprintln!("unable to start datastore sync job {} - {}", &job_id, err);
}
};
let worker_type = "verificationjob";
- let auth_id = Authid::backup_auth_id().clone();
+ let auth_id = Authid::root_auth_id().clone();
if check_schedule(worker_type, &event_str, &job_id) {
let job = match Job::new(&worker_type, &job_id) {
Ok(job) => job,
async fn schedule_task_log_rotate() {
let worker_type = "logrotate";
- let job_id = "task_archive";
+ let job_id = "access-log_and_task-archive";
// schedule daily at 00:00 like normal logrotate
let schedule = "00:00";
if let Err(err) = WorkerTask::new_thread(
worker_type,
- Some(job_id.to_string()),
- Authid::backup_auth_id().clone(),
+ None,
+ Authid::root_auth_id().clone(),
false,
move |worker| {
job.start(&worker.upid().to_string())?;
- worker.log(format!("starting task log rotation"));
+ worker.log("starting task log rotation".to_string());
let result = try_block!({
- // rotate task log archive
- let max_size = 500000; // a normal entry has about 100b, so ~ 5000 entries/file
- let max_files = 20; // times twenty files gives at least 100000 task entries
+ let max_size = 512 * 1024 - 1; // an entry has ~ 100b, so > 5000 entries/file
+ let max_files = 20; // times twenty files gives > 100000 task entries
let has_rotated = rotate_task_log_archive(max_size, true, Some(max_files))?;
if has_rotated {
- worker.log(format!("task log archive was rotated"));
+ worker.log("task log archive was rotated".to_string());
} else {
- worker.log(format!("task log archive was not rotated"));
+ worker.log("task log archive was not rotated".to_string());
+ }
+
+ let max_size = 32 * 1024 * 1024 - 1;
+ let max_files = 14;
+ let mut logrotate = LogRotate::new(buildcfg::API_ACCESS_LOG_FN, true)
+ .ok_or_else(|| format_err!("could not get API access log file names"))?;
+
+ if logrotate.rotate(max_size, None, Some(max_files))? {
+ println!("rotated access log, telling daemons to re-open log file");
+ proxmox_backup::tools::runtime::block_on(command_reopen_logfiles())?;
+ worker.log("API access log was rotated".to_string());
+ } else {
+ worker.log("API access log was not rotated".to_string());
+ }
+
+ let mut logrotate = LogRotate::new(buildcfg::API_AUTH_LOG_FN, true)
+ .ok_or_else(|| format_err!("could not get API auth log file names"))?;
+
+ if logrotate.rotate(max_size, None, Some(max_files))? {
+ worker.log("API authentication log was rotated".to_string());
+ } else {
+ worker.log("API authentication log was not rotated".to_string());
}
Ok(())
}
+async fn command_reopen_logfiles() -> Result<(), Error> {
+ // only care about the most recent daemon instance for each, proxy & api, as other older ones
+ // should not respond to new requests anyway, but only finish their current one and then exit.
+ let sock = server::our_ctrl_sock();
+ let f1 = server::send_command(sock, serde_json::json!({
+ "command": "api-access-log-reopen",
+ }));
+
+ let pid = server::read_pid(buildcfg::PROXMOX_BACKUP_API_PID_FN)?;
+ let sock = server::ctrl_sock_from_pid(pid);
+ let f2 = server::send_command(sock, serde_json::json!({
+ "command": "api-access-log-reopen",
+ }));
+
+ match futures::join!(f1, f2) {
+ (Err(e1), Err(e2)) => Err(format_err!("reopen commands failed, proxy: {}; api: {}", e1, e2)),
+ (Err(e1), Ok(_)) => Err(format_err!("reopen commands failed, proxy: {}", e1)),
+ (Ok(_), Err(e2)) => Err(format_err!("reopen commands failed, api: {}", e2)),
+ _ => Ok(()),
+ }
+}
+
async fn run_stat_generator() {
let mut count = 0;
generate_host_stats(save).await;
- tokio::time::delay_until(tokio::time::Instant::from_std(delay_target)).await;
+ tokio::time::sleep_until(tokio::time::Instant::from_std(delay_target)).await;
}
match datastore::config() {
Ok((config, _)) => {
let datastore_list: Vec<datastore::DataStoreConfig> =
- config.convert_to_typed_array("datastore").unwrap_or(Vec::new());
+ config.convert_to_typed_array("datastore").unwrap_or_default();
for config in datastore_list {
projects / proxmox-backup.git / blobdiff