]> git.proxmox.com Git - libgit2.git/blobdiff - src/cherrypick.c
push: remove own copy of callbacks
[libgit2.git] / src / cherrypick.c
index e02348a03fde70aacb7341afad48e86fc2e62670..c92975194bc1f2bef9b73f2828b6c73bc13d298e 100644 (file)
@@ -10,6 +10,7 @@
 #include "filebuf.h"
 #include "merge.h"
 #include "vector.h"
+#include "index.h"
 
 #include "git2/types.h"
 #include "git2/merge.h"
@@ -17,9 +18,9 @@
 #include "git2/commit.h"
 #include "git2/sys/commit.h"
 
-#define GIT_CHERRY_PICK_FILE_MODE              0666
+#define GIT_CHERRYPICK_FILE_MODE               0666
 
-static int write_cherry_pick_head(
+static int write_cherrypick_head(
        git_repository *repo,
        const char *commit_oidstr)
 {
@@ -27,8 +28,8 @@ static int write_cherry_pick_head(
        git_buf file_path = GIT_BUF_INIT;
        int error = 0;
 
-       if ((error = git_buf_joinpath(&file_path, repo->path_repository, GIT_CHERRY_PICK_HEAD_FILE)) >= 0 &&
-               (error = git_filebuf_open(&file, file_path.ptr, GIT_FILEBUF_FORCE, GIT_CHERRY_PICK_FILE_MODE)) >= 0 &&
+       if ((error = git_buf_joinpath(&file_path, repo->path_repository, GIT_CHERRYPICK_HEAD_FILE)) >= 0 &&
+               (error = git_filebuf_open(&file, file_path.ptr, GIT_FILEBUF_FORCE, GIT_CHERRYPICK_FILE_MODE)) >= 0 &&
                (error = git_filebuf_printf(&file, "%s\n", commit_oidstr)) >= 0)
                error = git_filebuf_commit(&file);
 
@@ -49,7 +50,7 @@ static int write_merge_msg(
        int error = 0;
 
        if ((error = git_buf_joinpath(&file_path, repo->path_repository, GIT_MERGE_MSG_FILE)) < 0 ||
-               (error = git_filebuf_open(&file, file_path.ptr, GIT_FILEBUF_FORCE, GIT_CHERRY_PICK_FILE_MODE)) < 0 ||
+               (error = git_filebuf_open(&file, file_path.ptr, GIT_FILEBUF_FORCE, GIT_CHERRYPICK_FILE_MODE)) < 0 ||
                (error = git_filebuf_printf(&file, "%s", commit_msg)) < 0)
                goto cleanup;
 
@@ -64,23 +65,23 @@ cleanup:
        return error;
 }
 
-static int cherry_pick_normalize_opts(
+static int cherrypick_normalize_opts(
        git_repository *repo,
-       git_cherry_pick_options *opts,
-       const git_cherry_pick_options *given,
+       git_cherrypick_options *opts,
+       const git_cherrypick_options *given,
        const char *their_label)
 {
        int error = 0;
-       unsigned int default_checkout_strategy = GIT_CHECKOUT_SAFE_CREATE |
+       unsigned int default_checkout_strategy = GIT_CHECKOUT_SAFE |
                GIT_CHECKOUT_ALLOW_CONFLICTS;
 
        GIT_UNUSED(repo);
 
        if (given != NULL)
-               memcpy(opts, given, sizeof(git_cherry_pick_options));
+               memcpy(opts, given, sizeof(git_cherrypick_options));
        else {
-               git_cherry_pick_options default_opts = GIT_CHERRY_PICK_OPTIONS_INIT;
-               memcpy(opts, &default_opts, sizeof(git_cherry_pick_options));
+               git_cherrypick_options default_opts = GIT_CHERRYPICK_OPTIONS_INIT;
+               memcpy(opts, &default_opts, sizeof(git_cherrypick_options));
        }
 
        if (!opts->checkout_opts.checkout_strategy)
@@ -95,14 +96,14 @@ static int cherry_pick_normalize_opts(
        return error;
 }
 
-static int cherry_pick_state_cleanup(git_repository *repo)
+static int cherrypick_state_cleanup(git_repository *repo)
 {
-       const char *state_files[] = { GIT_CHERRY_PICK_HEAD_FILE, GIT_MERGE_MSG_FILE };
+       const char *state_files[] = { GIT_CHERRYPICK_HEAD_FILE, GIT_MERGE_MSG_FILE };
 
        return git_repository__cleanup_files(repo, state_files, ARRAY_SIZE(state_files));
 }
 
-static int cherry_pick_seterr(git_commit *commit, const char *fmt)
+static int cherrypick_seterr(git_commit *commit, const char *fmt)
 {
        char commit_oidstr[GIT_OID_HEXSZ + 1];
 
@@ -112,71 +113,72 @@ static int cherry_pick_seterr(git_commit *commit, const char *fmt)
        return -1;
 }
 
-int git_cherry_pick_commit(
+int git_cherrypick_commit(
        git_index **out,
        git_repository *repo,
-       git_commit *cherry_pick_commit,
+       git_commit *cherrypick_commit,
        git_commit *our_commit,
        unsigned int mainline,
        const git_merge_options *merge_opts)
 {
        git_commit *parent_commit = NULL;
-       git_tree *parent_tree = NULL, *our_tree = NULL, *cherry_pick_tree = NULL;
+       git_tree *parent_tree = NULL, *our_tree = NULL, *cherrypick_tree = NULL;
        int parent = 0, error = 0;
 
-       assert(out && repo && cherry_pick_commit && our_commit);
+       assert(out && repo && cherrypick_commit && our_commit);
 
-       if (git_commit_parentcount(cherry_pick_commit) > 1) {
+       if (git_commit_parentcount(cherrypick_commit) > 1) {
                if (!mainline)
-                       return cherry_pick_seterr(cherry_pick_commit,
+                       return cherrypick_seterr(cherrypick_commit,
                                "Mainline branch is not specified but %s is a merge commit");
 
                parent = mainline;
        } else {
                if (mainline)
-                       return cherry_pick_seterr(cherry_pick_commit,
+                       return cherrypick_seterr(cherrypick_commit,
                                "Mainline branch specified but %s is not a merge commit");
 
-               parent = git_commit_parentcount(cherry_pick_commit);
+               parent = git_commit_parentcount(cherrypick_commit);
        }
 
        if (parent &&
-               ((error = git_commit_parent(&parent_commit, cherry_pick_commit, (parent - 1))) < 0 ||
+               ((error = git_commit_parent(&parent_commit, cherrypick_commit, (parent - 1))) < 0 ||
                (error = git_commit_tree(&parent_tree, parent_commit)) < 0))
                goto done;
 
-       if ((error = git_commit_tree(&cherry_pick_tree, cherry_pick_commit)) < 0 ||
+       if ((error = git_commit_tree(&cherrypick_tree, cherrypick_commit)) < 0 ||
                (error = git_commit_tree(&our_tree, our_commit)) < 0)
                goto done;
 
-       error = git_merge_trees(out, repo, parent_tree, our_tree, cherry_pick_tree, merge_opts);
+       error = git_merge_trees(out, repo, parent_tree, our_tree, cherrypick_tree, merge_opts);
 
 done:
        git_tree_free(parent_tree);
        git_tree_free(our_tree);
-       git_tree_free(cherry_pick_tree);
+       git_tree_free(cherrypick_tree);
        git_commit_free(parent_commit);
 
        return error;
 }
 
-int git_cherry_pick(
+int git_cherrypick(
        git_repository *repo,
        git_commit *commit,
-       const git_cherry_pick_options *given_opts)
+       const git_cherrypick_options *given_opts)
 {
-       git_cherry_pick_options opts;
+       git_cherrypick_options opts;
        git_reference *our_ref = NULL;
        git_commit *our_commit = NULL;
        char commit_oidstr[GIT_OID_HEXSZ + 1];
        const char *commit_msg, *commit_summary;
        git_buf their_label = GIT_BUF_INIT;
-       git_index *index_new = NULL, *index_repo = NULL;
+       git_index *index = NULL;
+       git_indexwriter indexwriter = GIT_INDEXWRITER_INIT;
        int error = 0;
 
        assert(repo && commit);
 
-       GITERR_CHECK_VERSION(given_opts, GIT_CHERRY_PICK_OPTIONS_VERSION, "git_cherry_pick_options");
+       GITERR_CHECK_VERSION(given_opts, GIT_CHERRYPICK_OPTIONS_VERSION, "git_cherrypick_options");
 
        if ((error = git_repository__ensure_not_bare(repo, "cherry-pick")) < 0)
                return error;
@@ -191,25 +193,26 @@ int git_cherry_pick(
 
        if ((error = write_merge_msg(repo, commit_msg)) < 0 ||
                (error = git_buf_printf(&their_label, "%.7s... %s", commit_oidstr, commit_summary)) < 0 ||
-               (error = cherry_pick_normalize_opts(repo, &opts, given_opts, git_buf_cstr(&their_label))) < 0 ||
-               (error = write_cherry_pick_head(repo, commit_oidstr)) < 0 ||
+               (error = cherrypick_normalize_opts(repo, &opts, given_opts, git_buf_cstr(&their_label))) < 0 ||
+               (error = git_indexwriter_init_for_operation(&indexwriter, repo, &opts.checkout_opts.checkout_strategy)) < 0 ||
+               (error = write_cherrypick_head(repo, commit_oidstr)) < 0 ||
                (error = git_repository_head(&our_ref, repo)) < 0 ||
                (error = git_reference_peel((git_object **)&our_commit, our_ref, GIT_OBJ_COMMIT)) < 0 ||
-               (error = git_cherry_pick_commit(&index_new, repo, commit, our_commit, opts.mainline, &opts.merge_opts)) < 0 ||
-               (error = git_merge__indexes(repo, index_new)) < 0 ||
-               (error = git_repository_index(&index_repo, repo)) < 0 ||
-               (error = git_merge__append_conflicts_to_merge_msg(repo, index_repo)) < 0 ||
-               (error = git_checkout_index(repo, index_repo, &opts.checkout_opts)) < 0)
+               (error = git_cherrypick_commit(&index, repo, commit, our_commit, opts.mainline, &opts.merge_opts)) < 0 ||
+               (error = git_merge__check_result(repo, index)) < 0 ||
+               (error = git_merge__append_conflicts_to_merge_msg(repo, index)) < 0 ||
+               (error = git_checkout_index(repo, index, &opts.checkout_opts)) < 0 ||
+               (error = git_indexwriter_commit(&indexwriter)) < 0)
                goto on_error;
 
        goto done;
 
 on_error:
-       cherry_pick_state_cleanup(repo);
+       cherrypick_state_cleanup(repo);
 
 done:
-       git_index_free(index_new);
-       git_index_free(index_repo);
+       git_indexwriter_cleanup(&indexwriter);
+       git_index_free(index);
        git_commit_free(our_commit);
        git_reference_free(our_ref);
        git_buf_free(&their_label);
@@ -217,10 +220,10 @@ done:
        return error;
 }
 
-int git_cherry_pick_init_options(
-       git_cherry_pick_options *opts, unsigned int version)
+int git_cherrypick_init_options(
+       git_cherrypick_options *opts, unsigned int version)
 {
        GIT_INIT_STRUCTURE_FROM_TEMPLATE(
-               opts, version, git_cherry_pick_options, GIT_CHERRY_PICK_OPTIONS_INIT);
+               opts, version, git_cherrypick_options, GIT_CHERRYPICK_OPTIONS_INIT);
        return 0;
 }