]> git.proxmox.com Git - libgit2.git/blobdiff - src/fetchhead.c
New upstream version 1.4.3+dfsg.1
[libgit2.git] / src / fetchhead.c
index 0d9ab2c2573ba1fb5b4d8cb843e804be91e6939c..6511124efce4ef174561a39094d565c3861a4c42 100644 (file)
@@ -5,15 +5,16 @@
  * a Linking Exception. For full terms see the included COPYING file.
  */
 
+#include "fetchhead.h"
+
 #include "git2/types.h"
 #include "git2/oid.h"
 
-#include "fetchhead.h"
-#include "common.h"
-#include "buffer.h"
-#include "fileops.h"
+#include "str.h"
+#include "futils.h"
 #include "filebuf.h"
 #include "refs.h"
+#include "net.h"
 #include "repository.h"
 
 int git_fetchhead_ref_cmp(const void *a, const void *b)
@@ -36,6 +37,33 @@ int git_fetchhead_ref_cmp(const void *a, const void *b)
        return 0;
 }
 
+static char *sanitized_remote_url(const char *remote_url)
+{
+       git_net_url url = GIT_NET_URL_INIT;
+       char *sanitized = NULL;
+       int error;
+
+       if (git_net_url_parse(&url, remote_url) == 0) {
+               git_str buf = GIT_STR_INIT;
+
+               git__free(url.username);
+               git__free(url.password);
+               url.username = url.password = NULL;
+
+               if ((error = git_net_url_fmt(&buf, &url)) < 0)
+                       goto fallback;
+
+               sanitized = git_str_detach(&buf);
+       }
+
+fallback:
+       if (!sanitized)
+               sanitized = git__strdup(remote_url);
+
+       git_net_url_dispose(&url);
+       return sanitized;
+}
+
 int git_fetchhead_ref_create(
        git_fetchhead_ref **out,
        git_oid *oid,
@@ -45,23 +73,28 @@ int git_fetchhead_ref_create(
 {
        git_fetchhead_ref *fetchhead_ref;
 
-       assert(out && oid);
+       GIT_ASSERT_ARG(out);
+       GIT_ASSERT_ARG(oid);
 
        *out = NULL;
 
        fetchhead_ref = git__malloc(sizeof(git_fetchhead_ref));
-       GITERR_CHECK_ALLOC(fetchhead_ref);
+       GIT_ERROR_CHECK_ALLOC(fetchhead_ref);
 
        memset(fetchhead_ref, 0x0, sizeof(git_fetchhead_ref));
 
        git_oid_cpy(&fetchhead_ref->oid, oid);
        fetchhead_ref->is_merge = is_merge;
 
-       if (ref_name)
+       if (ref_name) {
                fetchhead_ref->ref_name = git__strdup(ref_name);
+               GIT_ERROR_CHECK_ALLOC(fetchhead_ref->ref_name);
+       }
 
-       if (remote_url)
-               fetchhead_ref->remote_url = git__strdup(remote_url);
+       if (remote_url) {
+               fetchhead_ref->remote_url = sanitized_remote_url(remote_url);
+               GIT_ERROR_CHECK_ALLOC(fetchhead_ref->remote_url);
+       }
 
        *out = fetchhead_ref;
 
@@ -76,7 +109,8 @@ static int fetchhead_ref_write(
        const char *type, *name;
        int head = 0;
 
-       assert(file && fetchhead_ref);
+       GIT_ASSERT_ARG(file);
+       GIT_ASSERT_ARG(fetchhead_ref);
 
        git_oid_fmt(oid, &fetchhead_ref->oid);
        oid[GIT_OID_HEXSZ] = '\0';
@@ -109,21 +143,22 @@ static int fetchhead_ref_write(
 int git_fetchhead_write(git_repository *repo, git_vector *fetchhead_refs)
 {
        git_filebuf file = GIT_FILEBUF_INIT;
-       git_buf path = GIT_BUF_INIT;
+       git_str path = GIT_STR_INIT;
        unsigned int i;
        git_fetchhead_ref *fetchhead_ref;
 
-       assert(repo && fetchhead_refs);
+       GIT_ASSERT_ARG(repo);
+       GIT_ASSERT_ARG(fetchhead_refs);
 
-       if (git_buf_joinpath(&path, repo->path_repository, GIT_FETCH_HEAD_FILE) < 0)
+       if (git_str_joinpath(&path, repo->gitdir, GIT_FETCH_HEAD_FILE) < 0)
                return -1;
 
-       if (git_filebuf_open(&file, path.ptr, GIT_FILEBUF_FORCE, GIT_REFS_FILE_MODE) < 0) {
-               git_buf_free(&path);
+       if (git_filebuf_open(&file, path.ptr, GIT_FILEBUF_APPEND, GIT_REFS_FILE_MODE) < 0) {
+               git_str_dispose(&path);
                return -1;
        }
 
-       git_buf_free(&path);
+       git_str_dispose(&path);
 
        git_vector_sort(fetchhead_refs);
 
@@ -136,7 +171,7 @@ int git_fetchhead_write(git_repository *repo, git_vector *fetchhead_refs)
 static int fetchhead_ref_parse(
        git_oid *oid,
        unsigned int *is_merge,
-       git_buf *ref_name,
+       git_str *ref_name,
        const char **remote_url,
        char *line,
        size_t line_num)
@@ -148,7 +183,7 @@ static int fetchhead_ref_parse(
        *remote_url = NULL;
 
        if (!*line) {
-               giterr_set(GITERR_FETCHHEAD,
+               git_error_set(GIT_ERROR_FETCHHEAD,
                        "empty line in FETCH_HEAD line %"PRIuZ, line_num);
                return -1;
        }
@@ -162,16 +197,16 @@ static int fetchhead_ref_parse(
        }
 
        if (strlen(oid_str) != GIT_OID_HEXSZ) {
-               giterr_set(GITERR_FETCHHEAD,
+               git_error_set(GIT_ERROR_FETCHHEAD,
                        "invalid object ID in FETCH_HEAD line %"PRIuZ, line_num);
                return -1;
        }
 
        if (git_oid_fromstr(oid, oid_str) < 0) {
-               const git_error *oid_err = giterr_last();
+               const git_error *oid_err = git_error_last();
                const char *err_msg = oid_err ? oid_err->message : "invalid object ID";
 
-               giterr_set(GITERR_FETCHHEAD, "%s in FETCH_HEAD line %"PRIuZ,
+               git_error_set(GIT_ERROR_FETCHHEAD, "%s in FETCH_HEAD line %"PRIuZ,
                        err_msg, line_num);
                return -1;
        }
@@ -179,7 +214,7 @@ static int fetchhead_ref_parse(
        /* Parse new data from newer git clients */
        if (*line) {
                if ((is_merge_str = git__strsep(&line, "\t")) == NULL) {
-                       giterr_set(GITERR_FETCHHEAD,
+                       git_error_set(GIT_ERROR_FETCHHEAD,
                                "invalid description data in FETCH_HEAD line %"PRIuZ, line_num);
                        return -1;
                }
@@ -189,13 +224,13 @@ static int fetchhead_ref_parse(
                else if (strcmp(is_merge_str, "not-for-merge") == 0)
                        *is_merge = 0;
                else {
-                       giterr_set(GITERR_FETCHHEAD,
+                       git_error_set(GIT_ERROR_FETCHHEAD,
                                "invalid for-merge entry in FETCH_HEAD line %"PRIuZ, line_num);
                        return -1;
                }
 
                if ((desc = line) == NULL) {
-                       giterr_set(GITERR_FETCHHEAD,
+                       git_error_set(GIT_ERROR_FETCHHEAD,
                                "invalid description in FETCH_HEAD line %"PRIuZ, line_num);
                        return -1;
                }
@@ -212,7 +247,7 @@ static int fetchhead_ref_parse(
                if (name) {
                        if ((desc = strstr(name, "' ")) == NULL ||
                                git__prefixcmp(desc, "' of ") != 0) {
-                               giterr_set(GITERR_FETCHHEAD,
+                               git_error_set(GIT_ERROR_FETCHHEAD,
                                        "invalid description in FETCH_HEAD line %"PRIuZ, line_num);
                                return -1;
                        }
@@ -224,12 +259,12 @@ static int fetchhead_ref_parse(
                *remote_url = desc;
        }
 
-       git_buf_clear(ref_name);
+       git_str_clear(ref_name);
 
        if (type)
-               git_buf_join(ref_name, '/', type, name);
+               git_str_join(ref_name, '/', type, name);
        else if(name)
-               git_buf_puts(ref_name, name);
+               git_str_puts(ref_name, name);
 
        return error;
 }
@@ -238,7 +273,7 @@ int git_repository_fetchhead_foreach(git_repository *repo,
        git_repository_fetchhead_foreach_cb cb,
        void *payload)
 {
-       git_buf path = GIT_BUF_INIT, file = GIT_BUF_INIT, name = GIT_BUF_INIT;
+       git_str path = GIT_STR_INIT, file = GIT_STR_INIT, name = GIT_STR_INIT;
        const char *ref_name;
        git_oid oid;
        const char *remote_url;
@@ -247,12 +282,13 @@ int git_repository_fetchhead_foreach(git_repository *repo,
        size_t line_num = 0;
        int error = 0;
 
-       assert(repo && cb);
+       GIT_ASSERT_ARG(repo);
+       GIT_ASSERT_ARG(cb);
 
-       if (git_buf_joinpath(&path, repo->path_repository, GIT_FETCH_HEAD_FILE) < 0)
+       if (git_str_joinpath(&path, repo->gitdir, GIT_FETCH_HEAD_FILE) < 0)
                return -1;
 
-       if ((error = git_futils_readbuffer(&file, git_buf_cstr(&path))) < 0)
+       if ((error = git_futils_readbuffer(&file, git_str_cstr(&path))) < 0)
                goto done;
 
        buffer = file.ptr;
@@ -264,28 +300,28 @@ int git_repository_fetchhead_foreach(git_repository *repo,
                                &oid, &is_merge, &name, &remote_url, line, line_num)) < 0)
                        goto done;
 
-               if (git_buf_len(&name) > 0)
-                       ref_name = git_buf_cstr(&name);
+               if (git_str_len(&name) > 0)
+                       ref_name = git_str_cstr(&name);
                else
                        ref_name = NULL;
 
                error = cb(ref_name, remote_url, &oid, is_merge, payload);
                if (error) {
-                       giterr_set_after_callback(error);
+                       git_error_set_after_callback(error);
                        goto done;
                }
        }
 
        if (*buffer) {
-               giterr_set(GITERR_FETCHHEAD, "no EOL at line %"PRIuZ, line_num+1);
+               git_error_set(GIT_ERROR_FETCHHEAD, "no EOL at line %"PRIuZ, line_num+1);
                error = -1;
                goto done;
        }
 
 done:
-       git_buf_free(&file);
-       git_buf_free(&path);
-       git_buf_free(&name);
+       git_str_dispose(&file);
+       git_str_dispose(&path);
+       git_str_dispose(&name);
 
        return error;
 }