]> git.proxmox.com Git - mirror_lxc.git/blobdiff - src/lxc/start.c
lxc-start: exit early and cleanly if we have insufficient privs
[mirror_lxc.git] / src / lxc / start.c
index 5759024082e6ee903d517a4151b29ab38eb34ca0..91ce5fa821771e0a33ceee3337e34ed5306d3c3f 100644 (file)
@@ -21,7 +21,8 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
-#include "../config.h"
+#include "config.h"
+
 #include <stdio.h>
 #undef _GNU_SOURCE
 #include <string.h>
 #include <signal.h>
 #include <fcntl.h>
 #include <termios.h>
-#include <namespace.h>
 #include <sys/param.h>
 #include <sys/file.h>
 #include <sys/mount.h>
+#include <sys/stat.h>
 #include <sys/types.h>
 #include <sys/prctl.h>
 #include <sys/types.h>
 #include <sys/un.h>
 #include <sys/poll.h>
 
-#include <lxc/lxc.h>
-#include <lxc/confile.h>
-
-#ifdef HAVE_SYS_SIGNALFD_H 
+#ifdef HAVE_SYS_SIGNALFD_H
 #  include <sys/signalfd.h>
 #else
+/* assume kernel headers are too old */
+#include <stdint.h>
+struct signalfd_siginfo
+{
+       uint32_t ssi_signo;
+       int32_t ssi_errno;
+       int32_t ssi_code;
+       uint32_t ssi_pid;
+       uint32_t ssi_uid;
+       int32_t ssi_fd;
+       uint32_t ssi_tid;
+       uint32_t ssi_band;
+       uint32_t ssi_overrun;
+       uint32_t ssi_trapno;
+       int32_t ssi_status;
+       int32_t ssi_int;
+       uint64_t ssi_ptr;
+       uint64_t ssi_utime;
+       uint64_t ssi_stime;
+       uint64_t ssi_addr;
+       uint8_t __pad[48];
+};
+
 #  ifndef __NR_signalfd4
 /* assume kernel headers are too old */
 #    if __i386__
@@ -91,31 +112,79 @@ int signalfd(int fd, const sigset_t *mask, int flags)
 #define PR_CAPBSET_DROP 24
 #endif
 
+#include "start.h"
+#include "conf.h"
+#include "log.h"
+#include "cgroup.h"
 #include "error.h"
 #include "af_unix.h"
 #include "mainloop.h"
+#include "utils.h"
+#include "utmp.h"
+#include "monitor.h"
 #include "commands.h"
-
-#include <lxc/lxc.h>
-#include <lxc/log.h>
+#include "console.h"
+#include "sync.h"
+#include "namespace.h"
 
 lxc_log_define(lxc_start, lxc);
 
-LXC_TTY_HANDLER(SIGINT);
-LXC_TTY_HANDLER(SIGQUIT);
+static int match_fd(int fd)
+{
+       return (fd == 0 || fd == 1 || fd == 2);
+}
 
-static int setup_sigchld_fd(sigset_t *oldmask)
+int lxc_check_inherited(int fd_to_ignore)
 {
-       sigset_t mask;
-       int fd;
+       struct dirent dirent, *direntp;
+       int fd, fddir;
+       DIR *dir;
 
-       if (sigprocmask(SIG_BLOCK, NULL, &mask)) {
-               SYSERROR("failed to get mask signal");
+       dir = opendir("/proc/self/fd");
+       if (!dir) {
+               WARN("failed to open directory: %m");
                return -1;
        }
 
-       if (sigaddset(&mask, SIGCHLD) || sigprocmask(SIG_BLOCK, &mask, oldmask)) {
-               SYSERROR("failed to set mask signal");
+       fddir = dirfd(dir);
+
+       while (!readdir_r(dir, &dirent, &direntp)) {
+               if (!direntp)
+                       break;
+
+               if (!strcmp(direntp->d_name, "."))
+                       continue;
+
+               if (!strcmp(direntp->d_name, ".."))
+                       continue;
+
+               fd = atoi(direntp->d_name);
+
+               if (fd == fddir || fd == lxc_log_fd || fd == fd_to_ignore)
+                       continue;
+
+               if (match_fd(fd))
+                       continue;
+
+               WARN("inherited fd %d", fd);
+       }
+
+       closedir(dir); /* cannot fail */
+       return 0;
+}
+
+static int setup_signal_fd(sigset_t *oldmask)
+{
+       sigset_t mask;
+       int fd;
+
+       /* Block everything except serious error signals */
+       if (sigfillset(&mask) ||
+           sigdelset(&mask, SIGILL) ||
+           sigdelset(&mask, SIGSEGV) ||
+           sigdelset(&mask, SIGBUS) ||
+           sigprocmask(SIG_BLOCK, &mask, oldmask)) {
+               SYSERROR("failed to set signal mask");
                return -1;
        }
 
@@ -136,15 +205,72 @@ static int setup_sigchld_fd(sigset_t *oldmask)
        return fd;
 }
 
-static int sigchld_handler(int fd, void *data, 
+static int signal_handler(int fd, void *data,
                           struct lxc_epoll_descr *descr)
 {
-       DEBUG("child exited");
+       struct signalfd_siginfo siginfo;
+       int ret;
+       pid_t *pid = data;
+
+       ret = read(fd, &siginfo, sizeof(siginfo));
+       if (ret < 0) {
+               ERROR("failed to read signal info");
+               return -1;
+       }
+
+       if (ret != sizeof(siginfo)) {
+               ERROR("unexpected siginfo size");
+               return -1;
+       }
+
+       if (siginfo.ssi_signo != SIGCHLD) {
+               kill(*pid, siginfo.ssi_signo);
+               INFO("forwarded signal %d to pid %d", siginfo.ssi_signo, *pid);
+               return 0;
+       }
+
+       if (siginfo.ssi_code == CLD_STOPPED ||
+           siginfo.ssi_code == CLD_CONTINUED) {
+               INFO("container init process was stopped/continued");
+               return 0;
+       }
+
+       /* more robustness, protect ourself from a SIGCHLD sent
+        * by a process different from the container init
+        */
+       if (siginfo.ssi_pid != *pid) {
+               WARN("invalid pid for SIGCHLD");
+               return 0;
+       }
 
+       DEBUG("container init process exited");
        return 1;
 }
 
-static int set_state(const char *name, struct lxc_handler *handler, lxc_state_t state)
+int lxc_pid_callback(int fd, struct lxc_request *request,
+                    struct lxc_handler *handler)
+{
+       struct lxc_answer answer;
+       int ret;
+
+       answer.pid = handler->pid;
+       answer.ret = 0;
+
+       ret = send(fd, &answer, sizeof(answer), 0);
+       if (ret < 0) {
+               WARN("failed to send answer to the peer");
+               return -1;
+       }
+
+       if (ret != sizeof(answer)) {
+               ERROR("partial answer sent");
+               return -1;
+       }
+
+       return 0;
+}
+
+int lxc_set_state(const char *name, struct lxc_handler *handler, lxc_state_t state)
 {
        handler->state = state;
        lxc_monitor_send_state(name, state);
@@ -155,7 +281,6 @@ int lxc_poll(const char *name, struct lxc_handler *handler)
 {
        int sigfd = handler->sigfd;
        int pid = handler->pid;
-       int ret = -1;
        struct lxc_epoll_descr descr;
 
        if (lxc_mainloop_open(&descr)) {
@@ -163,151 +288,102 @@ int lxc_poll(const char *name, struct lxc_handler *handler)
                goto out_sigfd;
        }
 
-       if (lxc_mainloop_add_handler(&descr, sigfd, sigchld_handler, &pid)) {
+       if (lxc_mainloop_add_handler(&descr, sigfd, signal_handler, &pid)) {
                ERROR("failed to add handler for the signal");
                goto out_mainloop_open;
        }
 
-       if (lxc_command_mainloop_add(name, &descr, handler))
+       if (lxc_console_mainloop_add(&descr, handler)) {
+               ERROR("failed to add console handler to mainloop");
+               goto out_mainloop_open;
+       }
+
+       if (lxc_command_mainloop_add(name, &descr, handler)) {
+               ERROR("failed to add command handler to mainloop");
                goto out_mainloop_open;
+       }
 
-       ret = lxc_mainloop(&descr);
+       if (handler->conf->need_utmp_watch) {
+               if (lxc_utmp_mainloop_add(&descr, handler)) {
+                       ERROR("failed to add utmp handler to mainloop");
+                       goto out_mainloop_open;
+               }
+       }
 
-out:
-       return ret;
+       return lxc_mainloop(&descr);
 
 out_mainloop_open:
        lxc_mainloop_close(&descr);
 out_sigfd:
        close(sigfd);
-       goto out;
+       return -1;
 }
 
-static void remove_init_pid(const char *name, pid_t pid)
-{
-       char init[MAXPATHLEN];
-
-       snprintf(init, MAXPATHLEN, LXCPATH "/%s/init", name);
-       unlink(init);
-}
+extern int lxc_caps_check(void);
 
-static int fdname(int fd, char *name, size_t size)
+struct lxc_handler *lxc_init(const char *name, struct lxc_conf *conf)
 {
-       char path[MAXPATHLEN];
-       ssize_t len;
-
-       snprintf(path, MAXPATHLEN, "/proc/self/fd/%d", fd);
-
-       len = readlink(path, name, size);
-       if (len >  0)
-               path[len] = '\0';
-
-       return (len <= 0) ? -1 : 0;
-}
-
-static int console_init(char *console, size_t size)
-{
-       struct stat stat;
-       int i;
-
-       for (i = 0; i < 3; i++) {
-               if (!isatty(i))
-                       continue;
-
-               if (ttyname_r(i, console, size)) {
-                       SYSERROR("failed to retrieve tty name");
-                       return -1;
-               }
-
-               return 0;
-       }
+       struct lxc_handler *handler;
 
-       if (!fstat(0, &stat)) {
-               if (S_ISREG(stat.st_mode) || S_ISCHR(stat.st_mode) ||
-                   S_ISFIFO(stat.st_mode) || S_ISLNK(stat.st_mode))
-                       return fdname(0, console, size);
+       if (!lxc_caps_check()) {
+               ERROR("Not running with sufficient privilege");
+               return NULL;
        }
 
-       console[0] = '\0';
-
-       DEBUG("console initialized");
-
-       return 0;
-}
-
-struct lxc_handler *lxc_init(const char *name)
-{
-       struct lxc_handler *handler;
-       char path[MAXPATHLEN];
-
        handler = malloc(sizeof(*handler));
        if (!handler)
                return NULL;
 
        memset(handler, 0, sizeof(*handler));
 
-       handler->lock = lxc_get_lock(name);
-       if (handler->lock < 0)
+       handler->conf = conf;
+
+       handler->name = strdup(name);
+       if (!handler->name) {
+               ERROR("failed to allocate memory");
                goto out_free;
+       }
 
        /* Begin the set the state to STARTING*/
-       if (set_state(name, handler, STARTING)) {
+       if (lxc_set_state(name, handler, STARTING)) {
                ERROR("failed to set state '%s'", lxc_state2str(STARTING));
-               goto out_put_lock;
+               goto out_free_name;
        }
 
-       if (lxc_conf_init(&handler->conf)) {
-               ERROR("failed to initialize the configuration");
-               goto out_aborting;
-       }
-
-       snprintf(path, sizeof(path), LXCPATH "/%s/config", name);
-
-       if (!access(path, F_OK) && lxc_config_read(path, &handler->conf)) {
-               ERROR("failed to read the configuration file");
-               goto out_aborting;
-       }
-
-       if (console_init(handler->conf.console,
-                        sizeof(handler->conf.console))) {
-               ERROR("failed to initialize the console");
+       if (lxc_create_tty(name, conf)) {
+               ERROR("failed to create the ttys");
                goto out_aborting;
        }
 
-       if (lxc_create_tty(name, &handler->conf)) {
-               ERROR("failed to create the ttys");
-               goto out_aborting;
+       if (lxc_create_console(conf)) {
+               ERROR("failed to create console");
+               goto out_delete_tty;
        }
 
        /* the signal fd has to be created before forking otherwise
         * if the child process exits before we setup the signal fd,
         * the event will be lost and the command will be stuck */
-       handler->sigfd = setup_sigchld_fd(&handler->oldmask);
+       handler->sigfd = setup_signal_fd(&handler->oldmask);
        if (handler->sigfd < 0) {
                ERROR("failed to set sigchild fd handler");
-               goto out_delete_tty;
+               goto out_delete_console;
        }
 
-       /* Avoid signals from terminal */
-       LXC_TTY_ADD_HANDLER(SIGINT);
-       LXC_TTY_ADD_HANDLER(SIGQUIT);
-
-out:
-       if (handler)
-               INFO("'%s' is initialized", name);
-
+       INFO("'%s' is initialized", name);
        return handler;
 
+out_delete_console:
+       lxc_delete_console(&conf->console);
 out_delete_tty:
-       lxc_delete_tty(&handler->conf.tty_info);
+       lxc_delete_tty(&conf->tty_info);
 out_aborting:
-       set_state(name, handler, ABORTING);
-out_put_lock:
-       lxc_put_lock(handler->lock);
+       lxc_set_state(name, handler, ABORTING);
+out_free_name:
+       free(handler->name);
+       handler->name = NULL;
 out_free:
        free(handler);
-       handler = NULL;
-       goto out;
+       return NULL;
 }
 
 void lxc_fini(const char *name, struct lxc_handler *handler)
@@ -315,208 +391,209 @@ void lxc_fini(const char *name, struct lxc_handler *handler)
        /* The STOPPING state is there for future cleanup code
         * which can take awhile
         */
-       set_state(name, handler, STOPPING);
-       set_state(name, handler, STOPPED);
-       lxc_unlink_nsgroup(name);
+       lxc_set_state(name, handler, STOPPING);
+       lxc_set_state(name, handler, STOPPED);
 
-       if (handler) {
-               remove_init_pid(name, handler->pid);
-               lxc_delete_tty(&handler->conf.tty_info);
-               lxc_put_lock(handler->lock);
-               free(handler);
-       }
+       /* reset mask set by setup_signal_fd */
+       if (sigprocmask(SIG_SETMASK, &handler->oldmask, NULL))
+               WARN("failed to restore sigprocmask");
 
-       LXC_TTY_DEL_HANDLER(SIGQUIT);
-       LXC_TTY_DEL_HANDLER(SIGINT);
+       lxc_delete_console(&handler->conf->console);
+       lxc_delete_tty(&handler->conf->tty_info);
+       free(handler->name);
+       free(handler);
 }
 
 void lxc_abort(const char *name, struct lxc_handler *handler)
 {
-       set_state(name, handler, ABORTING);
-       kill(handler->pid, SIGKILL);
+       lxc_set_state(name, handler, ABORTING);
+       if (handler->pid > 0)
+               kill(handler->pid, SIGKILL);
 }
 
-struct start_arg {
-       const char *name;
-       char *const *argv;
-       struct lxc_handler *handler;
-       int *sv;
-};
+#include <sys/reboot.h>
+#include <linux/reboot.h>
+
+static int must_drop_cap_sys_boot(void)
+{
+       FILE *f = fopen("/proc/sys/kernel/ctrl-alt-del", "r");
+       int ret;
+       int v;
+
+       if (!f)
+               return 1;
+
+       ret = fscanf(f, "%d", &v);
+       fclose(f);
+       if (ret != 1)
+               return 1;
+       ret = reboot(v ? LINUX_REBOOT_CMD_CAD_ON : LINUX_REBOOT_CMD_CAD_OFF);
+       if (ret != -1)
+               return 1;
+       return 0;
+}
 
-static int do_start(void *arg)
+static int do_start(void *data)
 {
-       struct start_arg *start_arg = arg;
-       struct lxc_handler *handler = start_arg->handler;
-       const char *name = start_arg->name;
-       char *const *argv = start_arg->argv;
-       int *sv = start_arg->sv;
-       int err = -1, sync;
+       struct lxc_handler *handler = data;
 
        if (sigprocmask(SIG_SETMASK, &handler->oldmask, NULL)) {
                SYSERROR("failed to set sigprocmask");
-               goto out_child;
+               return -1;
        }
 
-       close(sv[1]);
-
-       /* Be sure we don't inherit this after the exec */
-       fcntl(sv[0], F_SETFD, FD_CLOEXEC);
-
-       /* Tell our father he can begin to configure the container */
-       if (write(sv[0], &sync, sizeof(sync)) < 0) {
-               SYSERROR("failed to write socket");
-               goto out_child;
+        /* This prctl must be before the synchro, so if the parent
+        * dies before we set the parent death signal, we will detect
+        * its death with the synchro right after, otherwise we have
+        * a window where the parent can exit before we set the pdeath
+        * signal leading to a unsupervized container.
+        */
+       if (prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0)) {
+               SYSERROR("failed to set pdeath signal");
+               return -1;
        }
 
-       /* Wait for the father to finish the configuration */
-       if (read(sv[0], &sync, sizeof(sync)) < 0) {
-               SYSERROR("failed to read socket");
-               goto out_child;
-       }
+       lxc_sync_fini_parent(handler);
+
+       /* Tell the parent task it can begin to configure the
+        * container and wait for it to finish
+        */
+       if (lxc_sync_barrier_parent(handler, LXC_SYNC_CONFIGURE))
+               return -1;
 
        /* Setup the container, ip, names, utsname, ... */
-       if (lxc_setup(name, &handler->conf)) {
+       if (lxc_setup(handler->name, handler->conf)) {
                ERROR("failed to setup the container");
                goto out_warn_father;
        }
 
-       if (prctl(PR_CAPBSET_DROP, CAP_SYS_BOOT, 0, 0, 0)) {
-               SYSERROR("failed to remove CAP_SYS_BOOT capability");
-               goto out_child;
-       }
-
-       if (prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0)) {
-               SYSERROR("failed to set pdeath signal");
-               goto out_child;
-       }
+       if (must_drop_cap_sys_boot()) {
+               if (prctl(PR_CAPBSET_DROP, CAP_SYS_BOOT, 0, 0, 0)) {
+                       SYSERROR("failed to remove CAP_SYS_BOOT capability");
+                       return -1;
+               }
+               handler->conf->need_utmp_watch = 1;
+       } else
+               handler->conf->need_utmp_watch = 0;
 
-       NOTICE("exec'ing '%s'", argv[0]);
+       close(handler->sigfd);
 
-       execvp(argv[0], argv);
-       SYSERROR("failed to exec %s", argv[0]);
+       /* after this call, we are in error because this
+        * ops should not return as it execs */
+       if (handler->ops->start(handler, handler->data))
+               return -1;
 
 out_warn_father:
-       /* If the exec fails, tell that to our father */
-       if (write(sv[0], &err, sizeof(err)) < 0)
-               SYSERROR("failed to write the socket");
-out_child:
+       lxc_sync_wake_parent(handler, LXC_SYNC_POST_CONFIGURE);
        return -1;
 }
 
-int lxc_spawn(const char *name, struct lxc_handler *handler, char *const argv[])
+int lxc_spawn(struct lxc_handler *handler)
 {
-       int sv[2];
        int clone_flags;
-       int err = -1, sync;
+       int failed_before_rename = 0;
+       const char *name = handler->name;
 
-       struct start_arg start_arg = {
-               .name = name,
-               .argv = argv,
-               .handler = handler,
-               .sv = sv,
-       };
-
-       /* Synchro socketpair */
-       if (socketpair(AF_LOCAL, SOCK_STREAM, 0, sv)) {
-               SYSERROR("failed to create communication socketpair");
-               goto out;
-       }
+       if (lxc_sync_init(handler))
+               return -1;
 
        clone_flags = CLONE_NEWUTS|CLONE_NEWPID|CLONE_NEWIPC|CLONE_NEWNS;
-       if (!lxc_list_empty(&handler->conf.network)) {
+       if (!lxc_list_empty(&handler->conf->network)) {
 
                clone_flags |= CLONE_NEWNET;
 
+               /* Find gateway addresses from the link device, which is
+                * no longer accessible inside the container. Do this
+                * before creating network interfaces, since goto
+                * out_delete_net does not work before lxc_clone. */
+               if (lxc_find_gateway_addresses(handler)) {
+                       ERROR("failed to find gateway addresses");
+                       lxc_sync_fini(handler);
+                       return -1;
+               }
+
                /* that should be done before the clone because we will
                 * fill the netdev index and use them in the child
                 */
-               if (lxc_create_network(&handler->conf.network)) {
+               if (lxc_create_network(handler)) {
                        ERROR("failed to create the network");
-                       goto out_close;
+                       lxc_sync_fini(handler);
+                       return -1;
                }
        }
 
        /* Create a process in a new set of namespaces */
-       handler->pid = lxc_clone(do_start, &start_arg, clone_flags);
+       handler->pid = lxc_clone(do_start, handler, clone_flags);
        if (handler->pid < 0) {
                SYSERROR("failed to fork into a new namespace");
-               goto out_close;
+               goto out_delete_net;
        }
 
-       close(sv[0]);
-       
-       /* Wait for the child to be ready */
-       if (read(sv[1], &sync, sizeof(sync)) < 0) {
-               SYSERROR("failed to read the socket");
-               goto out_abort;
-       }
+       lxc_sync_fini_child(handler);
 
-       if (lxc_rename_nsgroup(name, handler))
-               goto out_abort;
+       if (lxc_sync_wait_child(handler, LXC_SYNC_CONFIGURE))
+               failed_before_rename = 1;
+
+       if (lxc_cgroup_create(name, handler->pid))
+               goto out_delete_net;
+
+       if (failed_before_rename)
+               goto out_delete_net;
 
        /* Create the network configuration */
        if (clone_flags & CLONE_NEWNET) {
-               if (lxc_assign_network(&handler->conf.network, handler->pid)) {
+               if (lxc_assign_network(&handler->conf->network, handler->pid)) {
                        ERROR("failed to create the configured network");
-                       goto out_abort;
+                       goto out_delete_net;
                }
        }
 
-       /* Tell the child to continue its initialization */
-       if (write(sv[1], &sync, sizeof(sync)) < 0) {
-               SYSERROR("failed to write the socket");
-               goto out_abort;
-       }
+       /* Tell the child to continue its initialization and wait for
+        * it to exec or return an error
+        */
+       if (lxc_sync_barrier_child(handler, LXC_SYNC_POST_CONFIGURE))
+               return -1;
 
-       /* Wait for the child to exec or returning an error */
-       if (read(sv[1], &sync, sizeof(sync)) < 0) {
-               ERROR("failed to read the socket");
+       if (handler->ops->post_start(handler, handler->data))
                goto out_abort;
-       }
 
-       if (set_state(name, handler, RUNNING)) {
+       if (lxc_set_state(name, handler, RUNNING)) {
                ERROR("failed to set state to %s",
                              lxc_state2str(RUNNING));
                goto out_abort;
        }
 
-       err = 0;
-
-       NOTICE("'%s' started with pid '%d'", argv[0], handler->pid);
-
-out_close:
-       close(sv[0]);
-       close(sv[1]);
-out:
-       return err;
+       lxc_sync_fini(handler);
+       return 0;
 
+out_delete_net:
+       if (clone_flags & CLONE_NEWNET)
+               lxc_delete_network(&handler->conf->network);
 out_abort:
        lxc_abort(name, handler);
-       goto out_close;
+       lxc_sync_fini(handler);
+       return -1;
 }
 
-int lxc_start(const char *name, char *const argv[])
+int __lxc_start(const char *name, struct lxc_conf *conf,
+               struct lxc_operations* ops, void *data)
 {
        struct lxc_handler *handler;
        int err = -1;
        int status;
 
-       handler = lxc_init(name);
+       handler = lxc_init(name, conf);
        if (!handler) {
                ERROR("failed to initialize the container");
                return -1;
        }
+       handler->ops = ops;
+       handler->data = data;
 
-       err = lxc_spawn(name, handler, argv);
+       err = lxc_spawn(handler);
        if (err) {
-               ERROR("failed to spawn '%s'", argv[0]);
-               goto out;
-       }
-
-       err = lxc_close_all_inherited_fd();
-       if (err) {
-               ERROR("unable to close inherited fds");
-               goto out_abort;
+               ERROR("failed to spawn '%s'", name);
+               goto out_fini;
        }
 
        err = lxc_poll(name, handler);
@@ -528,12 +605,72 @@ int lxc_start(const char *name, char *const argv[])
        while (waitpid(handler->pid, &status, 0) < 0 && errno == EINTR)
                continue;
 
+        if (!WIFSIGNALED(status)) {
+                printf("child process exited but was not signaled\n");
+                return -1;
+        }
+
+       switch(WTERMSIG(status)) {
+       case SIGINT: /* halt */
+               DEBUG("Container halting");
+               break;
+       case SIGHUP: /* reboot */
+               DEBUG("Container rebooting");
+               handler->conf->reboot = 1;
+               break;
+       default:
+               DEBUG("unknown exit status for init: %d\n", WTERMSIG(status));
+               break;
+        }
+
        err =  lxc_error_set_and_log(handler->pid, status);
-out:
+out_fini:
+       lxc_cgroup_destroy(name);
        lxc_fini(name, handler);
        return err;
 
 out_abort:
        lxc_abort(name, handler);
-       goto out;
+       goto out_fini;
+}
+
+struct start_args {
+       char *const *argv;
+};
+
+static int start(struct lxc_handler *handler, void* data)
+{
+       struct start_args *arg = data;
+
+       NOTICE("exec'ing '%s'", arg->argv[0]);
+
+       execvp(arg->argv[0], arg->argv);
+       SYSERROR("failed to exec %s", arg->argv[0]);
+       return 0;
+}
+
+static int post_start(struct lxc_handler *handler, void* data)
+{
+       struct start_args *arg = data;
+
+       NOTICE("'%s' started with pid '%d'", arg->argv[0], handler->pid);
+       return 0;
+}
+
+static struct lxc_operations start_ops = {
+       .start = start,
+       .post_start = post_start
+};
+
+int lxc_start(const char *name, char *const argv[], struct lxc_conf *conf)
+{
+       struct start_args start_arg = {
+               .argv = argv,
+       };
+
+       if (lxc_check_inherited(-1))
+               return -1;
+
+       conf->need_utmp_watch = 1;
+       return __lxc_start(name, conf, &start_ops, &start_arg);
 }