]> git.proxmox.com Git - libgit2.git/blobdiff - src/refspec.c
New upstream version 1.3.0+dfsg.1
[libgit2.git] / src / refspec.c
index fa60aa7aa88b0c102d8df6a5c7eb737b08309eb7..c72721a437300f64709e102a374730ba407ddf9f 100644 (file)
@@ -5,25 +5,27 @@
  * a Linking Exception. For full terms see the included COPYING file.
  */
 
+#include "refspec.h"
+
 #include "git2/errors.h"
 
-#include "common.h"
-#include "refspec.h"
-#include "util.h"
-#include "posix.h"
 #include "refs.h"
+#include "util.h"
 #include "vector.h"
+#include "wildmatch.h"
 
 int git_refspec__parse(git_refspec *refspec, const char *input, bool is_fetch)
 {
-       // Ported from https://github.com/git/git/blob/f06d47e7e0d9db709ee204ed13a8a7486149f494/remote.c#L518-636
+       /* Ported from https://github.com/git/git/blob/f06d47e7e0d9db709ee204ed13a8a7486149f494/remote.c#L518-636 */
 
        size_t llen;
        int is_glob = 0;
        const char *lhs, *rhs;
-       int flags;
+       int valid = 0;
+       unsigned int flags;
 
-       assert(refspec && input);
+       GIT_ASSERT_ARG(refspec);
+       GIT_ASSERT_ARG(input);
 
        memset(refspec, 0x0, sizeof(git_refspec));
        refspec->push = !is_fetch;
@@ -42,13 +44,21 @@ int git_refspec__parse(git_refspec *refspec, const char *input, bool is_fetch)
         */
        if (!is_fetch && rhs == lhs && rhs[1] == '\0') {
                refspec->matching = 1;
+               refspec->string = git__strdup(input);
+               GIT_ERROR_CHECK_ALLOC(refspec->string);
+               refspec->src = git__strdup("");
+               GIT_ERROR_CHECK_ALLOC(refspec->src);
+               refspec->dst = git__strdup("");
+               GIT_ERROR_CHECK_ALLOC(refspec->dst);
                return 0;
        }
 
        if (rhs) {
                size_t rlen = strlen(++rhs);
-               is_glob = (1 <= rlen && strchr(rhs, '*'));
-               refspec->dst = git__strndup(rhs, rlen);
+               if (rlen || !is_fetch) {
+                       is_glob = (1 <= rlen && strchr(rhs, '*'));
+                       refspec->dst = git__strndup(rhs, rlen);
+               }
        }
 
        llen = (rhs ? (size_t)(rhs - lhs - 1) : strlen(lhs));
@@ -61,76 +71,102 @@ int git_refspec__parse(git_refspec *refspec, const char *input, bool is_fetch)
 
        refspec->pattern = is_glob;
        refspec->src = git__strndup(lhs, llen);
-       flags = GIT_REF_FORMAT_ALLOW_ONELEVEL | GIT_REF_FORMAT_REFSPEC_SHORTHAND
-               | (is_glob ? GIT_REF_FORMAT_REFSPEC_PATTERN : 0);
+       flags = GIT_REFERENCE_FORMAT_ALLOW_ONELEVEL |
+               GIT_REFERENCE_FORMAT_REFSPEC_SHORTHAND |
+               (is_glob ? GIT_REFERENCE_FORMAT_REFSPEC_PATTERN : 0);
 
        if (is_fetch) {
                /*
-                       * LHS
-                       * - empty is allowed; it means HEAD.
-                       * - otherwise it must be a valid looking ref.
-                       */
+                * LHS
+                * - empty is allowed; it means HEAD.
+                * - otherwise it must be a valid looking ref.
+                */
                if (!*refspec->src)
                        ; /* empty is ok */
-               else if (!git_reference__is_valid_name(refspec->src, flags))
+               else if (git_reference__name_is_valid(&valid, refspec->src, flags) < 0)
+                       goto on_error;
+               else if (!valid)
                        goto invalid;
+
                /*
-                       * RHS
-                       * - missing is ok, and is same as empty.
-                       * - empty is ok; it means not to store.
-                       * - otherwise it must be a valid looking ref.
-                       */
+                * RHS
+                * - missing is ok, and is same as empty.
+                * - empty is ok; it means not to store.
+                * - otherwise it must be a valid looking ref.
+                */
                if (!refspec->dst)
                        ; /* ok */
                else if (!*refspec->dst)
                        ; /* ok */
-               else if (!git_reference__is_valid_name(refspec->dst, flags))
+               else if (git_reference__name_is_valid(&valid, refspec->dst, flags) < 0)
+                       goto on_error;
+               else if (!valid)
                        goto invalid;
        } else {
                /*
-                       * LHS
-                       * - empty is allowed; it means delete.
-                       * - when wildcarded, it must be a valid looking ref.
-                       * - otherwise, it must be an extended SHA-1, but
-                       *   there is no existing way to validate this.
-                       */
+                * LHS
+                * - empty is allowed; it means delete.
+                * - when wildcarded, it must be a valid looking ref.
+                * - otherwise, it must be an extended SHA-1, but
+                *   there is no existing way to validate this.
+                */
                if (!*refspec->src)
                        ; /* empty is ok */
                else if (is_glob) {
-                       if (!git_reference__is_valid_name(refspec->src, flags))
+                       if (git_reference__name_is_valid(&valid, refspec->src, flags) < 0)
+                               goto on_error;
+                       else if (!valid)
                                goto invalid;
                }
                else {
                        ; /* anything goes, for now */
                }
+
                /*
-                       * RHS
-                       * - missing is allowed, but LHS then must be a
-                       *   valid looking ref.
-                       * - empty is not allowed.
-                       * - otherwise it must be a valid looking ref.
-                       */
+                * RHS
+                * - missing is allowed, but LHS then must be a
+                *   valid looking ref.
+                * - empty is not allowed.
+                * - otherwise it must be a valid looking ref.
+                */
                if (!refspec->dst) {
-                       if (!git_reference__is_valid_name(refspec->src, flags))
+                       if (git_reference__name_is_valid(&valid, refspec->src, flags) < 0)
+                               goto on_error;
+                       else if (!valid)
                                goto invalid;
                } else if (!*refspec->dst) {
                        goto invalid;
                } else {
-                       if (!git_reference__is_valid_name(refspec->dst, flags))
+                       if (git_reference__name_is_valid(&valid, refspec->dst, flags) < 0)
+                               goto on_error;
+                       else if (!valid)
                                goto invalid;
                }
+
+               /* if the RHS is empty, then it's a copy of the LHS */
+               if (!refspec->dst) {
+                       refspec->dst = git__strdup(refspec->src);
+                       GIT_ERROR_CHECK_ALLOC(refspec->dst);
+               }
        }
 
        refspec->string = git__strdup(input);
-       GITERR_CHECK_ALLOC(refspec->string);
+       GIT_ERROR_CHECK_ALLOC(refspec->string);
 
        return 0;
 
- invalid:
+invalid:
+       git_error_set(GIT_ERROR_INVALID,
+                     "'%s' is not a valid refspec.", input);
+       git_refspec__dispose(refspec);
+       return GIT_EINVALIDSPEC;
+
+on_error:
+       git_refspec__dispose(refspec);
        return -1;
 }
 
-void git_refspec__free(git_refspec *refspec)
+void git_refspec__dispose(git_refspec *refspec)
 {
        if (refspec == NULL)
                return;
@@ -138,6 +174,34 @@ void git_refspec__free(git_refspec *refspec)
        git__free(refspec->src);
        git__free(refspec->dst);
        git__free(refspec->string);
+
+       memset(refspec, 0x0, sizeof(git_refspec));
+}
+
+int git_refspec_parse(git_refspec **out_refspec, const char *input, int is_fetch)
+{
+       git_refspec *refspec;
+       GIT_ASSERT_ARG(out_refspec);
+       GIT_ASSERT_ARG(input);
+
+       *out_refspec = NULL;
+
+       refspec = git__malloc(sizeof(git_refspec));
+       GIT_ERROR_CHECK_ALLOC(refspec);
+
+       if (git_refspec__parse(refspec, input, !!is_fetch) != 0) {
+               git__free(refspec);
+               return -1;
+       }
+
+       *out_refspec = refspec;
+       return 0;
+}
+
+void git_refspec_free(git_refspec *refspec)
+{
+       git_refspec__dispose(refspec);
+       git__free(refspec);
 }
 
 const char *git_refspec_src(const git_refspec *refspec)
@@ -157,7 +221,7 @@ const char *git_refspec_string(const git_refspec *refspec)
 
 int git_refspec_force(const git_refspec *refspec)
 {
-       assert(refspec);
+       GIT_ASSERT_ARG(refspec);
 
        return refspec->force;
 }
@@ -167,7 +231,7 @@ int git_refspec_src_matches(const git_refspec *refspec, const char *refname)
        if (refspec == NULL || refspec->src == NULL)
                return false;
 
-       return (p_fnmatch(refspec->src, refname, 0) == 0);
+       return (wildmatch(refspec->src, refname, 0) == 0);
 }
 
 int git_refspec_dst_matches(const git_refspec *refspec, const char *refname)
@@ -175,45 +239,89 @@ int git_refspec_dst_matches(const git_refspec *refspec, const char *refname)
        if (refspec == NULL || refspec->dst == NULL)
                return false;
 
-       return (p_fnmatch(refspec->dst, refname, 0) == 0);
+       return (wildmatch(refspec->dst, refname, 0) == 0);
 }
 
 static int refspec_transform(
        git_buf *out, const char *from, const char *to, const char *name)
 {
-       size_t to_len   = to   ? strlen(to)   : 0;
-       size_t from_len = from ? strlen(from) : 0;
-       size_t name_len = name ? strlen(name) : 0;
+       const char *from_star, *to_star;
+       size_t replacement_len, star_offset;
+       int error;
 
-       git_buf_sanitize(out);
+       if ((error = git_buf_sanitize(out)) < 0)
+               return error;
 
-       if (git_buf_set(out, to, to_len) < 0)
-               return -1;
+       git_buf_clear(out);
 
-       if (to_len > 0) {
-               /* No '*' at the end of 'to' means that refspec is mapped to one
-                * specific branch, so no actual transformation is needed.
-                */
-               if (out->ptr[to_len - 1] != '*')
-                       return 0;
-               git_buf_shorten(out, 1); /* remove trailing '*' copied from 'to' */
-       }
+       /*
+        * There are two parts to each side of a refspec, the bit
+        * before the star and the bit after it. The star can be in
+        * the middle of the pattern, so we need to look at each bit
+        * individually.
+        */
+       from_star = strchr(from, '*');
+       to_star = strchr(to, '*');
+
+       GIT_ASSERT(from_star && to_star);
 
-       if (from_len > 0) /* ignore trailing '*' from 'from' */
-               from_len--;
-       if (from_len > name_len)
-               from_len = name_len;
+       /* star offset, both in 'from' and in 'name' */
+       star_offset = from_star - from;
 
-       return git_buf_put(out, name + from_len, name_len - from_len);
+       /* the first half is copied over */
+       git_buf_put(out, to, to_star - to);
+
+       /*
+        * Copy over the name, but exclude the trailing part in "from" starting
+        * after the glob
+        */
+       replacement_len = strlen(name + star_offset) - strlen(from_star + 1);
+       git_buf_put(out, name + star_offset, replacement_len);
+
+       return git_buf_puts(out, to_star + 1);
 }
 
 int git_refspec_transform(git_buf *out, const git_refspec *spec, const char *name)
 {
+       int error;
+
+       GIT_ASSERT_ARG(out);
+       GIT_ASSERT_ARG(spec);
+       GIT_ASSERT_ARG(name);
+
+       if ((error = git_buf_sanitize(out)) < 0)
+               return error;
+
+       if (!git_refspec_src_matches(spec, name)) {
+               git_error_set(GIT_ERROR_INVALID, "ref '%s' doesn't match the source", name);
+               return -1;
+       }
+
+       if (!spec->pattern)
+               return git_buf_puts(out, spec->dst ? spec->dst : "");
+
        return refspec_transform(out, spec->src, spec->dst, name);
 }
 
 int git_refspec_rtransform(git_buf *out, const git_refspec *spec, const char *name)
 {
+       int error;
+
+       GIT_ASSERT_ARG(out);
+       GIT_ASSERT_ARG(spec);
+       GIT_ASSERT_ARG(name);
+
+       if ((error = git_buf_sanitize(out)) < 0)
+               return error;
+
+       if (!git_refspec_dst_matches(spec, name)) {
+               git_error_set(GIT_ERROR_INVALID, "ref '%s' doesn't match the destination", name);
+               return -1;
+       }
+
+       if (!spec->pattern)
+               return git_buf_puts(out, spec->src);
+
        return refspec_transform(out, spec->dst, spec->src, name);
 }
 
@@ -231,14 +339,15 @@ int git_refspec__serialize(git_buf *out, const git_refspec *refspec)
 
 int git_refspec_is_wildcard(const git_refspec *spec)
 {
-       assert(spec && spec->src);
+       GIT_ASSERT_ARG(spec);
+       GIT_ASSERT_ARG(spec->src);
 
        return (spec->src[strlen(spec->src) - 1] == '*');
 }
 
 git_direction git_refspec_direction(const git_refspec *spec)
 {
-       assert(spec);
+       GIT_ASSERT_ARG(spec);
 
        return spec->push;
 }
@@ -248,16 +357,21 @@ int git_refspec__dwim_one(git_vector *out, git_refspec *spec, git_vector *refs)
        git_buf buf = GIT_BUF_INIT;
        size_t j, pos;
        git_remote_head key;
+       git_refspec *cur;
 
-       const charformatters[] = {
+       const char *formatters[] = {
                GIT_REFS_DIR "%s",
                GIT_REFS_TAGS_DIR "%s",
                GIT_REFS_HEADS_DIR "%s",
                NULL
        };
 
-       git_refspec *cur = git__calloc(1, sizeof(git_refspec));
-       GITERR_CHECK_ALLOC(cur);
+       GIT_ASSERT_ARG(out);
+       GIT_ASSERT_ARG(spec);
+       GIT_ASSERT_ARG(refs);
+
+       cur = git__calloc(1, sizeof(git_refspec));
+       GIT_ERROR_CHECK_ALLOC(cur);
 
        cur->force = spec->force;
        cur->push = spec->push;
@@ -269,8 +383,8 @@ int git_refspec__dwim_one(git_vector *out, git_refspec *spec, git_vector *refs)
        if (git__prefixcmp(spec->src, GIT_REFS_DIR)) {
                for (j = 0; formatters[j]; j++) {
                        git_buf_clear(&buf);
-                       if (git_buf_printf(&buf, formatters[j], spec->src) < 0)
-                               return -1;
+                       git_buf_printf(&buf, formatters[j], spec->src);
+                       GIT_ERROR_CHECK_ALLOC_BUF(&buf);
 
                        key.name = (char *) git_buf_cstr(&buf);
                        if (!git_vector_search(&pos, refs, &key)) {
@@ -283,7 +397,7 @@ int git_refspec__dwim_one(git_vector *out, git_refspec *spec, git_vector *refs)
        /* No shorthands found, copy over the name */
        if (cur->src == NULL && spec->src != NULL) {
                cur->src = git__strdup(spec->src);
-               GITERR_CHECK_ALLOC(cur->src);
+               GIT_ERROR_CHECK_ALLOC(cur->src);
        }
 
        if (spec->dst && git__prefixcmp(spec->dst, GIT_REFS_DIR)) {
@@ -294,17 +408,17 @@ int git_refspec__dwim_one(git_vector *out, git_refspec *spec, git_vector *refs)
                        git_buf_puts(&buf, GIT_REFS_HEADS_DIR);
                }
 
-               if (git_buf_puts(&buf, spec->dst) < 0)
-                       return -1;
+               git_buf_puts(&buf, spec->dst);
+               GIT_ERROR_CHECK_ALLOC_BUF(&buf);
 
                cur->dst = git_buf_detach(&buf);
        }
 
-       git_buf_free(&buf);
+       git_buf_dispose(&buf);
 
        if (cur->dst == NULL && spec->dst != NULL) {
                cur->dst = git__strdup(spec->dst);
-               GITERR_CHECK_ALLOC(cur->dst);
+               GIT_ERROR_CHECK_ALLOC(cur->dst);
        }
 
        return git_vector_insert(out, cur);