]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - tc/f_flower.c
lib: introduce print_nl
[mirror_iproute2.git] / tc / f_flower.c
index 99f5f8163ee0b571e432f9e615ebe56a7c8eb418..59e5f572c542968bac28dd72e0c940222e152813 100644 (file)
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <syslog.h>
 #include <string.h>
 #include <net/if.h>
+#include <linux/if_arp.h>
 #include <linux/if_ether.h>
 #include <linux/ip.h>
 #include <linux/tc_act/tc_vlan.h>
+#include <linux/mpls.h>
 
 #include "utils.h"
 #include "tc_util.h"
 #include "rt_names.h"
 
+enum flower_matching_flags {
+       FLOWER_IP_FLAGS,
+};
+
 enum flower_endpoint {
        FLOWER_ENDPOINT_SRC,
        FLOWER_ENDPOINT_DST
@@ -36,7 +41,7 @@ enum flower_icmp_field {
 static void explain(void)
 {
        fprintf(stderr,
-               "Usage: ... flower [ MATCH-LIST ]\n"
+               "Usage: ... flower [ MATCH-LIST ] [ verbose ]\n"
                "                  [ skip_sw | skip_hw ]\n"
                "                  [ action ACTION-SPEC ] [ classid CLASSID ]\n"
                "\n"
@@ -45,19 +50,36 @@ static void explain(void)
                "                       vlan_id VID |\n"
                "                       vlan_prio PRIORITY |\n"
                "                       vlan_ethtype [ ipv4 | ipv6 | ETH-TYPE ] |\n"
+               "                       cvlan_id VID |\n"
+               "                       cvlan_prio PRIORITY |\n"
+               "                       cvlan_ethtype [ ipv4 | ipv6 | ETH-TYPE ] |\n"
                "                       dst_mac MASKED-LLADDR |\n"
                "                       src_mac MASKED-LLADDR |\n"
                "                       ip_proto [tcp | udp | sctp | icmp | icmpv6 | IP-PROTO ] |\n"
+               "                       ip_tos MASKED-IP_TOS |\n"
+               "                       ip_ttl MASKED-IP_TTL |\n"
+               "                       mpls_label LABEL |\n"
+               "                       mpls_tc TC |\n"
+               "                       mpls_bos BOS |\n"
+               "                       mpls_ttl TTL |\n"
                "                       dst_ip PREFIX |\n"
                "                       src_ip PREFIX |\n"
                "                       dst_port PORT-NUMBER |\n"
                "                       src_port PORT-NUMBER |\n"
-               "                       type ICMP-TYPE |\n"
-               "                       code ICMP-CODE |\n"
+               "                       tcp_flags MASKED-TCP_FLAGS |\n"
+               "                       type MASKED-ICMP-TYPE |\n"
+               "                       code MASKED-ICMP-CODE |\n"
+               "                       arp_tip IPV4-PREFIX |\n"
+               "                       arp_sip IPV4-PREFIX |\n"
+               "                       arp_op [ request | reply | OP ] |\n"
+               "                       arp_tha MASKED-LLADDR |\n"
+               "                       arp_sha MASKED-LLADDR |\n"
                "                       enc_dst_ip [ IPV4-ADDR | IPV6-ADDR ] |\n"
                "                       enc_src_ip [ IPV4-ADDR | IPV6-ADDR ] |\n"
                "                       enc_key_id [ KEY-ID ] |\n"
-               "                       matching_flags MATCHING-FLAGS | \n"
+               "                       enc_tos MASKED-IP_TOS |\n"
+               "                       enc_ttl MASKED-IP_TTL |\n"
+               "                       ip_flags IP-FLAGS | \n"
                "                       enc_dst_port [ port_number ] }\n"
                "       FILTERID := X:Y:Z\n"
                "       MASKED_LLADDR := { LLADDR | LLADDR/MASK | LLADDR/BITS }\n"
@@ -111,15 +133,21 @@ err:
        return err;
 }
 
+static bool eth_type_vlan(__be16 ethertype)
+{
+       return ethertype == htons(ETH_P_8021Q) ||
+              ethertype == htons(ETH_P_8021AD);
+}
+
 static int flower_parse_vlan_eth_type(char *str, __be16 eth_type, int type,
                                      __be16 *p_vlan_eth_type,
                                      struct nlmsghdr *n)
 {
        __be16 vlan_eth_type;
 
-       if (eth_type != htons(ETH_P_8021Q)) {
-               fprintf(stderr,
-                       "Can't set \"vlan_ethtype\" if ethertype isn't 802.1Q\n");
+       if (!eth_type_vlan(eth_type)) {
+               fprintf(stderr, "Can't set \"%s\" if ethertype isn't 802.1Q or 802.1AD\n",
+                       type == TCA_FLOWER_KEY_VLAN_ETH_TYPE ? "vlan_ethtype" : "cvlan_ethtype");
                return -1;
        }
 
@@ -130,28 +158,57 @@ static int flower_parse_vlan_eth_type(char *str, __be16 eth_type, int type,
        return 0;
 }
 
-static int flower_parse_matching_flags(char *str, int type, int mask_type,
-                                      struct nlmsghdr *n)
-{
-       __u32 mtf, mtf_mask;
-       char *c;
+struct flag_to_string {
+       int flag;
+       enum flower_matching_flags type;
+       char *string;
+};
 
-       c = strchr(str, '/');
-       if (c)
-               *c = '\0';
+static struct flag_to_string flags_str[] = {
+       { TCA_FLOWER_KEY_FLAGS_IS_FRAGMENT, FLOWER_IP_FLAGS, "frag" },
+       { TCA_FLOWER_KEY_FLAGS_FRAG_IS_FIRST, FLOWER_IP_FLAGS, "firstfrag" },
+};
 
-       if (get_u32(&mtf, str, 0))
-               return -1;
+static int flower_parse_matching_flags(char *str,
+                                      enum flower_matching_flags type,
+                                      __u32 *mtf, __u32 *mtf_mask)
+{
+       char *token;
+       bool no;
+       bool found;
+       int i;
 
-       if (c) {
-               if (get_u32(&mtf_mask, ++c, 0))
+       token = strtok(str, "/");
+
+       while (token) {
+               if (!strncmp(token, "no", 2)) {
+                       no = true;
+                       token += 2;
+               } else
+                       no = false;
+
+               found = false;
+               for (i = 0; i < ARRAY_SIZE(flags_str); i++) {
+                       if (type != flags_str[i].type)
+                               continue;
+
+                       if (!strcmp(token, flags_str[i].string)) {
+                               if (no)
+                                       *mtf &= ~flags_str[i].flag;
+                               else
+                                       *mtf |= flags_str[i].flag;
+
+                               *mtf_mask |= flags_str[i].flag;
+                               found = true;
+                               break;
+                       }
+               }
+               if (!found)
                        return -1;
-       } else {
-               mtf_mask = 0xffffffff;
+
+               token = strtok(NULL, "/");
        }
 
-       addattr32(n, MAX_MSG, type, htonl(mtf));
-       addattr32(n, MAX_MSG, mask_type, htonl(mtf_mask));
        return 0;
 }
 
@@ -192,27 +249,16 @@ err:
        return -1;
 }
 
-static int flower_parse_ip_addr(char *str, __be16 eth_type,
-                               int addr4_type, int mask4_type,
-                               int addr6_type, int mask6_type,
-                               struct nlmsghdr *n)
+static int __flower_parse_ip_addr(char *str, int family,
+                                 int addr4_type, int mask4_type,
+                                 int addr6_type, int mask6_type,
+                                 struct nlmsghdr *n)
 {
        int ret;
        inet_prefix addr;
-       int family;
        int bits;
        int i;
 
-       if (eth_type == htons(ETH_P_IP)) {
-               family = AF_INET;
-       } else if (eth_type == htons(ETH_P_IPV6)) {
-               family = AF_INET6;
-       } else if (!eth_type) {
-               family = AF_UNSPEC;
-       } else {
-               return -1;
-       }
-
        ret = get_prefix(&addr, str, family);
        if (ret)
                return -1;
@@ -245,6 +291,126 @@ static int flower_parse_ip_addr(char *str, __be16 eth_type,
        return 0;
 }
 
+static int flower_parse_ip_addr(char *str, __be16 eth_type,
+                               int addr4_type, int mask4_type,
+                               int addr6_type, int mask6_type,
+                               struct nlmsghdr *n)
+{
+       int family;
+
+       if (eth_type == htons(ETH_P_IP)) {
+               family = AF_INET;
+       } else if (eth_type == htons(ETH_P_IPV6)) {
+               family = AF_INET6;
+       } else if (!eth_type) {
+               family = AF_UNSPEC;
+       } else {
+               return -1;
+       }
+
+       return __flower_parse_ip_addr(str, family, addr4_type, mask4_type,
+                                     addr6_type, mask6_type, n);
+}
+
+static bool flower_eth_type_arp(__be16 eth_type)
+{
+       return eth_type == htons(ETH_P_ARP) || eth_type == htons(ETH_P_RARP);
+}
+
+static int flower_parse_arp_ip_addr(char *str, __be16 eth_type,
+                                   int addr_type, int mask_type,
+                                   struct nlmsghdr *n)
+{
+       if (!flower_eth_type_arp(eth_type))
+               return -1;
+
+       return __flower_parse_ip_addr(str, AF_INET, addr_type, mask_type,
+                                     TCA_FLOWER_UNSPEC, TCA_FLOWER_UNSPEC, n);
+}
+
+static int flower_parse_u8(char *str, int value_type, int mask_type,
+                          int (*value_from_name)(const char *str,
+                                                __u8 *value),
+                          bool (*value_validate)(__u8 value),
+                          struct nlmsghdr *n)
+{
+       char *slash;
+       int ret, err = -1;
+       __u8 value, mask;
+
+       slash = strchr(str, '/');
+       if (slash)
+               *slash = '\0';
+
+       ret = value_from_name ? value_from_name(str, &value) : -1;
+       if (ret < 0) {
+               ret = get_u8(&value, str, 10);
+               if (ret)
+                       goto err;
+       }
+
+       if (value_validate && !value_validate(value))
+               goto err;
+
+       if (slash) {
+               ret = get_u8(&mask, slash + 1, 10);
+               if (ret)
+                       goto err;
+       }
+       else {
+               mask = UINT8_MAX;
+       }
+
+       addattr8(n, MAX_MSG, value_type, value);
+       addattr8(n, MAX_MSG, mask_type, mask);
+
+       err = 0;
+err:
+       if (slash)
+               *slash = '/';
+       return err;
+}
+
+static const char *flower_print_arp_op_to_name(__u8 op)
+{
+       switch (op) {
+       case ARPOP_REQUEST:
+               return "request";
+       case ARPOP_REPLY:
+               return "reply";
+       default:
+               return NULL;
+       }
+}
+
+static int flower_arp_op_from_name(const char *name, __u8 *op)
+{
+       if (!strcmp(name, "request"))
+               *op = ARPOP_REQUEST;
+       else if (!strcmp(name, "reply"))
+               *op = ARPOP_REPLY;
+       else
+               return -1;
+
+       return 0;
+}
+
+static bool flow_arp_op_validate(__u8 op)
+{
+       return !op || op == ARPOP_REQUEST || op == ARPOP_REPLY;
+}
+
+static int flower_parse_arp_op(char *str, __be16 eth_type,
+                              int op_type, int mask_type,
+                              struct nlmsghdr *n)
+{
+       if (!flower_eth_type_arp(eth_type))
+               return -1;
+
+       return flower_parse_u8(str, op_type, mask_type, flower_arp_op_from_name,
+                              flow_arp_op_validate, n);
+}
+
 static int flower_icmp_attr_type(__be16 eth_type, __u8 ip_proto,
                                 enum flower_icmp_field field)
 {
@@ -260,24 +426,32 @@ static int flower_icmp_attr_type(__be16 eth_type, __u8 ip_proto,
        return -1;
 }
 
+static int flower_icmp_attr_mask_type(__be16 eth_type, __u8 ip_proto,
+                                     enum flower_icmp_field field)
+{
+       if (eth_type == htons(ETH_P_IP) && ip_proto == IPPROTO_ICMP)
+               return field == FLOWER_ICMP_FIELD_CODE ?
+                       TCA_FLOWER_KEY_ICMPV4_CODE_MASK :
+                       TCA_FLOWER_KEY_ICMPV4_TYPE_MASK;
+       else if (eth_type == htons(ETH_P_IPV6) && ip_proto == IPPROTO_ICMPV6)
+               return field == FLOWER_ICMP_FIELD_CODE ?
+                       TCA_FLOWER_KEY_ICMPV6_CODE_MASK :
+                       TCA_FLOWER_KEY_ICMPV6_TYPE_MASK;
+
+       return -1;
+}
+
 static int flower_parse_icmp(char *str, __u16 eth_type, __u8 ip_proto,
                             enum flower_icmp_field field, struct nlmsghdr *n)
 {
-       int ret;
-       int type;
-       uint8_t value;
-
-       type = flower_icmp_attr_type(eth_type, ip_proto, field);
-       if (type < 0)
-               return -1;
+       int value_type, mask_type;
 
-       ret = get_u8(&value, str, 10);
-       if (ret)
+       value_type = flower_icmp_attr_type(eth_type, ip_proto, field);
+       mask_type = flower_icmp_attr_mask_type(eth_type, ip_proto, field);
+       if (value_type < 0 || mask_type < 0)
                return -1;
 
-       addattr8(n, MAX_MSG, type, value);
-
-       return 0;
+       return flower_parse_u8(str, value_type, mask_type, NULL, NULL, n);
 }
 
 static int flower_port_attr_type(__u8 ip_proto, enum flower_endpoint endpoint)
@@ -319,6 +493,76 @@ static int flower_parse_port(char *str, __u8 ip_proto,
        return 0;
 }
 
+#define TCP_FLAGS_MAX_MASK 0xfff
+
+static int flower_parse_tcp_flags(char *str, int flags_type, int mask_type,
+                                 struct nlmsghdr *n)
+{
+       char *slash;
+       int ret, err = -1;
+       __u16 flags;
+
+       slash = strchr(str, '/');
+       if (slash)
+               *slash = '\0';
+
+       ret = get_u16(&flags, str, 16);
+       if (ret < 0 || flags & ~TCP_FLAGS_MAX_MASK)
+               goto err;
+
+       addattr16(n, MAX_MSG, flags_type, htons(flags));
+
+       if (slash) {
+               ret = get_u16(&flags, slash + 1, 16);
+               if (ret < 0 || flags & ~TCP_FLAGS_MAX_MASK)
+                       goto err;
+       } else {
+               flags = TCP_FLAGS_MAX_MASK;
+       }
+       addattr16(n, MAX_MSG, mask_type, htons(flags));
+
+       err = 0;
+err:
+       if (slash)
+               *slash = '/';
+       return err;
+}
+
+static int flower_parse_ip_tos_ttl(char *str, int key_type, int mask_type,
+                                  struct nlmsghdr *n)
+{
+       char *slash;
+       int ret, err = -1;
+       __u8 tos_ttl;
+
+       slash = strchr(str, '/');
+       if (slash)
+               *slash = '\0';
+
+       ret = get_u8(&tos_ttl, str, 10);
+       if (ret < 0)
+               ret = get_u8(&tos_ttl, str, 16);
+       if (ret < 0)
+               goto err;
+
+       addattr8(n, MAX_MSG, key_type, tos_ttl);
+
+       if (slash) {
+               ret = get_u8(&tos_ttl, slash + 1, 16);
+               if (ret < 0)
+                       goto err;
+       } else {
+               tos_ttl = 0xff;
+       }
+       addattr8(n, MAX_MSG, mask_type, tos_ttl);
+
+       err = 0;
+err:
+       if (slash)
+               *slash = '/';
+       return err;
+}
+
 static int flower_parse_key_id(const char *str, int type, struct nlmsghdr *n)
 {
        int ret;
@@ -353,8 +597,11 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
        struct rtattr *tail;
        __be16 eth_type = TC_H_MIN(t->tcm_info);
        __be16 vlan_ethtype = 0;
+       __be16 cvlan_ethtype = 0;
        __u8 ip_proto = 0xff;
        __u32 flags = 0;
+       __u32 mtf = 0;
+       __u32 mtf_mask = 0;
 
        if (handle) {
                ret = get_u32(&t->tcm_handle, handle, 0);
@@ -384,33 +631,52 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                                return -1;
                        }
                        addattr_l(n, MAX_MSG, TCA_FLOWER_CLASSID, &handle, 4);
-               } else if (matches(*argv, "matching_flags") == 0) {
+               } else if (matches(*argv, "hw_tc") == 0) {
+                       unsigned int handle;
+                       __u32 tc;
+                       char *end;
+
+                       NEXT_ARG();
+                       tc = strtoul(*argv, &end, 0);
+                       if (*end) {
+                               fprintf(stderr, "Illegal TC index\n");
+                               return -1;
+                       }
+                       if (tc >= TC_QOPT_MAX_QUEUE) {
+                               fprintf(stderr, "TC index exceeds max range\n");
+                               return -1;
+                       }
+                       handle = TC_H_MAKE(TC_H_MAJ(t->tcm_parent),
+                                          TC_H_MIN(tc + TC_H_MIN_PRIORITY));
+                       addattr_l(n, MAX_MSG, TCA_FLOWER_CLASSID, &handle,
+                                 sizeof(handle));
+               } else if (matches(*argv, "ip_flags") == 0) {
                        NEXT_ARG();
                        ret = flower_parse_matching_flags(*argv,
-                                                         TCA_FLOWER_KEY_FLAGS,
-                                                         TCA_FLOWER_KEY_FLAGS_MASK,
-                                                         n);
+                                                         FLOWER_IP_FLAGS,
+                                                         &mtf,
+                                                         &mtf_mask);
                        if (ret < 0) {
-                               fprintf(stderr, "Illegal \"matching_flags\"\n");
+                               fprintf(stderr, "Illegal \"ip_flags\"\n");
                                return -1;
                        }
+               } else if (matches(*argv, "verbose") == 0) {
+                       flags |= TCA_CLS_FLAGS_VERBOSE;
                } else if (matches(*argv, "skip_hw") == 0) {
                        flags |= TCA_CLS_FLAGS_SKIP_HW;
                } else if (matches(*argv, "skip_sw") == 0) {
                        flags |= TCA_CLS_FLAGS_SKIP_SW;
                } else if (matches(*argv, "indev") == 0) {
-                       char ifname[IFNAMSIZ] = {};
-
                        NEXT_ARG();
-                       strncpy(ifname, *argv, sizeof(ifname) - 1);
-                       addattrstrz(n, MAX_MSG, TCA_FLOWER_INDEV, ifname);
+                       if (check_ifname(*argv))
+                               invarg("\"indev\" not a valid ifname", *argv);
+                       addattrstrz(n, MAX_MSG, TCA_FLOWER_INDEV, *argv);
                } else if (matches(*argv, "vlan_id") == 0) {
                        __u16 vid;
 
                        NEXT_ARG();
-                       if (eth_type != htons(ETH_P_8021Q)) {
-                               fprintf(stderr,
-                                       "Can't set \"vlan_id\" if ethertype isn't 802.1Q\n");
+                       if (!eth_type_vlan(eth_type)) {
+                               fprintf(stderr, "Can't set \"vlan_id\" if ethertype isn't 802.1Q or 802.1AD\n");
                                return -1;
                        }
                        ret = get_u16(&vid, *argv, 10);
@@ -423,9 +689,8 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                        __u8 vlan_prio;
 
                        NEXT_ARG();
-                       if (eth_type != htons(ETH_P_8021Q)) {
-                               fprintf(stderr,
-                                       "Can't set \"vlan_prio\" if ethertype isn't 802.1Q\n");
+                       if (!eth_type_vlan(eth_type)) {
+                               fprintf(stderr, "Can't set \"vlan_prio\" if ethertype isn't 802.1Q or 802.1AD\n");
                                return -1;
                        }
                        ret = get_u8(&vlan_prio, *argv, 10);
@@ -442,6 +707,106 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                                                 &vlan_ethtype, n);
                        if (ret < 0)
                                return -1;
+               } else if (matches(*argv, "cvlan_id") == 0) {
+                       __u16 vid;
+
+                       NEXT_ARG();
+                       if (!eth_type_vlan(vlan_ethtype)) {
+                               fprintf(stderr, "Can't set \"cvlan_id\" if inner vlan ethertype isn't 802.1Q or 802.1AD\n");
+                               return -1;
+                       }
+                       ret = get_u16(&vid, *argv, 10);
+                       if (ret < 0 || vid & ~0xfff) {
+                               fprintf(stderr, "Illegal \"cvlan_id\"\n");
+                               return -1;
+                       }
+                       addattr16(n, MAX_MSG, TCA_FLOWER_KEY_CVLAN_ID, vid);
+               } else if (matches(*argv, "cvlan_prio") == 0) {
+                       __u8 cvlan_prio;
+
+                       NEXT_ARG();
+                       if (!eth_type_vlan(vlan_ethtype)) {
+                               fprintf(stderr, "Can't set \"cvlan_prio\" if inner vlan ethertype isn't 802.1Q or 802.1AD\n");
+                               return -1;
+                       }
+                       ret = get_u8(&cvlan_prio, *argv, 10);
+                       if (ret < 0 || cvlan_prio & ~0x7) {
+                               fprintf(stderr, "Illegal \"cvlan_prio\"\n");
+                               return -1;
+                       }
+                       addattr8(n, MAX_MSG,
+                                TCA_FLOWER_KEY_CVLAN_PRIO, cvlan_prio);
+               } else if (matches(*argv, "cvlan_ethtype") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_vlan_eth_type(*argv, vlan_ethtype,
+                                                TCA_FLOWER_KEY_CVLAN_ETH_TYPE,
+                                                &cvlan_ethtype, n);
+                       if (ret < 0)
+                               return -1;
+               } else if (matches(*argv, "mpls_label") == 0) {
+                       __u32 label;
+
+                       NEXT_ARG();
+                       if (eth_type != htons(ETH_P_MPLS_UC) &&
+                           eth_type != htons(ETH_P_MPLS_MC)) {
+                               fprintf(stderr,
+                                       "Can't set \"mpls_label\" if ethertype isn't MPLS\n");
+                               return -1;
+                       }
+                       ret = get_u32(&label, *argv, 10);
+                       if (ret < 0 || label & ~(MPLS_LS_LABEL_MASK >> MPLS_LS_LABEL_SHIFT)) {
+                               fprintf(stderr, "Illegal \"mpls_label\"\n");
+                               return -1;
+                       }
+                       addattr32(n, MAX_MSG, TCA_FLOWER_KEY_MPLS_LABEL, label);
+               } else if (matches(*argv, "mpls_tc") == 0) {
+                       __u8 tc;
+
+                       NEXT_ARG();
+                       if (eth_type != htons(ETH_P_MPLS_UC) &&
+                           eth_type != htons(ETH_P_MPLS_MC)) {
+                               fprintf(stderr,
+                                       "Can't set \"mpls_tc\" if ethertype isn't MPLS\n");
+                               return -1;
+                       }
+                       ret = get_u8(&tc, *argv, 10);
+                       if (ret < 0 || tc & ~(MPLS_LS_TC_MASK >> MPLS_LS_TC_SHIFT)) {
+                               fprintf(stderr, "Illegal \"mpls_tc\"\n");
+                               return -1;
+                       }
+                       addattr8(n, MAX_MSG, TCA_FLOWER_KEY_MPLS_TC, tc);
+               } else if (matches(*argv, "mpls_bos") == 0) {
+                       __u8 bos;
+
+                       NEXT_ARG();
+                       if (eth_type != htons(ETH_P_MPLS_UC) &&
+                           eth_type != htons(ETH_P_MPLS_MC)) {
+                               fprintf(stderr,
+                                       "Can't set \"mpls_bos\" if ethertype isn't MPLS\n");
+                               return -1;
+                       }
+                       ret = get_u8(&bos, *argv, 10);
+                       if (ret < 0 || bos & ~(MPLS_LS_S_MASK >> MPLS_LS_S_SHIFT)) {
+                               fprintf(stderr, "Illegal \"mpls_bos\"\n");
+                               return -1;
+                       }
+                       addattr8(n, MAX_MSG, TCA_FLOWER_KEY_MPLS_BOS, bos);
+               } else if (matches(*argv, "mpls_ttl") == 0) {
+                       __u8 ttl;
+
+                       NEXT_ARG();
+                       if (eth_type != htons(ETH_P_MPLS_UC) &&
+                           eth_type != htons(ETH_P_MPLS_MC)) {
+                               fprintf(stderr,
+                                       "Can't set \"mpls_ttl\" if ethertype isn't MPLS\n");
+                               return -1;
+                       }
+                       ret = get_u8(&ttl, *argv, 10);
+                       if (ret < 0 || ttl & ~(MPLS_LS_TTL_MASK >> MPLS_LS_TTL_SHIFT)) {
+                               fprintf(stderr, "Illegal \"mpls_ttl\"\n");
+                               return -1;
+                       }
+                       addattr8(n, MAX_MSG, TCA_FLOWER_KEY_MPLS_TTL, ttl);
                } else if (matches(*argv, "dst_mac") == 0) {
                        NEXT_ARG();
                        ret = flower_parse_eth_addr(*argv,
@@ -464,7 +829,8 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                        }
                } else if (matches(*argv, "ip_proto") == 0) {
                        NEXT_ARG();
-                       ret = flower_parse_ip_proto(*argv, vlan_ethtype ?
+                       ret = flower_parse_ip_proto(*argv, cvlan_ethtype ?
+                                                   cvlan_ethtype : vlan_ethtype ?
                                                    vlan_ethtype : eth_type,
                                                    TCA_FLOWER_KEY_IP_PROTO,
                                                    &ip_proto, n);
@@ -472,9 +838,30 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                                fprintf(stderr, "Illegal \"ip_proto\"\n");
                                return -1;
                        }
+               } else if (matches(*argv, "ip_tos") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_ip_tos_ttl(*argv,
+                                                     TCA_FLOWER_KEY_IP_TOS,
+                                                     TCA_FLOWER_KEY_IP_TOS_MASK,
+                                                     n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"ip_tos\"\n");
+                               return -1;
+                       }
+               } else if (matches(*argv, "ip_ttl") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_ip_tos_ttl(*argv,
+                                                     TCA_FLOWER_KEY_IP_TTL,
+                                                     TCA_FLOWER_KEY_IP_TTL_MASK,
+                                                     n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"ip_ttl\"\n");
+                               return -1;
+                       }
                } else if (matches(*argv, "dst_ip") == 0) {
                        NEXT_ARG();
-                       ret = flower_parse_ip_addr(*argv, vlan_ethtype ?
+                       ret = flower_parse_ip_addr(*argv, cvlan_ethtype ?
+                                                  cvlan_ethtype : vlan_ethtype ?
                                                   vlan_ethtype : eth_type,
                                                   TCA_FLOWER_KEY_IPV4_DST,
                                                   TCA_FLOWER_KEY_IPV4_DST_MASK,
@@ -487,7 +874,8 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                        }
                } else if (matches(*argv, "src_ip") == 0) {
                        NEXT_ARG();
-                       ret = flower_parse_ip_addr(*argv, vlan_ethtype ?
+                       ret = flower_parse_ip_addr(*argv, cvlan_ethtype ?
+                                                  cvlan_ethtype : vlan_ethtype ?
                                                   vlan_ethtype : eth_type,
                                                   TCA_FLOWER_KEY_IPV4_SRC,
                                                   TCA_FLOWER_KEY_IPV4_SRC_MASK,
@@ -514,6 +902,16 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                                fprintf(stderr, "Illegal \"src_port\"\n");
                                return -1;
                        }
+               } else if (matches(*argv, "tcp_flags") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_tcp_flags(*argv,
+                                                    TCA_FLOWER_KEY_TCP_FLAGS,
+                                                    TCA_FLOWER_KEY_TCP_FLAGS_MASK,
+                                                    n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"tcp_flags\"\n");
+                               return -1;
+                       }
                } else if (matches(*argv, "type") == 0) {
                        NEXT_ARG();
                        ret = flower_parse_icmp(*argv, eth_type, ip_proto,
@@ -530,6 +928,59 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                                fprintf(stderr, "Illegal \"icmp code\"\n");
                                return -1;
                        }
+               } else if (matches(*argv, "arp_tip") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_arp_ip_addr(*argv, vlan_ethtype ?
+                                                      vlan_ethtype : eth_type,
+                                                      TCA_FLOWER_KEY_ARP_TIP,
+                                                      TCA_FLOWER_KEY_ARP_TIP_MASK,
+                                                      n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"arp_tip\"\n");
+                               return -1;
+                       }
+               } else if (matches(*argv, "arp_sip") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_arp_ip_addr(*argv, vlan_ethtype ?
+                                                      vlan_ethtype : eth_type,
+                                                      TCA_FLOWER_KEY_ARP_SIP,
+                                                      TCA_FLOWER_KEY_ARP_SIP_MASK,
+                                                      n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"arp_sip\"\n");
+                               return -1;
+                       }
+               } else if (matches(*argv, "arp_op") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_arp_op(*argv, vlan_ethtype ?
+                                                 vlan_ethtype : eth_type,
+                                                 TCA_FLOWER_KEY_ARP_OP,
+                                                 TCA_FLOWER_KEY_ARP_OP_MASK,
+                                                 n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"arp_op\"\n");
+                               return -1;
+                       }
+               } else if (matches(*argv, "arp_tha") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_eth_addr(*argv,
+                                                   TCA_FLOWER_KEY_ARP_THA,
+                                                   TCA_FLOWER_KEY_ARP_THA_MASK,
+                                                   n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"arp_tha\"\n");
+                               return -1;
+                       }
+               } else if (matches(*argv, "arp_sha") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_eth_addr(*argv,
+                                                   TCA_FLOWER_KEY_ARP_SHA,
+                                                   TCA_FLOWER_KEY_ARP_SHA_MASK,
+                                                   n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"arp_sha\"\n");
+                               return -1;
+                       }
                } else if (matches(*argv, "enc_dst_ip") == 0) {
                        NEXT_ARG();
                        ret = flower_parse_ip_addr(*argv, 0,
@@ -570,6 +1021,26 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
                                fprintf(stderr, "Illegal \"enc_dst_port\"\n");
                                return -1;
                        }
+               } else if (matches(*argv, "enc_tos") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_ip_tos_ttl(*argv,
+                                                     TCA_FLOWER_KEY_ENC_IP_TOS,
+                                                     TCA_FLOWER_KEY_ENC_IP_TOS_MASK,
+                                                     n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"enc_tos\"\n");
+                               return -1;
+                       }
+               } else if (matches(*argv, "enc_ttl") == 0) {
+                       NEXT_ARG();
+                       ret = flower_parse_ip_tos_ttl(*argv,
+                                                     TCA_FLOWER_KEY_ENC_IP_TTL,
+                                                     TCA_FLOWER_KEY_ENC_IP_TTL_MASK,
+                                                     n);
+                       if (ret < 0) {
+                               fprintf(stderr, "Illegal \"enc_ttl\"\n");
+                               return -1;
+                       }
                } else if (matches(*argv, "action") == 0) {
                        NEXT_ARG();
                        ret = parse_action(&argc, &argv, TCA_FLOWER_ACT, n);
@@ -590,13 +1061,24 @@ static int flower_parse_opt(struct filter_util *qu, char *handle,
        }
 
 parse_done:
-       addattr32(n, MAX_MSG, TCA_FLOWER_FLAGS, flags);
+       ret = addattr32(n, MAX_MSG, TCA_FLOWER_FLAGS, flags);
+       if (ret)
+               return ret;
 
-       ret = addattr16(n, MAX_MSG, TCA_FLOWER_KEY_ETH_TYPE, eth_type);
-       if (ret) {
-               fprintf(stderr, "Illegal \"eth_type\"(0x%x)\n",
-                       ntohs(eth_type));
-               return -1;
+       if (mtf_mask) {
+               ret = addattr32(n, MAX_MSG, TCA_FLOWER_KEY_FLAGS, htonl(mtf));
+               if (ret)
+                       return ret;
+
+               ret = addattr32(n, MAX_MSG, TCA_FLOWER_KEY_FLAGS_MASK, htonl(mtf_mask));
+               if (ret)
+                       return ret;
+       }
+
+       if (eth_type != htons(ETH_P_ALL)) {
+               ret = addattr16(n, MAX_MSG, TCA_FLOWER_KEY_ETH_TYPE, eth_type);
+               if (ret)
+                       return ret;
        }
 
        tail->rta_len = (((void *)n)+n->nlmsg_len) - (void *)tail;
@@ -627,83 +1109,147 @@ static int __mask_bits(char *addr, size_t len)
        return bits;
 }
 
-static void flower_print_eth_addr(FILE *f, char *name,
-                                 struct rtattr *addr_attr,
+static void flower_print_eth_addr(char *name, struct rtattr *addr_attr,
                                  struct rtattr *mask_attr)
 {
+       SPRINT_BUF(namefrm);
+       SPRINT_BUF(out);
        SPRINT_BUF(b1);
+       size_t done;
        int bits;
 
        if (!addr_attr || RTA_PAYLOAD(addr_attr) != ETH_ALEN)
                return;
-       fprintf(f, "\n  %s %s", name, ll_addr_n2a(RTA_DATA(addr_attr), ETH_ALEN,
-                                                 0, b1, sizeof(b1)));
-       if (!mask_attr || RTA_PAYLOAD(mask_attr) != ETH_ALEN)
-               return;
-       bits = __mask_bits(RTA_DATA(mask_attr), ETH_ALEN);
-       if (bits < 0)
-               fprintf(f, "/%s", ll_addr_n2a(RTA_DATA(mask_attr), ETH_ALEN,
-                                             0, b1, sizeof(b1)));
-       else if (bits < ETH_ALEN * 8)
-               fprintf(f, "/%d", bits);
+       done = sprintf(out, "%s",
+                      ll_addr_n2a(RTA_DATA(addr_attr), ETH_ALEN,
+                                  0, b1, sizeof(b1)));
+       if (mask_attr && RTA_PAYLOAD(mask_attr) == ETH_ALEN) {
+               bits = __mask_bits(RTA_DATA(mask_attr), ETH_ALEN);
+               if (bits < 0)
+                       sprintf(out + done, "/%s",
+                               ll_addr_n2a(RTA_DATA(mask_attr), ETH_ALEN,
+                                           0, b1, sizeof(b1)));
+               else if (bits < ETH_ALEN * 8)
+                       sprintf(out + done, "/%d", bits);
+       }
+
+       sprintf(namefrm, "\n  %s %%s", name);
+       print_string(PRINT_ANY, name, namefrm, out);
 }
 
-static void flower_print_eth_type(FILE *f, __be16 *p_eth_type,
+static void flower_print_eth_type(__be16 *p_eth_type,
                                  struct rtattr *eth_type_attr)
 {
+       SPRINT_BUF(out);
        __be16 eth_type;
 
        if (!eth_type_attr)
                return;
 
        eth_type = rta_getattr_u16(eth_type_attr);
-       fprintf(f, "\n  eth_type ");
        if (eth_type == htons(ETH_P_IP))
-               fprintf(f, "ipv4");
+               sprintf(out, "ipv4");
        else if (eth_type == htons(ETH_P_IPV6))
-               fprintf(f, "ipv6");
+               sprintf(out, "ipv6");
+       else if (eth_type == htons(ETH_P_ARP))
+               sprintf(out, "arp");
+       else if (eth_type == htons(ETH_P_RARP))
+               sprintf(out, "rarp");
        else
-               fprintf(f, "%04x", ntohs(eth_type));
+               sprintf(out, "%04x", ntohs(eth_type));
+
+       print_string(PRINT_ANY, "eth_type", "\n  eth_type %s", out);
        *p_eth_type = eth_type;
 }
 
-static void flower_print_ip_proto(FILE *f, __u8 *p_ip_proto,
+static void flower_print_ip_proto(__u8 *p_ip_proto,
                                  struct rtattr *ip_proto_attr)
 {
+       SPRINT_BUF(out);
        __u8 ip_proto;
 
        if (!ip_proto_attr)
                return;
 
        ip_proto = rta_getattr_u8(ip_proto_attr);
-       fprintf(f, "\n  ip_proto ");
        if (ip_proto == IPPROTO_TCP)
-               fprintf(f, "tcp");
+               sprintf(out, "tcp");
        else if (ip_proto == IPPROTO_UDP)
-               fprintf(f, "udp");
+               sprintf(out, "udp");
        else if (ip_proto == IPPROTO_SCTP)
-               fprintf(f, "sctp");
+               sprintf(out, "sctp");
        else if (ip_proto == IPPROTO_ICMP)
-               fprintf(f, "icmp");
+               sprintf(out, "icmp");
        else if (ip_proto == IPPROTO_ICMPV6)
-               fprintf(f, "icmpv6");
+               sprintf(out, "icmpv6");
        else
-               fprintf(f, "%02x", ip_proto);
+               sprintf(out, "%02x", ip_proto);
+
+       print_string(PRINT_ANY, "ip_proto", "\n  ip_proto %s", out);
        *p_ip_proto = ip_proto;
 }
 
-static void flower_print_matching_flags(FILE *f, char *name,
+static void flower_print_ip_attr(const char *name, struct rtattr *key_attr,
+                                struct rtattr *mask_attr)
+{
+       SPRINT_BUF(namefrm);
+       SPRINT_BUF(out);
+       size_t done;
+
+       if (!key_attr)
+               return;
+
+       done = sprintf(out, "0x%x", rta_getattr_u8(key_attr));
+       if (mask_attr)
+               sprintf(out + done, "/%x", rta_getattr_u8(mask_attr));
+
+       print_string(PRINT_FP, NULL, "%s  ", _SL_);
+       sprintf(namefrm, "%s %%s", name);
+       print_string(PRINT_ANY, name, namefrm, out);
+}
+
+static void flower_print_matching_flags(char *name,
+                                       enum flower_matching_flags type,
                                        struct rtattr *attr,
                                        struct rtattr *mask_attr)
 {
+       int i;
+       int count = 0;
+       __u32 mtf;
+       __u32 mtf_mask;
+
        if (!mask_attr || RTA_PAYLOAD(mask_attr) != 4)
                return;
 
-       fprintf(f, "\n  %s 0x%08x/0x%08x", name, ntohl(rta_getattr_u32(attr)),
-               mask_attr ? ntohl(rta_getattr_u32(mask_attr)) : 0xffffffff);
+       mtf = ntohl(rta_getattr_u32(attr));
+       mtf_mask = ntohl(rta_getattr_u32(mask_attr));
+
+       for (i = 0; i < ARRAY_SIZE(flags_str); i++) {
+               if (type != flags_str[i].type)
+                       continue;
+               if (mtf_mask & flags_str[i].flag) {
+                       if (++count == 1) {
+                               print_string(PRINT_FP, NULL, "\n  %s ", name);
+                               open_json_object(name);
+                       } else {
+                               print_string(PRINT_FP, NULL, "/", NULL);
+                       }
+
+                       print_bool(PRINT_JSON, flags_str[i].string, NULL,
+                                  mtf & flags_str[i].flag);
+                       if (mtf & flags_str[i].flag)
+                               print_string(PRINT_FP, NULL, "%s",
+                                            flags_str[i].string);
+                       else
+                               print_string(PRINT_FP, NULL, "no%s",
+                                            flags_str[i].string);
+               }
+       }
+       if (count)
+               close_json_object();
 }
 
-static void flower_print_ip_addr(FILE *f, char *name, __be16 eth_type,
+static void flower_print_ip_addr(char *name, __be16 eth_type,
                                 struct rtattr *addr4_attr,
                                 struct rtattr *mask4_attr,
                                 struct rtattr *addr6_attr,
@@ -711,6 +1257,9 @@ static void flower_print_ip_addr(FILE *f, char *name, __be16 eth_type,
 {
        struct rtattr *addr_attr;
        struct rtattr *mask_attr;
+       SPRINT_BUF(namefrm);
+       SPRINT_BUF(out);
+       size_t done;
        int family;
        size_t len;
        int bits;
@@ -730,42 +1279,128 @@ static void flower_print_ip_addr(FILE *f, char *name, __be16 eth_type,
        }
        if (!addr_attr || RTA_PAYLOAD(addr_attr) != len)
                return;
-       fprintf(f, "\n  %s %s", name, rt_addr_n2a_rta(family, addr_attr));
        if (!mask_attr || RTA_PAYLOAD(mask_attr) != len)
                return;
+       done = sprintf(out, "%s", rt_addr_n2a_rta(family, addr_attr));
        bits = __mask_bits(RTA_DATA(mask_attr), len);
        if (bits < 0)
-               fprintf(f, "/%s", rt_addr_n2a_rta(family, mask_attr));
+               sprintf(out + done, "/%s", rt_addr_n2a_rta(family, mask_attr));
        else if (bits < len * 8)
-               fprintf(f, "/%d", bits);
+               sprintf(out + done, "/%d", bits);
+
+       sprintf(namefrm, "\n  %s %%s", name);
+       print_string(PRINT_ANY, name, namefrm, out);
+}
+static void flower_print_ip4_addr(char *name, struct rtattr *addr_attr,
+                                 struct rtattr *mask_attr)
+{
+       return flower_print_ip_addr(name, htons(ETH_P_IP),
+                                   addr_attr, mask_attr, 0, 0);
 }
 
-static void flower_print_port(FILE *f, char *name, struct rtattr *attr)
+static void flower_print_port(char *name, struct rtattr *attr)
 {
-       if (attr)
-               fprintf(f, "\n  %s %d", name, rta_getattr_be16(attr));
+       SPRINT_BUF(namefrm);
+
+       if (!attr)
+               return;
+
+       sprintf(namefrm,"\n  %s %%u", name);
+       print_hu(PRINT_ANY, name, namefrm, rta_getattr_be16(attr));
 }
 
-static void flower_print_key_id(FILE *f, const char *name,
-                               struct rtattr *attr)
+static void flower_print_tcp_flags(const char *name, struct rtattr *flags_attr,
+                                  struct rtattr *mask_attr)
 {
-       if (attr)
-               fprintf(f, "\n  %s %d", name, rta_getattr_be32(attr));
+       SPRINT_BUF(namefrm);
+       SPRINT_BUF(out);
+       size_t done;
+
+       if (!flags_attr)
+               return;
+
+       done = sprintf(out, "0x%x", rta_getattr_be16(flags_attr));
+       if (mask_attr)
+               sprintf(out + done, "/%x", rta_getattr_be16(mask_attr));
+
+       print_string(PRINT_FP, NULL, "%s  ", _SL_);
+       sprintf(namefrm, "%s %%s", name);
+       print_string(PRINT_ANY, name, namefrm, out);
 }
 
-static void flower_print_icmp(FILE *f, char *name, struct rtattr *attr)
+
+static void flower_print_key_id(const char *name, struct rtattr *attr)
 {
-       if (attr)
-               fprintf(f, "\n  %s %d", name, rta_getattr_u8(attr));
+       SPRINT_BUF(namefrm);
+
+       if (!attr)
+               return;
+
+       sprintf(namefrm,"\n  %s %%u", name);
+       print_uint(PRINT_ANY, name, namefrm, rta_getattr_be32(attr));
+}
+
+static void flower_print_masked_u8(const char *name, struct rtattr *attr,
+                                  struct rtattr *mask_attr,
+                                  const char *(*value_to_str)(__u8 value))
+{
+       const char *value_str = NULL;
+       __u8 value, mask;
+       SPRINT_BUF(namefrm);
+       SPRINT_BUF(out);
+       size_t done;
+
+       if (!attr)
+               return;
+
+       value = rta_getattr_u8(attr);
+       mask = mask_attr ? rta_getattr_u8(mask_attr) : UINT8_MAX;
+       if (mask == UINT8_MAX && value_to_str)
+               value_str = value_to_str(value);
+
+       if (value_str)
+               done = sprintf(out, "%s", value_str);
+       else
+               done = sprintf(out, "%d", value);
+
+       if (mask != UINT8_MAX)
+               sprintf(out + done, "/%d", mask);
+
+       sprintf(namefrm,"\n  %s %%s", name);
+       print_string(PRINT_ANY, name, namefrm, out);
+}
+
+static void flower_print_u8(const char *name, struct rtattr *attr)
+{
+       flower_print_masked_u8(name, attr, NULL, NULL);
+}
+
+static void flower_print_u32(const char *name, struct rtattr *attr)
+{
+       SPRINT_BUF(namefrm);
+
+       if (!attr)
+               return;
+
+       sprintf(namefrm,"\n  %s %%u", name);
+       print_uint(PRINT_ANY, name, namefrm, rta_getattr_u32(attr));
+}
+
+static void flower_print_arp_op(const char *name,
+                               struct rtattr *op_attr,
+                               struct rtattr *mask_attr)
+{
+       flower_print_masked_u8(name, op_attr, mask_attr,
+                              flower_print_arp_op_to_name);
 }
 
 static int flower_print_opt(struct filter_util *qu, FILE *f,
                            struct rtattr *opt, __u32 handle)
 {
        struct rtattr *tb[TCA_FLOWER_MAX + 1];
+       int nl_type, nl_mask_type;
        __be16 eth_type = 0;
        __u8 ip_proto = 0xff;
-       int nl_type;
 
        if (!opt)
                return 0;
@@ -773,68 +1408,145 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
        parse_rtattr_nested(tb, TCA_FLOWER_MAX, opt);
 
        if (handle)
-               fprintf(f, "handle 0x%x ", handle);
+               print_uint(PRINT_ANY, "handle", "handle 0x%x ", handle);
 
        if (tb[TCA_FLOWER_CLASSID]) {
-               SPRINT_BUF(b1);
-               fprintf(f, "classid %s ",
-                       sprint_tc_classid(rta_getattr_u32(tb[TCA_FLOWER_CLASSID]),
-                                         b1));
+               __u32 h = rta_getattr_u32(tb[TCA_FLOWER_CLASSID]);
+
+               if (TC_H_MIN(h) < TC_H_MIN_PRIORITY ||
+                   TC_H_MIN(h) > (TC_H_MIN_PRIORITY + TC_QOPT_MAX_QUEUE - 1)) {
+                       SPRINT_BUF(b1);
+                       print_string(PRINT_ANY, "classid", "classid %s ",
+                                    sprint_tc_classid(h, b1));
+               } else {
+                       print_uint(PRINT_ANY, "hw_tc", "hw_tc %u ",
+                                  TC_H_MIN(h) - TC_H_MIN_PRIORITY);
+               }
        }
 
        if (tb[TCA_FLOWER_INDEV]) {
                struct rtattr *attr = tb[TCA_FLOWER_INDEV];
 
-               fprintf(f, "\n  indev %s", rta_getattr_str(attr));
+               print_string(PRINT_ANY, "indev", "\n  indev %s",
+                            rta_getattr_str(attr));
        }
 
+       open_json_object("keys");
+
        if (tb[TCA_FLOWER_KEY_VLAN_ID]) {
                struct rtattr *attr = tb[TCA_FLOWER_KEY_VLAN_ID];
 
-               fprintf(f, "\n  vlan_id %d", rta_getattr_u16(attr));
+               print_uint(PRINT_ANY, "vlan_id", "\n  vlan_id %u",
+                          rta_getattr_u16(attr));
        }
 
        if (tb[TCA_FLOWER_KEY_VLAN_PRIO]) {
                struct rtattr *attr = tb[TCA_FLOWER_KEY_VLAN_PRIO];
 
-               fprintf(f, "\n  vlan_prio %d", rta_getattr_u8(attr));
+               print_uint(PRINT_ANY, "vlan_prio", "\n  vlan_prio %d",
+                          rta_getattr_u8(attr));
+       }
+
+       if (tb[TCA_FLOWER_KEY_VLAN_ETH_TYPE]) {
+               SPRINT_BUF(buf);
+               struct rtattr *attr = tb[TCA_FLOWER_KEY_VLAN_ETH_TYPE];
+
+               print_string(PRINT_ANY, "vlan_ethtype", "\n  vlan_ethtype %s",
+                            ll_proto_n2a(rta_getattr_u16(attr),
+                            buf, sizeof(buf)));
+       }
+
+       if (tb[TCA_FLOWER_KEY_CVLAN_ID]) {
+               struct rtattr *attr = tb[TCA_FLOWER_KEY_CVLAN_ID];
+
+               print_uint(PRINT_ANY, "cvlan_id", "\n  cvlan_id %u",
+                          rta_getattr_u16(attr));
+       }
+
+       if (tb[TCA_FLOWER_KEY_CVLAN_PRIO]) {
+               struct rtattr *attr = tb[TCA_FLOWER_KEY_CVLAN_PRIO];
+
+               print_uint(PRINT_ANY, "cvlan_prio", "\n  cvlan_prio %d",
+                          rta_getattr_u8(attr));
+       }
+
+       if (tb[TCA_FLOWER_KEY_CVLAN_ETH_TYPE]) {
+               SPRINT_BUF(buf);
+               struct rtattr *attr = tb[TCA_FLOWER_KEY_CVLAN_ETH_TYPE];
+
+               print_string(PRINT_ANY, "cvlan_ethtype", "\n  cvlan_ethtype %s",
+                            ll_proto_n2a(rta_getattr_u16(attr),
+                            buf, sizeof(buf)));
        }
 
-       flower_print_eth_addr(f, "dst_mac", tb[TCA_FLOWER_KEY_ETH_DST],
+       flower_print_eth_addr("dst_mac", tb[TCA_FLOWER_KEY_ETH_DST],
                              tb[TCA_FLOWER_KEY_ETH_DST_MASK]);
-       flower_print_eth_addr(f, "src_mac", tb[TCA_FLOWER_KEY_ETH_SRC],
+       flower_print_eth_addr("src_mac", tb[TCA_FLOWER_KEY_ETH_SRC],
                              tb[TCA_FLOWER_KEY_ETH_SRC_MASK]);
 
-       flower_print_eth_type(f, &eth_type, tb[TCA_FLOWER_KEY_ETH_TYPE]);
-       flower_print_ip_proto(f, &ip_proto, tb[TCA_FLOWER_KEY_IP_PROTO]);
+       flower_print_eth_type(&eth_type, tb[TCA_FLOWER_KEY_ETH_TYPE]);
+       flower_print_ip_proto(&ip_proto, tb[TCA_FLOWER_KEY_IP_PROTO]);
+
+       flower_print_ip_attr("ip_tos", tb[TCA_FLOWER_KEY_IP_TOS],
+                           tb[TCA_FLOWER_KEY_IP_TOS_MASK]);
+       flower_print_ip_attr("ip_ttl", tb[TCA_FLOWER_KEY_IP_TTL],
+                           tb[TCA_FLOWER_KEY_IP_TTL_MASK]);
 
-       flower_print_ip_addr(f, "dst_ip", eth_type,
+       flower_print_u32("mpls_label", tb[TCA_FLOWER_KEY_MPLS_LABEL]);
+       flower_print_u8("mpls_tc", tb[TCA_FLOWER_KEY_MPLS_TC]);
+       flower_print_u8("mpls_bos", tb[TCA_FLOWER_KEY_MPLS_BOS]);
+       flower_print_u8("mpls_ttl", tb[TCA_FLOWER_KEY_MPLS_TTL]);
+
+       flower_print_ip_addr("dst_ip", eth_type,
                             tb[TCA_FLOWER_KEY_IPV4_DST],
                             tb[TCA_FLOWER_KEY_IPV4_DST_MASK],
                             tb[TCA_FLOWER_KEY_IPV6_DST],
                             tb[TCA_FLOWER_KEY_IPV6_DST_MASK]);
 
-       flower_print_ip_addr(f, "src_ip", eth_type,
+       flower_print_ip_addr("src_ip", eth_type,
                             tb[TCA_FLOWER_KEY_IPV4_SRC],
                             tb[TCA_FLOWER_KEY_IPV4_SRC_MASK],
                             tb[TCA_FLOWER_KEY_IPV6_SRC],
                             tb[TCA_FLOWER_KEY_IPV6_SRC_MASK]);
 
-       nl_type = flower_port_attr_type(ip_proto, false);
-       if (nl_type >= 0)
-               flower_print_port(f, "dst_port", tb[nl_type]);
-       nl_type = flower_port_attr_type(ip_proto, true);
+       nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_DST);
        if (nl_type >= 0)
-               flower_print_port(f, "src_port", tb[nl_type]);
-
-       nl_type = flower_icmp_attr_type(eth_type, ip_proto, false);
+               flower_print_port("dst_port", tb[nl_type]);
+       nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_SRC);
        if (nl_type >= 0)
-               flower_print_icmp(f, "icmp_type", tb[nl_type]);
-       nl_type = flower_icmp_attr_type(eth_type, ip_proto, true);
-       if (nl_type >= 0)
-               flower_print_icmp(f, "icmp_code", tb[nl_type]);
-
-       flower_print_ip_addr(f, "enc_dst_ip",
+               flower_print_port("src_port", tb[nl_type]);
+
+       flower_print_tcp_flags("tcp_flags", tb[TCA_FLOWER_KEY_TCP_FLAGS],
+                              tb[TCA_FLOWER_KEY_TCP_FLAGS_MASK]);
+
+       nl_type = flower_icmp_attr_type(eth_type, ip_proto,
+                                       FLOWER_ICMP_FIELD_TYPE);
+       nl_mask_type = flower_icmp_attr_mask_type(eth_type, ip_proto,
+                                                 FLOWER_ICMP_FIELD_TYPE);
+       if (nl_type >= 0 && nl_mask_type >= 0)
+               flower_print_masked_u8("icmp_type", tb[nl_type],
+                                      tb[nl_mask_type], NULL);
+
+       nl_type = flower_icmp_attr_type(eth_type, ip_proto,
+                                       FLOWER_ICMP_FIELD_CODE);
+       nl_mask_type = flower_icmp_attr_mask_type(eth_type, ip_proto,
+                                                 FLOWER_ICMP_FIELD_CODE);
+       if (nl_type >= 0 && nl_mask_type >= 0)
+               flower_print_masked_u8("icmp_code", tb[nl_type],
+                                      tb[nl_mask_type], NULL);
+
+       flower_print_ip4_addr("arp_sip", tb[TCA_FLOWER_KEY_ARP_SIP],
+                            tb[TCA_FLOWER_KEY_ARP_SIP_MASK]);
+       flower_print_ip4_addr("arp_tip", tb[TCA_FLOWER_KEY_ARP_TIP],
+                            tb[TCA_FLOWER_KEY_ARP_TIP_MASK]);
+       flower_print_arp_op("arp_op", tb[TCA_FLOWER_KEY_ARP_OP],
+                           tb[TCA_FLOWER_KEY_ARP_OP_MASK]);
+       flower_print_eth_addr("arp_sha", tb[TCA_FLOWER_KEY_ARP_SHA],
+                             tb[TCA_FLOWER_KEY_ARP_SHA_MASK]);
+       flower_print_eth_addr("arp_tha", tb[TCA_FLOWER_KEY_ARP_THA],
+                             tb[TCA_FLOWER_KEY_ARP_THA_MASK]);
+
+       flower_print_ip_addr("enc_dst_ip",
                             tb[TCA_FLOWER_KEY_ENC_IPV4_DST_MASK] ?
                             htons(ETH_P_IP) : htons(ETH_P_IPV6),
                             tb[TCA_FLOWER_KEY_ENC_IPV4_DST],
@@ -842,7 +1554,7 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
                             tb[TCA_FLOWER_KEY_ENC_IPV6_DST],
                             tb[TCA_FLOWER_KEY_ENC_IPV6_DST_MASK]);
 
-       flower_print_ip_addr(f, "enc_src_ip",
+       flower_print_ip_addr("enc_src_ip",
                             tb[TCA_FLOWER_KEY_ENC_IPV4_SRC_MASK] ?
                             htons(ETH_P_IP) : htons(ETH_P_IPV6),
                             tb[TCA_FLOWER_KEY_ENC_IPV4_SRC],
@@ -850,27 +1562,37 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
                             tb[TCA_FLOWER_KEY_ENC_IPV6_SRC],
                             tb[TCA_FLOWER_KEY_ENC_IPV6_SRC_MASK]);
 
-       flower_print_key_id(f, "enc_key_id",
-                           tb[TCA_FLOWER_KEY_ENC_KEY_ID]);
+       flower_print_key_id("enc_key_id", tb[TCA_FLOWER_KEY_ENC_KEY_ID]);
+
+       flower_print_port("enc_dst_port", tb[TCA_FLOWER_KEY_ENC_UDP_DST_PORT]);
 
-       flower_print_port(f, "enc_dst_port",
-                         tb[TCA_FLOWER_KEY_ENC_UDP_DST_PORT]);
+       flower_print_ip_attr("enc_tos", tb[TCA_FLOWER_KEY_ENC_IP_TOS],
+                           tb[TCA_FLOWER_KEY_ENC_IP_TOS_MASK]);
+       flower_print_ip_attr("enc_ttl", tb[TCA_FLOWER_KEY_ENC_IP_TTL],
+                           tb[TCA_FLOWER_KEY_ENC_IP_TTL_MASK]);
 
-       flower_print_matching_flags(f, "matching_flags",
+       flower_print_matching_flags("ip_flags", FLOWER_IP_FLAGS,
                                    tb[TCA_FLOWER_KEY_FLAGS],
                                    tb[TCA_FLOWER_KEY_FLAGS_MASK]);
 
+       close_json_object();
+
        if (tb[TCA_FLOWER_FLAGS]) {
                __u32 flags = rta_getattr_u32(tb[TCA_FLOWER_FLAGS]);
 
                if (flags & TCA_CLS_FLAGS_SKIP_HW)
-                       fprintf(f, "\n  skip_hw");
+                       print_bool(PRINT_ANY, "skip_hw", "\n  skip_hw", true);
                if (flags & TCA_CLS_FLAGS_SKIP_SW)
-                       fprintf(f, "\n  skip_sw");
+                       print_bool(PRINT_ANY, "skip_sw", "\n  skip_sw", true);
+
+               if (flags & TCA_CLS_FLAGS_IN_HW)
+                       print_bool(PRINT_ANY, "in_hw", "\n  in_hw", true);
+               else if (flags & TCA_CLS_FLAGS_NOT_IN_HW)
+                       print_bool(PRINT_ANY, "not_in_hw", "\n  not_in_hw", true);
        }
 
        if (tb[TCA_FLOWER_ACT])
-               tc_print_action(f, tb[TCA_FLOWER_ACT]);
+               tc_print_action(f, tb[TCA_FLOWER_ACT], 0);
 
        return 0;
 }