]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - tc/m_action.c
rdma: Properly mark RDMAtool license
[mirror_iproute2.git] / tc / m_action.c
index 486123ea5c4a3009999984eab9ec0499c4991deb..b5aff3ab4896d4055f7683434cc9f6140ec7cbcb 100644 (file)
  * TODO:
  * - parse to be passed a filedescriptor for logging purposes
  *
-*/
+ */
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <stdbool.h>
 #include <unistd.h>
-#include <syslog.h>
 #include <fcntl.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include "tc_common.h"
 #include "tc_util.h"
 
-static struct action_util * action_list;
+static struct action_util *action_list;
 #ifdef CONFIG_GACT
-int gact_ld = 0 ; //fuckin backward compatibility
+static int gact_ld; /* f*ckin backward compatibility */
 #endif
-int tab_flush = 0;
+static int tab_flush;
 
 static void act_usage(void)
 {
@@ -42,11 +42,11 @@ static void act_usage(void)
         * with any action .so from the old days. But if someone really
         * does that, they would know how to fix this ..
         *
-       */
-       fprintf (stderr, "usage: tc actions <ACTSPECOP>*\n");
+        */
+       fprintf(stderr, "usage: tc actions <ACTSPECOP>*\n");
        fprintf(stderr,
                "Where: \tACTSPECOP := ACR | GD | FL\n"
-                       "\tACR := add | change | replace <ACTSPEC>* \n"
+                       "\tACR := add | change | replace <ACTSPEC>*\n"
                        "\tGD := get | delete | <ACTISPEC>*\n"
                        "\tFL := ls | list | flush | <ACTNAMESPEC>\n"
                        "\tACTNAMESPEC :=  action <ACTNAME>\n"
@@ -54,7 +54,7 @@ static void act_usage(void)
                        "\tACTSPEC := action <ACTDETAIL> [INDEXSPEC]\n"
                        "\tINDEXSPEC := index <32 bit indexvalue>\n"
                        "\tACTDETAIL := <ACTNAME> <ACTPARAMS>\n"
-                       "\t\tExample ACTNAME is gact, mirred etc\n"
+                       "\t\tExample ACTNAME is gact, mirred, bpf, etc\n"
                        "\t\tEach action has its own parameters (ACTPARAMS)\n"
                        "\n");
 
@@ -65,20 +65,23 @@ static int print_noaopt(struct action_util *au, FILE *f, struct rtattr *opt)
 {
        if (opt && RTA_PAYLOAD(opt))
                fprintf(f, "[Unknown action, optlen=%u] ",
-                       (unsigned) RTA_PAYLOAD(opt));
+                       (unsigned int) RTA_PAYLOAD(opt));
        return 0;
 }
 
-static int parse_noaopt(struct action_util *au, int *argc_p, char ***argv_p, int code, struct nlmsghdr *n)
+static int parse_noaopt(struct action_util *au, int *argc_p,
+                       char ***argv_p, int code, struct nlmsghdr *n)
 {
        int argc = *argc_p;
        char **argv = *argv_p;
 
-       if (argc) {
-               fprintf(stderr, "Unknown action \"%s\", hence option \"%s\" is unparsable\n", au->id, *argv);
-       } else {
+       if (argc)
+               fprintf(stderr,
+                       "Unknown action \"%s\", hence option \"%s\" is unparsable\n",
+                       au->id, *argv);
+       else
                fprintf(stderr, "Unknown action \"%s\"\n", au->id);
-       }
+
        return -1;
 }
 
@@ -122,13 +125,12 @@ noexist:
 #ifdef CONFIG_GACT
        if (!looked4gact) {
                looked4gact = 1;
-               strcpy(str,"gact");
+               strcpy(str, "gact");
                goto restart_s;
        }
 #endif
-       a = malloc(sizeof(*a));
+       a = calloc(1, sizeof(*a));
        if (a) {
-               memset(a, 0, sizeof(*a));
                strncpy(a->id, "noact", 15);
                a->parse_aopt = parse_noaopt;
                a->print_aopt = print_noaopt;
@@ -137,52 +139,46 @@ noexist:
        return a;
 }
 
-static int
+static bool
 new_cmd(char **argv)
 {
-       if ((matches(*argv, "change") == 0) ||
-               (matches(*argv, "replace") == 0)||
-               (matches(*argv, "delete") == 0)||
-               (matches(*argv, "get") == 0)||
-               (matches(*argv, "add") == 0))
-                       return 1;
-
-       return 0;
-
+       return (matches(*argv, "change") == 0) ||
+               (matches(*argv, "replace") == 0) ||
+               (matches(*argv, "delete") == 0) ||
+               (matches(*argv, "get") == 0) ||
+               (matches(*argv, "add") == 0);
 }
 
-int
-parse_action(int *argc_p, char ***argv_p, int tca_id, struct nlmsghdr *n)
+int parse_action(int *argc_p, char ***argv_p, int tca_id, struct nlmsghdr *n)
 {
        int argc = *argc_p;
        char **argv = *argv_p;
        struct rtattr *tail, *tail2;
-       char k[16];
+       char k[FILTER_NAMESZ];
+       int act_ck_len = 0;
        int ok = 0;
        int eap = 0; /* expect action parameters */
 
        int ret = 0;
        int prio = 0;
+       unsigned char act_ck[TC_COOKIE_MAX_SIZE];
 
        if (argc <= 0)
                return -1;
 
-       tail = tail2 = NLMSG_TAIL(n);
-
-       addattr_l(n, MAX_MSG, tca_id, NULL, 0);
+       tail2 = addattr_nest(n, MAX_MSG, tca_id);
 
        while (argc > 0) {
 
-               memset(k, 0, sizeof (k));
+               memset(k, 0, sizeof(k));
 
-               if (strcmp(*argv, "action") == 0 ) {
+               if (strcmp(*argv, "action") == 0) {
                        argc--;
                        argv++;
                        eap = 1;
 #ifdef CONFIG_GACT
-                       if (!gact_ld) {
+                       if (!gact_ld)
                                get_action_kind("gact");
-                       }
 #endif
                        continue;
                } else if (strcmp(*argv, "flowid") == 0) {
@@ -195,9 +191,13 @@ parse_action(int *argc_p, char ***argv_p, int tca_id, struct nlmsghdr *n)
                        goto done0;
                } else {
                        struct action_util *a = NULL;
-                       strncpy(k, *argv, sizeof (k) - 1);
+
+                       if (!action_a2n(*argv, NULL, false))
+                               strncpy(k, "gact", sizeof(k) - 1);
+                       else
+                               strncpy(k, *argv, sizeof(k) - 1);
                        eap = 0;
-                       if (argc > 0 ) {
+                       if (argc > 0) {
                                a = get_action_kind(k);
                        } else {
 done0:
@@ -207,32 +207,59 @@ done0:
                                        goto done;
                        }
 
-                       if (NULL == a) {
+                       if (a == NULL)
                                goto bad_val;
-                       }
 
-                       tail = NLMSG_TAIL(n);
-                       addattr_l(n, MAX_MSG, ++prio, NULL, 0);
+
+                       tail = addattr_nest(n, MAX_MSG, ++prio);
                        addattr_l(n, MAX_MSG, TCA_ACT_KIND, k, strlen(k) + 1);
 
-                       ret = a->parse_aopt(a,&argc, &argv, TCA_ACT_OPTIONS, n);
+                       ret = a->parse_aopt(a, &argc, &argv, TCA_ACT_OPTIONS,
+                                           n);
 
                        if (ret < 0) {
-                               fprintf(stderr,"bad action parsing\n");
+                               fprintf(stderr, "bad action parsing\n");
                                goto bad_val;
                        }
-                       tail->rta_len = (void *) NLMSG_TAIL(n) - (void *) tail;
+
+                       if (*argv && strcmp(*argv, "cookie") == 0) {
+                               size_t slen;
+
+                               NEXT_ARG();
+                               slen = strlen(*argv);
+                               if (slen > TC_COOKIE_MAX_SIZE * 2) {
+                                       char cookie_err_m[128];
+
+                                       snprintf(cookie_err_m, 128,
+                                                "%zd Max allowed size %d",
+                                                slen, TC_COOKIE_MAX_SIZE*2);
+                                       invarg(cookie_err_m, *argv);
+                               }
+
+                               if (hex2mem(*argv, act_ck, slen / 2) < 0)
+                                       invarg("cookie must be a hex string\n",
+                                              *argv);
+
+                               act_ck_len = slen / 2;
+                               argc--;
+                               argv++;
+                       }
+
+                       if (act_ck_len)
+                               addattr_l(n, MAX_MSG, TCA_ACT_COOKIE,
+                                         &act_ck, act_ck_len);
+
+                       addattr_nest_end(n, tail);
                        ok++;
                }
-
        }
 
        if (eap > 0) {
-               fprintf(stderr,"bad action empty %d\n",eap);
+               fprintf(stderr, "bad action empty %d\n", eap);
                goto bad_val;
        }
 
-       tail2->rta_len = (void *) NLMSG_TAIL(n) - (void *) tail2;
+       addattr_nest_end(n, tail2);
 
 done:
        *argc_p = argc;
@@ -240,13 +267,13 @@ done:
        return 0;
 bad_val:
        /* no need to undo things, returning from here should
-        * cause enough pain */
-       fprintf(stderr, "parse_action: bad value (%d:%s)!\n",argc,*argv);
+        * cause enough pain
+        */
+       fprintf(stderr, "parse_action: bad value (%d:%s)!\n", argc, *argv);
        return -1;
 }
 
-static int
-tc_print_one_action(FILE * f, struct rtattr *arg)
+static int tc_print_one_action(FILE *f, struct rtattr *arg)
 {
 
        struct rtattr *tb[TCA_ACT_MAX + 1];
@@ -265,18 +292,30 @@ tc_print_one_action(FILE * f, struct rtattr *arg)
 
 
        a = get_action_kind(RTA_DATA(tb[TCA_ACT_KIND]));
-       if (NULL == a)
+       if (a == NULL)
                return err;
 
        err = a->print_aopt(a, f, tb[TCA_ACT_OPTIONS]);
 
-       if (0 > err)
+       if (err < 0)
                return err;
 
        if (show_stats && tb[TCA_ACT_STATS]) {
-               fprintf(f, "\tAction statistics:\n");
+               print_string(PRINT_FP, NULL, "\tAction statistics:", NULL);
+               print_string(PRINT_FP, NULL, "%s", _SL_);
+               open_json_object("stats");
                print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL);
-               fprintf(f, "\n");
+               close_json_object();
+               print_string(PRINT_FP, NULL, "%s", _SL_);
+       }
+       if (tb[TCA_ACT_COOKIE]) {
+               int strsz = RTA_PAYLOAD(tb[TCA_ACT_COOKIE]);
+               char b1[strsz * 2 + 1];
+
+               print_string(PRINT_ANY, "cookie", "\tcookie %s",
+                            hexstring_n2a(RTA_DATA(tb[TCA_ACT_COOKIE]),
+                                          strsz, b1, sizeof(b1)));
+               print_string(PRINT_FP, NULL, "%s", _SL_);
        }
 
        return 0;
@@ -299,51 +338,61 @@ tc_print_action_flush(FILE *f, const struct rtattr *arg)
        }
 
        a = get_action_kind(RTA_DATA(tb[TCA_KIND]));
-       if (NULL == a)
+       if (a == NULL)
                return err;
 
        delete_count = RTA_DATA(tb[TCA_FCNT]);
-       fprintf(f," %s (%d entries)\n", a->id, *delete_count);
+       fprintf(f, " %s (%d entries)\n", a->id, *delete_count);
        tab_flush = 0;
        return 0;
 }
 
 int
-tc_print_action(FILE *f, const struct rtattr *arg)
+tc_print_action(FILE *f, const struct rtattr *arg, unsigned short tot_acts)
 {
 
        int i;
-       struct rtattr *tb[TCA_ACT_MAX_PRIO + 1];
 
        if (arg == NULL)
                return 0;
 
-       parse_rtattr_nested(tb, TCA_ACT_MAX_PRIO, arg);
+       if (!tot_acts)
+               tot_acts = TCA_ACT_MAX_PRIO;
 
-       if (tab_flush && NULL != tb[0]  && NULL == tb[1])
+       struct rtattr *tb[tot_acts + 1];
+
+       parse_rtattr_nested(tb, tot_acts, arg);
+
+       if (tab_flush && tb[0] && !tb[1])
                return tc_print_action_flush(f, tb[0]);
 
-       for (i = 0; i < TCA_ACT_MAX_PRIO; i++) {
+       open_json_array(PRINT_JSON, "actions");
+       for (i = 0; i <= tot_acts; i++) {
                if (tb[i]) {
-                       fprintf(f, "\n\taction order %d: ", i);
-                       if (0 > tc_print_one_action(f, tb[i])) {
-                               fprintf(f, "Error printing action\n");
+                       open_json_object(NULL);
+                       print_string(PRINT_FP, NULL, "%s", _SL_);
+                       print_uint(PRINT_ANY, "order",
+                                  "\taction order %u: ", i);
+                       if (tc_print_one_action(f, tb[i]) < 0) {
+                               print_string(PRINT_FP, NULL,
+                                            "Error printing action\n", NULL);
                        }
+                       close_json_object();
                }
 
        }
+       close_json_array(PRINT_JSON, NULL);
 
        return 0;
 }
 
-int print_action(const struct sockaddr_nl *who,
-                          struct nlmsghdr *n,
-                          void *arg)
+int print_action(struct nlmsghdr *n, void *arg)
 {
-       FILE *fp = (FILE*)arg;
+       FILE *fp = (FILE *)arg;
        struct tcamsg *t = NLMSG_DATA(n);
        int len = n->nlmsg_len;
-       struct rtattr * tb[TCAA_MAX+1];
+       __u32 *tot_acts = NULL;
+       struct rtattr *tb[TCA_ROOT_MAX+1];
 
        len -= NLMSG_LENGTH(sizeof(*t));
 
@@ -352,9 +401,17 @@ int print_action(const struct sockaddr_nl *who,
                return -1;
        }
 
-       parse_rtattr(tb, TCAA_MAX, TA_RTA(t), len);
+       parse_rtattr(tb, TCA_ROOT_MAX, TA_RTA(t), len);
+
+       if (tb[TCA_ROOT_COUNT])
+               tot_acts = RTA_DATA(tb[TCA_ROOT_COUNT]);
 
-       if (NULL == tb[TCA_ACT_TAB]) {
+       open_json_object(NULL);
+       print_uint(PRINT_ANY, "total acts", "total acts %u",
+                  tot_acts ? *tot_acts : 0);
+       print_string(PRINT_FP, NULL, "%s", _SL_);
+       close_json_object();
+       if (tb[TCA_ACT_TAB] == NULL) {
                if (n->nlmsg_type != RTM_GETACTION)
                        fprintf(stderr, "print_action: NULL kind\n");
                return -1;
@@ -365,27 +422,36 @@ int print_action(const struct sockaddr_nl *who,
                        fprintf(fp, "Flushed table ");
                        tab_flush = 1;
                } else {
-                       fprintf(fp, "deleted action ");
+                       fprintf(fp, "Deleted action ");
                }
        }
 
-       if (n->nlmsg_type == RTM_NEWACTION)
-               fprintf(fp, "Added action ");
-       tc_print_action(fp, tb[TCA_ACT_TAB]);
+       if (n->nlmsg_type == RTM_NEWACTION) {
+               if ((n->nlmsg_flags & NLM_F_CREATE) &&
+                   !(n->nlmsg_flags & NLM_F_REPLACE)) {
+                       fprintf(fp, "Added action ");
+               } else if (n->nlmsg_flags & NLM_F_REPLACE) {
+                       fprintf(fp, "Replaced action ");
+               }
+       }
+
+       open_json_object(NULL);
+       tc_print_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0);
+       close_json_object();
 
        return 0;
 }
 
-static int tc_action_gd(int cmd, unsigned flags, int *argc_p, char ***argv_p)
+static int tc_action_gd(int cmd, unsigned int flags,
+                       int *argc_p, char ***argv_p)
 {
-       char k[16];
+       char k[FILTER_NAMESZ];
        struct action_util *a = NULL;
        int argc = *argc_p;
        char **argv = *argv_p;
        int prio = 0;
        int ret = 0;
-       __u32 i;
-       struct sockaddr_nl nladdr;
+       __u32 i = 0;
        struct rtattr *tail;
        struct rtattr *tail2;
        struct nlmsghdr *ans = NULL;
@@ -394,27 +460,21 @@ static int tc_action_gd(int cmd, unsigned flags, int *argc_p, char ***argv_p)
                struct nlmsghdr         n;
                struct tcamsg           t;
                char                    buf[MAX_MSG];
-       } req;
-
-       req.t.tca_family = AF_UNSPEC;
-
-       memset(&req, 0, sizeof(req));
+       } req = {
+               .n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg)),
+               .n.nlmsg_flags = NLM_F_REQUEST | flags,
+               .n.nlmsg_type = cmd,
+               .t.tca_family = AF_UNSPEC,
+       };
 
-       memset(&nladdr, 0, sizeof(nladdr));
-       nladdr.nl_family = AF_NETLINK;
+       argc -= 1;
+       argv += 1;
 
-       req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg));
-       req.n.nlmsg_flags = NLM_F_REQUEST|flags;
-       req.n.nlmsg_type = cmd;
-       argc -=1;
-       argv +=1;
 
-
-       tail = NLMSG_TAIL(&req.n);
-       addattr_l(&req.n, MAX_MSG, TCA_ACT_TAB, NULL, 0);
+       tail = addattr_nest(&req.n, MAX_MSG, TCA_ACT_TAB);
 
        while (argc > 0) {
-               if (strcmp(*argv, "action") == 0 ) {
+               if (strcmp(*argv, "action") == 0) {
                        argc--;
                        argv++;
                        continue;
@@ -422,23 +482,24 @@ static int tc_action_gd(int cmd, unsigned flags, int *argc_p, char ***argv_p)
                        return -1;
                }
 
-               strncpy(k, *argv, sizeof (k) - 1);
+               strncpy(k, *argv, sizeof(k) - 1);
                a = get_action_kind(k);
-               if (NULL == a) {
-                       fprintf(stderr, "Error: non existent action: %s\n",k);
+               if (a == NULL) {
+                       fprintf(stderr, "Error: non existent action: %s\n", k);
                        ret = -1;
                        goto bad_val;
                }
                if (strcmp(a->id, k) != 0) {
-                       fprintf(stderr, "Error: non existent action: %s\n",k);
+                       fprintf(stderr, "Error: non existent action: %s\n", k);
                        ret = -1;
                        goto bad_val;
                }
 
-               argc -=1;
-               argv +=1;
+               argc -= 1;
+               argv += 1;
                if (argc <= 0) {
-                       fprintf(stderr, "Error: no index specified action: %s\n",k);
+                       fprintf(stderr,
+                               "Error: no index specified action: %s\n", k);
                        ret = -1;
                        goto bad_val;
                }
@@ -450,37 +511,44 @@ static int tc_action_gd(int cmd, unsigned flags, int *argc_p, char ***argv_p)
                                ret = -1;
                                goto bad_val;
                        }
-                       argc -=1;
-                       argv +=1;
+                       argc -= 1;
+                       argv += 1;
                } else {
-                       fprintf(stderr, "Error: no index specified action: %s\n",k);
+                       fprintf(stderr,
+                               "Error: no index specified action: %s\n", k);
                        ret = -1;
                        goto bad_val;
                }
 
-               tail2 = NLMSG_TAIL(&req.n);
-               addattr_l(&req.n, MAX_MSG, ++prio, NULL, 0);
+               tail2 = addattr_nest(&req.n, MAX_MSG, ++prio);
                addattr_l(&req.n, MAX_MSG, TCA_ACT_KIND, k, strlen(k) + 1);
-               addattr32(&req.n, MAX_MSG, TCA_ACT_INDEX, i);
-               tail2->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail2;
+               if (i > 0)
+                       addattr32(&req.n, MAX_MSG, TCA_ACT_INDEX, i);
+               addattr_nest_end(&req.n, tail2);
 
        }
 
-       tail->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail;
+       addattr_nest_end(&req.n, tail);
 
        req.n.nlmsg_seq = rth.dump = ++rth.seq;
-       if (cmd == RTM_GETACTION)
-               ans = &req.n;
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, ans) < 0) {
+       if (rtnl_talk(&rth, &req.n, cmd == RTM_DELACTION ? NULL : &ans) < 0) {
                fprintf(stderr, "We have an error talking to the kernel\n");
                return 1;
        }
 
-       if (ans && print_action(NULL, &req.n, (void*)stdout) < 0) {
-               fprintf(stderr, "Dump terminated\n");
-               return 1;
+       if (cmd == RTM_GETACTION) {
+               new_json_obj(json);
+               ret = print_action(ans, stdout);
+               if (ret < 0) {
+                       fprintf(stderr, "Dump terminated\n");
+                       free(ans);
+                       delete_json_obj();
+                       return 1;
+               }
+               delete_json_obj();
        }
+       free(ans);
 
        *argc_p = argc;
        *argv_p = argv;
@@ -488,98 +556,140 @@ bad_val:
        return ret;
 }
 
-static int tc_action_modify(int cmd, unsigned flags, int *argc_p, char ***argv_p)
+struct tc_action_req {
+       struct nlmsghdr         n;
+       struct tcamsg           t;
+       char                    buf[MAX_MSG];
+};
+
+static int tc_action_modify(int cmd, unsigned int flags,
+                           int *argc_p, char ***argv_p,
+                           void *buf, size_t buflen)
 {
-       int argc = *argc_p;
+       struct tc_action_req *req, action_req;
        char **argv = *argv_p;
-       int ret = 0;
-
        struct rtattr *tail;
-       struct {
-               struct nlmsghdr         n;
-               struct tcamsg           t;
-               char                    buf[MAX_MSG];
-       } req;
+       int argc = *argc_p;
+       struct iovec iov;
+       int ret = 0;
 
-       req.t.tca_family = AF_UNSPEC;
+       if (buf) {
+               req = buf;
+               if (buflen < sizeof (struct tc_action_req)) {
+                       fprintf(stderr, "buffer is too small: %zu\n", buflen);
+                       return -1;
+               }
+       } else {
+               memset(&action_req, 0, sizeof (struct tc_action_req));
+               req = &action_req;
+       }
 
-       memset(&req, 0, sizeof(req));
+       req->n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg));
+       req->n.nlmsg_flags = NLM_F_REQUEST | flags;
+       req->n.nlmsg_type = cmd;
+       req->t.tca_family = AF_UNSPEC;
+       tail = NLMSG_TAIL(&req->n);
 
-       req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg));
-       req.n.nlmsg_flags = NLM_F_REQUEST|flags;
-       req.n.nlmsg_type = cmd;
-       tail = NLMSG_TAIL(&req.n);
-       argc -=1;
-       argv +=1;
-       if (parse_action(&argc, &argv, TCA_ACT_TAB, &req.n)) {
+       argc -= 1;
+       argv += 1;
+       if (parse_action(&argc, &argv, TCA_ACT_TAB, &req->n)) {
                fprintf(stderr, "Illegal \"action\"\n");
                return -1;
        }
-       tail->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail;
+       tail->rta_len = (void *) NLMSG_TAIL(&req->n) - (void *) tail;
+
+       *argc_p = argc;
+       *argv_p = argv;
+
+       if (buf)
+               return 0;
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, NULL) < 0) {
+       iov.iov_base = &req->n;
+       iov.iov_len = req->n.nlmsg_len;
+       if (rtnl_talk_iov(&rth, &iov, 1, NULL) < 0) {
                fprintf(stderr, "We have an error talking to the kernel\n");
                ret = -1;
        }
 
-       *argc_p = argc;
-       *argv_p = argv;
-
        return ret;
 }
 
-static int tc_act_list_or_flush(int argc, char **argv, int event)
+static int tc_act_list_or_flush(int *argc_p, char ***argv_p, int event)
 {
+       struct rtattr *tail, *tail2, *tail3, *tail4;
        int ret = 0, prio = 0, msg_size = 0;
-       char k[16];
-       struct rtattr *tail,*tail2;
        struct action_util *a = NULL;
+       struct nla_bitfield32 flag_select = { 0 };
+       char **argv = *argv_p;
+       __u32 msec_since = 0;
+       int argc = *argc_p;
+       char k[FILTER_NAMESZ];
        struct {
                struct nlmsghdr         n;
                struct tcamsg           t;
                char                    buf[MAX_MSG];
-       } req;
-
-       req.t.tca_family = AF_UNSPEC;
-
-       memset(&req, 0, sizeof(req));
+       } req = {
+               .n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg)),
+               .t.tca_family = AF_UNSPEC,
+       };
 
-       req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcamsg));
-
-       tail = NLMSG_TAIL(&req.n);
-       addattr_l(&req.n, MAX_MSG, TCA_ACT_TAB, NULL, 0);
+       tail = addattr_nest(&req.n, MAX_MSG, TCA_ACT_TAB);
        tail2 = NLMSG_TAIL(&req.n);
 
-       strncpy(k, *argv, sizeof (k) - 1);
+       strncpy(k, *argv, sizeof(k) - 1);
 #ifdef CONFIG_GACT
-       if (!gact_ld) {
+       if (!gact_ld)
                get_action_kind("gact");
-       }
+
 #endif
        a = get_action_kind(k);
-       if (NULL == a) {
-               fprintf(stderr,"bad action %s\n",k);
+       if (a == NULL) {
+               fprintf(stderr, "bad action %s\n", k);
                goto bad_val;
        }
        if (strcmp(a->id, k) != 0) {
-               fprintf(stderr,"bad action %s\n",k);
+               fprintf(stderr, "bad action %s\n", k);
                goto bad_val;
        }
-       strncpy(k, *argv, sizeof (k) - 1);
+       strncpy(k, *argv, sizeof(k) - 1);
+
+       argc -= 1;
+       argv += 1;
+
+       if (argc && (strcmp(*argv, "since") == 0)) {
+               NEXT_ARG();
+               if (get_u32(&msec_since, *argv, 0))
+                       invarg("dump time \"since\" is invalid", *argv);
+       }
 
        addattr_l(&req.n, MAX_MSG, ++prio, NULL, 0);
        addattr_l(&req.n, MAX_MSG, TCA_ACT_KIND, k, strlen(k) + 1);
        tail2->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail2;
-       tail->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail;
-
-       msg_size = NLMSG_ALIGN(req.n.nlmsg_len) - NLMSG_ALIGN(sizeof(struct nlmsghdr));
+       addattr_nest_end(&req.n, tail);
+
+       tail3 = NLMSG_TAIL(&req.n);
+       flag_select.value |= TCA_FLAG_LARGE_DUMP_ON;
+       flag_select.selector |= TCA_FLAG_LARGE_DUMP_ON;
+       addattr_l(&req.n, MAX_MSG, TCA_ROOT_FLAGS, &flag_select,
+                 sizeof(struct nla_bitfield32));
+       tail3->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail3;
+       if (msec_since) {
+               tail4 = NLMSG_TAIL(&req.n);
+               addattr32(&req.n, MAX_MSG, TCA_ROOT_TIME_DELTA, msec_since);
+               tail4->rta_len = (void *) NLMSG_TAIL(&req.n) - (void *) tail4;
+       }
+       msg_size = NLMSG_ALIGN(req.n.nlmsg_len)
+               - NLMSG_ALIGN(sizeof(struct nlmsghdr));
 
        if (event == RTM_GETACTION) {
-               if (rtnl_dump_request(&rth, event, (void *)&req.t, msg_size) < 0) {
+               if (rtnl_dump_request(&rth, event,
+                                     (void *)&req.t, msg_size) < 0) {
                        perror("Cannot send dump request");
                        return 1;
                }
+               new_json_obj(json);
                ret = rtnl_dump_filter(&rth, print_action, stdout);
+               delete_json_obj();
        }
 
        if (event == RTM_DELACTION) {
@@ -587,7 +697,7 @@ static int tc_act_list_or_flush(int argc, char **argv, int event)
                req.n.nlmsg_type = RTM_DELACTION;
                req.n.nlmsg_flags |= NLM_F_ROOT;
                req.n.nlmsg_flags |= NLM_F_REQUEST;
-               if (rtnl_talk(&rth, &req.n, 0, 0, NULL) < 0) {
+               if (rtnl_talk(&rth, &req.n, NULL) < 0) {
                        fprintf(stderr, "We have an error flushing\n");
                        return 1;
                }
@@ -596,10 +706,12 @@ static int tc_act_list_or_flush(int argc, char **argv, int event)
 
 bad_val:
 
+       *argc_p = argc;
+       *argv_p = argv;
        return ret;
 }
 
-int do_action(int argc, char **argv)
+int do_action(int argc, char **argv, void *buf, size_t buflen)
 {
 
        int ret = 0;
@@ -607,45 +719,57 @@ int do_action(int argc, char **argv)
        while (argc > 0) {
 
                if (matches(*argv, "add") == 0) {
-                       ret =  tc_action_modify(RTM_NEWACTION, NLM_F_EXCL|NLM_F_CREATE, &argc, &argv);
+                       ret =  tc_action_modify(RTM_NEWACTION,
+                                               NLM_F_EXCL | NLM_F_CREATE,
+                                               &argc, &argv, buf, buflen);
                } else if (matches(*argv, "change") == 0 ||
                          matches(*argv, "replace") == 0) {
-                       ret = tc_action_modify(RTM_NEWACTION, NLM_F_CREATE|NLM_F_REPLACE, &argc, &argv);
+                       ret = tc_action_modify(RTM_NEWACTION,
+                                              NLM_F_CREATE | NLM_F_REPLACE,
+                                              &argc, &argv, buf, buflen);
                } else if (matches(*argv, "delete") == 0) {
-                       argc -=1;
-                       argv +=1;
+                       argc -= 1;
+                       argv += 1;
                        ret = tc_action_gd(RTM_DELACTION, 0,  &argc, &argv);
                } else if (matches(*argv, "get") == 0) {
-                       argc -=1;
-                       argv +=1;
+                       argc -= 1;
+                       argv += 1;
                        ret = tc_action_gd(RTM_GETACTION, 0,  &argc, &argv);
-               } else if (matches(*argv, "list") == 0 || matches(*argv, "show") == 0
-                                               || matches(*argv, "lst") == 0) {
+               } else if (matches(*argv, "list") == 0 ||
+                          matches(*argv, "show") == 0 ||
+                          matches(*argv, "lst") == 0) {
                        if (argc <= 2) {
                                act_usage();
                                return -1;
                        }
-                       return tc_act_list_or_flush(argc-2, argv+2, RTM_GETACTION);
+
+                       argc -= 2;
+                       argv += 2;
+                       return tc_act_list_or_flush(&argc, &argv,
+                                                   RTM_GETACTION);
                } else if (matches(*argv, "flush") == 0) {
                        if (argc <= 2) {
                                act_usage();
                                return -1;
                        }
-                       return tc_act_list_or_flush(argc-2, argv+2, RTM_DELACTION);
+
+                       argc -= 2;
+                       argv += 2;
+                       return tc_act_list_or_flush(&argc, &argv,
+                                                   RTM_DELACTION);
                } else if (matches(*argv, "help") == 0) {
                        act_usage();
                        return -1;
                } else {
-
-                       ret = -1;
+                       fprintf(stderr,
+                               "Command \"%s\" is unknown, try \"tc actions help\".\n",
+                               *argv);
+                       return -1;
                }
 
-               if (ret < 0) {
-                       fprintf(stderr, "Command \"%s\" is unknown, try \"tc actions help\".\n", *argv);
+               if (ret < 0)
                        return -1;
-               }
        }
 
        return 0;
 }
-