tc: code cleanup

[mirror_iproute2.git] / tc / m_skbedit.c

diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 990b9c7de89d20f09ed9a8fa4c965e3949d0b164..180b9cbd666cc1dd36beb0ac47613b954488f3d4 100644 (file)
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -12,9 +12,8 @@
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc., 59 Temple
- * Place - Suite 330, Boston, MA 02111-1307 USA.
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, see <http://www.gnu.org/licenses>.
  *
  * Authors:    Alexander Duyck <alexander.h.duyck@intel.com>
  *
@@ -31,10 +30,10 @@
 static void
 explain(void)
 {
-       fprintf(stderr, "Usage: ... skbedit <[QM] [PM] [MM]>\n"
+       fprintf(stderr, "Usage: ... skbedit <[QM] [PM] [MM]>\n"
                "QM = queue_mapping QUEUE_MAPPING\n"
-               "PM = priority PRIORITY \n"
-               "MM = mark MARK \n"
+               "PM = priority PRIORITY\n"
+               "MM = mark MARK\n"
                "QUEUE_MAPPING = device transmit queue to use\n"
                "PRIORITY = classID to assign to priority field\n"
                "MARK = firewall mark to set\n");
@@ -100,6 +99,7 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
                argv++;
        }
 
+       sel.action = TC_ACT_PIPE;
        if (argc) {
                if (matches(*argv, "reclassify") == 0) {
                        sel.action = TC_ACT_RECLASSIFY;
@@ -160,12 +160,13 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 
 static int print_skbedit(struct action_util *au, FILE *f, struct rtattr *arg)
 {
-       struct tc_skbedit *sel;
        struct rtattr *tb[TCA_SKBEDIT_MAX + 1];
+
        SPRINT_BUF(b1);
        __u32 *priority;
        __u32 *mark;
        __u16 *queue_mapping;
+       struct tc_skbedit *p = NULL;
 
        if (arg == NULL)
                return -1;
@@ -176,8 +177,7 @@ static int print_skbedit(struct action_util *au, FILE *f, struct rtattr *arg)
                fprintf(f, "[NULL skbedit parameters]");
                return -1;
        }
-
-       sel = RTA_DATA(tb[TCA_SKBEDIT_PARMS]);
+       p = RTA_DATA(tb[TCA_SKBEDIT_PARMS]);
 
        fprintf(f, " skbedit");
 
@@ -194,13 +194,18 @@ static int print_skbedit(struct action_util *au, FILE *f, struct rtattr *arg)
                fprintf(f, " mark %d", *mark);
        }
 
+       fprintf(f, "\n\t index %d ref %d bind %d", p->index, p->refcnt, p->bindcnt);
+
        if (show_stats) {
                if (tb[TCA_SKBEDIT_TM]) {
                        struct tcf_t *tm = RTA_DATA(tb[TCA_SKBEDIT_TM]);
+
                        print_tm(f, tm);
                }
        }
 
+       fprintf(f, "\n ");
+
        return 0;
 }