]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - tc/tc.c
tc: Remove pointless assignments in batch()
[mirror_iproute2.git] / tc / tc.c
diff --git a/tc/tc.c b/tc/tc.c
index 63e64fece87dc8b950b3784060e444f344d05053..eacd5c08573d4e9f1bc8bd22a35e218033f86c06 100644 (file)
--- a/tc/tc.c
+++ b/tc/tc.c
@@ -33,7 +33,6 @@
 int show_stats;
 int show_details;
 int show_raw;
-int show_pretty;
 int show_graph;
 int timestamp;
 
@@ -42,6 +41,8 @@ int use_iec;
 int force;
 bool use_names;
 int json;
+int color;
+int oneline;
 
 static char *conf_file;
 
@@ -60,10 +61,13 @@ static int print_noqopt(struct qdisc_util *qu, FILE *f,
        return 0;
 }
 
-static int parse_noqopt(struct qdisc_util *qu, int argc, char **argv, struct nlmsghdr *n, const char *dev)
+static int parse_noqopt(struct qdisc_util *qu, int argc, char **argv,
+                       struct nlmsghdr *n, const char *dev)
 {
        if (argc) {
-               fprintf(stderr, "Unknown qdisc \"%s\", hence option \"%s\" is unparsable\n", qu->id, *argv);
+               fprintf(stderr,
+                       "Unknown qdisc \"%s\", hence option \"%s\" is unparsable\n",
+                       qu->id, *argv);
                return -1;
        }
        return 0;
@@ -79,12 +83,15 @@ static int print_nofopt(struct filter_util *qu, FILE *f, struct rtattr *opt, __u
        return 0;
 }
 
-static int parse_nofopt(struct filter_util *qu, char *fhandle, int argc, char **argv, struct nlmsghdr *n)
+static int parse_nofopt(struct filter_util *qu, char *fhandle,
+                       int argc, char **argv, struct nlmsghdr *n)
 {
        __u32 handle;
 
        if (argc) {
-               fprintf(stderr, "Unknown filter \"%s\", hence option \"%s\" is unparsable\n", qu->id, *argv);
+               fprintf(stderr,
+                       "Unknown filter \"%s\", hence option \"%s\" is unparsable\n",
+                       qu->id, *argv);
                return -1;
        }
        if (fhandle) {
@@ -186,11 +193,15 @@ noexist:
 
 static void usage(void)
 {
-       fprintf(stderr, "Usage: tc [ OPTIONS ] OBJECT { COMMAND | help }\n"
-                       "       tc [-force] -batch filename\n"
-                       "where  OBJECT := { qdisc | class | filter | action | monitor | exec }\n"
-                       "       OPTIONS := { -s[tatistics] | -d[etails] | -r[aw] | -p[retty] | -b[atch] [filename] | -n[etns] name |\n"
-                       "                    -nm | -nam[es] | { -cf | -conf } path } | -j[son]\n");
+       fprintf(stderr,
+               "Usage: tc [ OPTIONS ] OBJECT { COMMAND | help }\n"
+               "       tc [-force] -batch filename\n"
+               "where  OBJECT := { qdisc | class | filter | chain |\n"
+               "                   action | monitor | exec }\n"
+               "       OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] | -r[aw] |\n"
+               "                    -o[neline] | -j[son] | -p[retty] | -c[olor]\n"
+               "                    -b[atch] [filename] | -n[etns] name |\n"
+               "                    -nm | -nam[es] | { -cf | -conf } path }\n");
 }
 
 static int do_cmd(int argc, char **argv, void *buf, size_t buflen)
@@ -201,6 +212,8 @@ static int do_cmd(int argc, char **argv, void *buf, size_t buflen)
                return do_class(argc-1, argv+1);
        if (matches(*argv, "filter") == 0)
                return do_filter(argc-1, argv+1, buf, buflen);
+       if (matches(*argv, "chain") == 0)
+               return do_chain(argc-1, argv+1, buf, buflen);
        if (matches(*argv, "actions") == 0)
                return do_action(argc-1, argv+1, buf, buflen);
        if (matches(*argv, "monitor") == 0)
@@ -224,8 +237,8 @@ static bool batchsize_enabled(int argc, char *argv[])
                char *c;
                char *subc[TC_MAX_SUBC];
        } table[] = {
-               {"filter", {"add", "delete", "change", "replace", NULL}},
-               {"actions", {"add", "change", "replace", NULL}},
+               { "filter", { "add", "delete", "change", "replace", NULL} },
+               { "actions", { "add", "change", "replace", NULL} },
                { NULL },
        }, *iter;
        char *s;
@@ -262,11 +275,11 @@ static struct batch_buf *get_batch_buf(struct batch_buf **pool,
        struct batch_buf *buf;
 
        if (*pool == NULL)
-               buf = calloc(1, sizeof (struct batch_buf));
+               buf = calloc(1, sizeof(struct batch_buf));
        else {
                buf = *pool;
                *pool = (*pool)->next;
-               memset(buf, 0, sizeof (struct batch_buf));
+               memset(buf, 0, sizeof(struct batch_buf));
        }
 
        if (*head == NULL)
@@ -312,20 +325,22 @@ static int batch(const char *name)
        struct batch_buf *head = NULL, *tail = NULL, *buf_pool = NULL;
        char *largv[100], *largv_next[100];
        char *line, *line_next = NULL;
-       bool bs_enabled_next = false;
        bool bs_enabled = false;
        bool lastline = false;
        int largc, largc_next;
        bool bs_enabled_saved;
+       bool bs_enabled_next;
        int batchsize = 0;
        size_t len = 0;
        int ret = 0;
+       int err;
        bool send;
 
        batch_mode = 1;
        if (name && strcmp(name, "-") != 0) {
                if (freopen(name, "r", stdin) == NULL) {
-                       fprintf(stderr, "Cannot open file \"%s\" for reading: %s\n",
+                       fprintf(stderr,
+                               "Cannot open file \"%s\" for reading: %s\n",
                                name, strerror(errno));
                        return -1;
                }
@@ -343,7 +358,6 @@ static int batch(const char *name)
                goto Exit;
        largc = makeargs(line, largv, 100);
        bs_enabled = batchsize_enabled(largc, largv);
-       bs_enabled_saved = bs_enabled;
        do {
                if (getcmdline(&line_next, &len, stdin) == -1)
                        lastline = true;
@@ -379,7 +393,6 @@ static int batch(const char *name)
                len = 0;
                bs_enabled_saved = bs_enabled;
                bs_enabled = bs_enabled_next;
-               bs_enabled_next = false;
 
                if (largc == 0) {
                        largc = largc_next;
@@ -387,9 +400,10 @@ static int batch(const char *name)
                        continue;       /* blank line */
                }
 
-               ret = do_cmd(largc, largv, tail == NULL ? NULL : tail->buf,
-                            tail == NULL ? 0 : sizeof (tail->buf));
-               if (ret != 0) {
+               err = do_cmd(largc, largv, tail == NULL ? NULL : tail->buf,
+                            tail == NULL ? 0 : sizeof(tail->buf));
+               fflush(stdout);
+               if (err != 0) {
                        fprintf(stderr, "Command failed %s:%d\n", name,
                                cmdlineno - 1);
                        ret = 1;
@@ -404,22 +418,24 @@ static int batch(const char *name)
                        struct batch_buf *buf;
                        struct nlmsghdr *n;
 
-                       iov = iovs = malloc(batchsize * sizeof (struct iovec));
+                       iov = iovs = malloc(batchsize * sizeof(struct iovec));
                        for (buf = head; buf != NULL; buf = buf->next, ++iov) {
                                n = (struct nlmsghdr *)&buf->buf;
                                iov->iov_base = n;
                                iov->iov_len = n->nlmsg_len;
                        }
 
-                       ret = rtnl_talk_iov(&rth, iovs, batchsize, NULL);
-                       if (ret < 0) {
+                       err = rtnl_talk_iov(&rth, iovs, batchsize, NULL);
+                       put_batch_bufs(&buf_pool, &head, &tail);
+                       free(iovs);
+                       if (err < 0) {
                                fprintf(stderr, "Command failed %s:%d\n", name,
-                                       cmdlineno - (batchsize + ret) - 1);
-                               return 2;
+                                       cmdlineno - (batchsize + err) - 1);
+                               ret = 1;
+                               if (!force)
+                                       break;
                        }
-                       put_batch_bufs(&buf_pool, &head, &tail);
                        batchsize = 0;
-                       free(iovs);
                }
        } while (!lastline);
 
@@ -448,7 +464,7 @@ int main(int argc, char **argv)
                } else if (matches(argv[1], "-raw") == 0) {
                        ++show_raw;
                } else if (matches(argv[1], "-pretty") == 0) {
-                       ++show_pretty;
+                       ++pretty;
                } else if (matches(argv[1], "-graph") == 0) {
                        show_graph = 1;
                } else if (matches(argv[1], "-Version") == 0) {
@@ -477,6 +493,7 @@ int main(int argc, char **argv)
                                matches(argv[1], "-conf") == 0) {
                        NEXT_ARG();
                        conf_file = argv[1];
+               } else if (matches_color(argv[1], &color)) {
                } else if (matches(argv[1], "-timestamp") == 0) {
                        timestamp++;
                } else if (matches(argv[1], "-tshort") == 0) {
@@ -484,13 +501,21 @@ int main(int argc, char **argv)
                        ++timestamp_short;
                } else if (matches(argv[1], "-json") == 0) {
                        ++json;
+               } else if (matches(argv[1], "-oneline") == 0) {
+                       ++oneline;
                } else {
-                       fprintf(stderr, "Option \"%s\" is unknown, try \"tc -help\".\n", argv[1]);
+                       fprintf(stderr,
+                               "Option \"%s\" is unknown, try \"tc -help\".\n",
+                               argv[1]);
                        return -1;
                }
                argc--; argv++;
        }
 
+       _SL_ = oneline ? "\\" : "\n";
+
+       check_enable_color(color, json);
+
        if (batch_file)
                return batch(batch_file);