]> git.proxmox.com Git - mirror_iproute2.git/blobdiff - tc/tc_filter.c
Tree wide: Drop sockaddr_nl arg
[mirror_iproute2.git] / tc / tc_filter.c
index 8f2a0b86956f99a768dd36cc4b0f1df234588da6..e5c7bc4605a2abdb5649c8e75ea09e35e7ffd7c6 100644 (file)
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-#include <syslog.h>
 #include <fcntl.h>
-#include <net/if.h>
-#include <net/if_arp.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include "tc_util.h"
 #include "tc_common.h"
 
-static void usage(void) __attribute__((noreturn));
-
 static void usage(void)
 {
-       fprintf(stderr, "Usage: tc filter [ add | del | change | get ] dev STRING\n");
-       fprintf(stderr, "       [ pref PRIO ] [ protocol PROTO ]\n");
-       fprintf(stderr, "       [ estimator INTERVAL TIME_CONSTANT ]\n");
-       fprintf(stderr, "       [ root | classid CLASSID ] [ handle FILTERID ]\n");
-       fprintf(stderr, "       [ [ FILTER_TYPE ] [ help | OPTIONS ] ]\n");
-       fprintf(stderr, "\n");
-       fprintf(stderr, "       tc filter show [ dev STRING ] [ root | parent CLASSID ]\n");
-       fprintf(stderr, "Where:\n");
-       fprintf(stderr, "FILTER_TYPE := { rsvp | u32 | fw | route | etc. }\n");
-       fprintf(stderr, "FILTERID := ... format depends on classifier, see there\n");
-       fprintf(stderr, "OPTIONS := ... try tc filter add <desired FILTER_KIND> help\n");
-       exit(-1);
+       fprintf(stderr,
+               "Usage: tc filter [ add | del | change | replace | show ] [ dev STRING ]\n"
+               "       tc filter [ add | del | change | replace | show ] [ block BLOCK_INDEX ]\n"
+               "       tc filter get dev STRING parent CLASSID protocol PROTO handle FILTERID pref PRIO FILTER_TYPE\n"
+               "       tc filter get block BLOCK_INDEX protocol PROTO handle FILTERID pref PRIO FILTER_TYPE\n"
+               "       [ pref PRIO ] protocol PROTO [ chain CHAIN_INDEX ]\n"
+               "       [ estimator INTERVAL TIME_CONSTANT ]\n"
+               "       [ root | ingress | egress | parent CLASSID ]\n"
+               "       [ handle FILTERID ] [ [ FILTER_TYPE ] [ help | OPTIONS ] ]\n"
+               "\n"
+               "       tc filter show [ dev STRING ] [ root | ingress | egress | parent CLASSID ]\n"
+               "       tc filter show [ block BLOCK_INDEX ]\n"
+               "Where:\n"
+               "FILTER_TYPE := { rsvp | u32 | bpf | fw | route | etc. }\n"
+               "FILTERID := ... format depends on classifier, see there\n"
+               "OPTIONS := ... try tc filter add <desired FILTER_KIND> help\n");
+}
+
+static void chain_usage(void)
+{
+       fprintf(stderr,
+               "Usage: tc chain [ add | del | get | show ] [ dev STRING ]\n"
+               "       tc chain [ add | del | get | show ] [ block BLOCK_INDEX ] ]\n");
 }
 
+struct tc_filter_req {
+       struct nlmsghdr         n;
+       struct tcmsg            t;
+       char                    buf[MAX_MSG];
+};
 
-int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv)
+static int tc_filter_modify(int cmd, unsigned int flags, int argc, char **argv,
+                           void *buf, size_t buflen)
 {
-       struct rtnl_handle rth;
-       struct {
-               struct nlmsghdr         n;
-               struct tcmsg            t;
-               char                    buf[MAX_MSG];
-       } req;
+       struct tc_filter_req *req, filter_req;
        struct filter_util *q = NULL;
-       __u32 prio = 0;
-       __u32 protocol = 0;
+       struct tc_estimator est = {};
+       char k[FILTER_NAMESZ] = {};
+       int chain_index_set = 0;
+       char d[IFNAMSIZ] = {};
+       int protocol_set = 0;
+       __u32 block_index = 0;
        char *fhandle = NULL;
-       char  d[16];
-       char  k[16];
-       struct tc_estimator est;
+       __u32 protocol = 0;
+       __u32 chain_index;
+       struct iovec iov;
+       __u32 prio = 0;
+       int ret;
+
+       if (buf) {
+               req = buf;
+               if (buflen < sizeof (struct tc_filter_req)) {
+                       fprintf(stderr, "buffer is too small: %zu\n", buflen);
+                       return -1;
+               }
+       } else {
+               memset(&filter_req, 0, sizeof (struct tc_filter_req));
+               req = &filter_req;
+       }
 
-       memset(&req, 0, sizeof(req));
-       memset(&est, 0, sizeof(est));
-       memset(d, 0, sizeof(d));
-       memset(k, 0, sizeof(k));
-       memset(&req, 0, sizeof(req));
+       req->n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcmsg));
+       req->n.nlmsg_flags = NLM_F_REQUEST | flags;
+       req->n.nlmsg_type = cmd;
+       req->t.tcm_family = AF_UNSPEC;
 
-       req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcmsg));
-       req.n.nlmsg_flags = NLM_F_REQUEST|flags;
-       req.n.nlmsg_type = cmd;
-       req.t.tcm_family = AF_UNSPEC;
+       if ((cmd == RTM_NEWTFILTER || cmd == RTM_NEWCHAIN) &&
+           flags & NLM_F_CREATE)
+               protocol = htons(ETH_P_ALL);
 
        while (argc > 0) {
                if (strcmp(*argv, "dev") == 0) {
                        NEXT_ARG();
                        if (d[0])
                                duparg("dev", *argv);
+                       if (block_index) {
+                               fprintf(stderr, "Error: \"dev\" and \"block\" are mutually exlusive\n");
+                               return -1;
+                       }
                        strncpy(d, *argv, sizeof(d)-1);
+               } else if (matches(*argv, "block") == 0) {
+                       NEXT_ARG();
+                       if (block_index)
+                               duparg("block", *argv);
+                       if (d[0]) {
+                               fprintf(stderr, "Error: \"dev\" and \"block\" are mutually exlusive\n");
+                               return -1;
+                       }
+                       if (get_u32(&block_index, *argv, 0) || !block_index)
+                               invarg("invalid block index value", *argv);
                } else if (strcmp(*argv, "root") == 0) {
-                       if (req.t.tcm_parent) {
-                               fprintf(stderr, "Error: \"root\" is duplicate parent ID\n");
-                               exit(-1);
+                       if (req->t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"root\" is duplicate parent ID\n");
+                               return -1;
                        }
-                       req.t.tcm_parent = TC_H_ROOT;
+                       req->t.tcm_parent = TC_H_ROOT;
+               } else if (strcmp(*argv, "ingress") == 0) {
+                       if (req->t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"ingress\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       req->t.tcm_parent = TC_H_MAKE(TC_H_CLSACT,
+                                                    TC_H_MIN_INGRESS);
+               } else if (strcmp(*argv, "egress") == 0) {
+                       if (req->t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"egress\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       req->t.tcm_parent = TC_H_MAKE(TC_H_CLSACT,
+                                                    TC_H_MIN_EGRESS);
                } else if (strcmp(*argv, "parent") == 0) {
                        __u32 handle;
+
                        NEXT_ARG();
-                       if (req.t.tcm_parent)
+                       if (req->t.tcm_parent)
                                duparg("parent", *argv);
                        if (get_tc_classid(&handle, *argv))
-                               invarg(*argv, "Invalid parent ID");
-                       req.t.tcm_parent = handle;
+                               invarg("Invalid parent ID", *argv);
+                       req->t.tcm_parent = handle;
                } else if (strcmp(*argv, "handle") == 0) {
                        NEXT_ARG();
                        if (fhandle)
@@ -104,21 +158,31 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv)
                        NEXT_ARG();
                        if (prio)
                                duparg("priority", *argv);
-                       if (get_u32(&prio, *argv, 0))
-                               invarg(*argv, "invalid prpriority value");
+                       if (get_u32(&prio, *argv, 0) || prio > 0xFFFF)
+                               invarg("invalid priority value", *argv);
                } else if (matches(*argv, "protocol") == 0) {
                        __u16 id;
+
                        NEXT_ARG();
-                       if (protocol)
+                       if (protocol_set)
                                duparg("protocol", *argv);
                        if (ll_proto_a2n(&id, *argv))
-                               invarg(*argv, "invalid protocol");
+                               invarg("invalid protocol", *argv);
                        protocol = id;
+                       protocol_set = 1;
+               } else if (matches(*argv, "chain") == 0) {
+                       NEXT_ARG();
+                       if (chain_index_set)
+                               duparg("chain", *argv);
+                       if (get_u32(&chain_index, *argv, 0))
+                               invarg("invalid chain index value", *argv);
+                       chain_index_set = 1;
                } else if (matches(*argv, "estimator") == 0) {
                        if (parse_estimator(&argc, &argv, &est) < 0)
                                return -1;
                } else if (matches(*argv, "help") == 0) {
                        usage();
+                       return 0;
                } else {
                        strncpy(k, *argv, sizeof(k)-1);
 
@@ -130,53 +194,58 @@ int tc_filter_modify(int cmd, unsigned flags, int argc, char **argv)
                argc--; argv++;
        }
 
-       req.t.tcm_info = TC_H_MAKE(prio<<16, protocol);
+       req->t.tcm_info = TC_H_MAKE(prio<<16, protocol);
+
+       if (chain_index_set)
+               addattr32(&req->n, sizeof(*req), TCA_CHAIN, chain_index);
 
        if (k[0])
-               addattr_l(&req.n, sizeof(req), TCA_KIND, k, strlen(k)+1);
+               addattr_l(&req->n, sizeof(*req), TCA_KIND, k, strlen(k)+1);
+
+       if (d[0])  {
+               ll_init_map(&rth);
+
+               req->t.tcm_ifindex = ll_name_to_index(d);
+               if (!req->t.tcm_ifindex)
+                       return -nodev(d);
+       } else if (block_index) {
+               req->t.tcm_ifindex = TCM_IFINDEX_MAGIC_BLOCK;
+               req->t.tcm_block_index = block_index;
+       }
 
        if (q) {
-               if (q->parse_fopt(q, fhandle, argc, argv, &req.n))
-                       exit(1);
+               if (q->parse_fopt(q, fhandle, argc, argv, &req->n))
+                       return 1;
        } else {
                if (fhandle) {
-                       fprintf(stderr, "Must specify filter type when using "
-                               "\"handle\"\n");
-                       exit(-1);
+                       fprintf(stderr,
+                               "Must specify filter type when using \"handle\"\n");
+                       return -1;
                }
                if (argc) {
                        if (matches(*argv, "help") == 0)
                                usage();
-                       fprintf(stderr, "Garbage instead of arguments \"%s ...\". Try \"tc filter help\".\n", *argv);
-                       exit(-1);
+                       fprintf(stderr,
+                               "Garbage instead of arguments \"%s ...\". Try \"tc filter help\".\n",
+                               *argv);
+                       return -1;
                }
        }
-       if (est.ewma_log)
-               addattr_l(&req.n, sizeof(req), TCA_RATE, &est, sizeof(est));
-
-
-       if (rtnl_open(&rth, 0) < 0) {
-               fprintf(stderr, "Cannot open rtnetlink\n");
-               exit(1);
-       }
 
-       if (d[0])  {
-               ll_init_map(&rth);
+       if (est.ewma_log)
+               addattr_l(&req->n, sizeof(*req), TCA_RATE, &est, sizeof(est));
 
-               if ((req.t.tcm_ifindex = ll_name_to_index(d)) == 0) {
-                       fprintf(stderr, "Cannot find device \"%s\"\n", d);
-                       rtnl_close(&rth);
-                       exit(1);
-               }
-       }
+       if (buf)
+               return 0;
 
-       if (rtnl_talk(&rth, &req.n, 0, 0, NULL, NULL, NULL) < 0) {
-               fprintf(stderr, "We have an error talking to the kernel\n");
-               rtnl_close(&rth);
-               exit(2);
+       iov.iov_base = &req->n;
+       iov.iov_len = req->n.nlmsg_len;
+       ret = rtnl_talk_iov(&rth, &iov, 1, NULL);
+       if (ret < 0) {
+               fprintf(stderr, "We have an error talking to the kernel, %d\n", ret);
+               return 2;
        }
 
-       rtnl_close(&rth);
        return 0;
 }
 
@@ -184,18 +253,27 @@ static __u32 filter_parent;
 static int filter_ifindex;
 static __u32 filter_prio;
 static __u32 filter_protocol;
+static __u32 filter_chain_index;
+static int filter_chain_index_set;
+static __u32 filter_block_index;
+__u16 f_proto;
 
-int print_filter(struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
+int print_filter(struct nlmsghdr *n, void *arg)
 {
-       FILE *fp = (FILE*)arg;
+       FILE *fp = (FILE *)arg;
        struct tcmsg *t = NLMSG_DATA(n);
        int len = n->nlmsg_len;
-       struct rtattr * tb[TCA_MAX+1];
+       struct rtattr *tb[TCA_MAX+1];
        struct filter_util *q;
        char abuf[256];
 
-       if (n->nlmsg_type != RTM_NEWTFILTER && n->nlmsg_type != RTM_DELTFILTER) {
-               fprintf(stderr, "Not a filter\n");
+       if (n->nlmsg_type != RTM_NEWTFILTER &&
+           n->nlmsg_type != RTM_GETTFILTER &&
+           n->nlmsg_type != RTM_DELTFILTER &&
+           n->nlmsg_type != RTM_NEWCHAIN &&
+           n->nlmsg_type != RTM_GETCHAIN &&
+           n->nlmsg_type != RTM_DELCHAIN) {
+               fprintf(stderr, "Not a filter(cmd %d)\n", n->nlmsg_type);
                return 0;
        }
        len -= NLMSG_LENGTH(sizeof(*t));
@@ -204,104 +282,396 @@ int print_filter(struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
                return -1;
        }
 
-       memset(tb, 0, sizeof(tb));
        parse_rtattr(tb, TCA_MAX, TCA_RTA(t), len);
 
-       if (tb[TCA_KIND] == NULL) {
+       if (tb[TCA_KIND] == NULL && (n->nlmsg_type == RTM_NEWTFILTER ||
+                                    n->nlmsg_type == RTM_GETTFILTER ||
+                                    n->nlmsg_type == RTM_DELTFILTER)) {
                fprintf(stderr, "print_filter: NULL kind\n");
                return -1;
        }
 
-       if (n->nlmsg_type == RTM_DELTFILTER)
-               fprintf(fp, "deleted ");
-
-       fprintf(fp, "filter ");
-       if (!filter_ifindex || filter_ifindex != t->tcm_ifindex)
-               fprintf(fp, "dev %s ", ll_index_to_name(t->tcm_ifindex));
-
-       if (!filter_parent || filter_parent != t->tcm_parent) {
-               if (t->tcm_parent == TC_H_ROOT)
-                       fprintf(fp, "root ");
-               else {
-                       print_tc_classid(abuf, sizeof(abuf), t->tcm_parent);
-                       fprintf(fp, "parent %s ", abuf);
+       open_json_object(NULL);
+
+       if (n->nlmsg_type == RTM_DELTFILTER || n->nlmsg_type == RTM_DELCHAIN)
+               print_bool(PRINT_ANY, "deleted", "deleted ", true);
+
+       if ((n->nlmsg_type == RTM_NEWTFILTER ||
+            n->nlmsg_type == RTM_NEWCHAIN) &&
+                       (n->nlmsg_flags & NLM_F_CREATE) &&
+                       !(n->nlmsg_flags & NLM_F_EXCL))
+               print_bool(PRINT_ANY, "replaced", "replaced ", true);
+
+       if ((n->nlmsg_type == RTM_NEWTFILTER ||
+            n->nlmsg_type == RTM_NEWCHAIN) &&
+                       (n->nlmsg_flags & NLM_F_CREATE) &&
+                       (n->nlmsg_flags & NLM_F_EXCL))
+               print_bool(PRINT_ANY, "added", "added ", true);
+
+       if (n->nlmsg_type == RTM_NEWTFILTER ||
+           n->nlmsg_type == RTM_GETTFILTER ||
+           n->nlmsg_type == RTM_DELTFILTER)
+               print_string(PRINT_FP, NULL, "filter ", NULL);
+       else
+               print_string(PRINT_FP, NULL, "chain ", NULL);
+       if (t->tcm_ifindex == TCM_IFINDEX_MAGIC_BLOCK) {
+               if (!filter_block_index ||
+                   filter_block_index != t->tcm_block_index)
+                       print_uint(PRINT_ANY, "block", "block %u ",
+                                  t->tcm_block_index);
+       } else {
+               if (!filter_ifindex || filter_ifindex != t->tcm_ifindex)
+                       print_devname(PRINT_ANY, t->tcm_ifindex);
+
+               if (!filter_parent || filter_parent != t->tcm_parent) {
+                       if (t->tcm_parent == TC_H_ROOT)
+                               print_bool(PRINT_ANY, "root", "root ", true);
+                       else if (t->tcm_parent == TC_H_MAKE(TC_H_CLSACT, TC_H_MIN_INGRESS))
+                               print_bool(PRINT_ANY, "ingress", "ingress ", true);
+                       else if (t->tcm_parent == TC_H_MAKE(TC_H_CLSACT, TC_H_MIN_EGRESS))
+                               print_bool(PRINT_ANY, "egress", "egress ", true);
+                       else {
+                               print_tc_classid(abuf, sizeof(abuf), t->tcm_parent);
+                               print_string(PRINT_ANY, "parent", "parent %s ", abuf);
+                       }
                }
        }
-       if (t->tcm_info) {
-               __u32 protocol = TC_H_MIN(t->tcm_info);
+
+       if (t->tcm_info && (n->nlmsg_type == RTM_NEWTFILTER ||
+                           n->nlmsg_type == RTM_DELTFILTER ||
+                           n->nlmsg_type == RTM_GETTFILTER)) {
+               f_proto = TC_H_MIN(t->tcm_info);
                __u32 prio = TC_H_MAJ(t->tcm_info)>>16;
-               if (!filter_protocol || filter_protocol != protocol) {
-                       if (protocol) {
+
+               if (!filter_protocol || filter_protocol != f_proto) {
+                       if (f_proto) {
                                SPRINT_BUF(b1);
-                               fprintf(fp, "protocol %s ",
-                                       ll_proto_n2a(protocol, b1, sizeof(b1)));
+                               print_string(PRINT_ANY, "protocol",
+                                            "protocol %s ",
+                                            ll_proto_n2a(f_proto, b1, sizeof(b1)));
                        }
                }
                if (!filter_prio || filter_prio != prio) {
                        if (prio)
-                               fprintf(fp, "pref %u ", prio);
+                               print_uint(PRINT_ANY, "pref", "pref %u ", prio);
                }
        }
-       fprintf(fp, "%s ", (char*)RTA_DATA(tb[TCA_KIND]));
-       q = get_filter_kind(RTA_DATA(tb[TCA_KIND]));
-       if (tb[TCA_OPTIONS]) {
-               if (q)
-                       q->print_fopt(q, fp, tb[TCA_OPTIONS], t->tcm_handle);
-               else
-                       fprintf(fp, "[cannot parse parameters]");
+       if (tb[TCA_KIND])
+               print_string(PRINT_ANY, "kind", "%s ", rta_getattr_str(tb[TCA_KIND]));
+
+       if (tb[TCA_CHAIN]) {
+               __u32 chain_index = rta_getattr_u32(tb[TCA_CHAIN]);
+
+               if (!filter_chain_index_set ||
+                   filter_chain_index != chain_index)
+                       print_uint(PRINT_ANY, "chain", "chain %u ",
+                                  chain_index);
        }
-       fprintf(fp, "\n");
 
-       if (show_stats) {
-               if (tb[TCA_STATS]) {
-                       if (RTA_PAYLOAD(tb[TCA_STATS]) < sizeof(struct tc_stats))
-                               fprintf(fp, "statistics truncated");
-                       else {
-                               struct tc_stats st;
-                               memcpy(&st, RTA_DATA(tb[TCA_STATS]), sizeof(st));
-                               print_tcstats(fp, &st);
-                               fprintf(fp, "\n");
-                       }
+       if (tb[TCA_KIND]) {
+               q = get_filter_kind(RTA_DATA(tb[TCA_KIND]));
+               if (tb[TCA_OPTIONS]) {
+                       open_json_object("options");
+                       if (q)
+                               q->print_fopt(q, fp, tb[TCA_OPTIONS], t->tcm_handle);
+                       else
+                               print_string(PRINT_FP, NULL,
+                                            "[cannot parse parameters]", NULL);
+                       close_json_object();
                }
        }
+       print_string(PRINT_FP, NULL, "\n", NULL);
+
+       if (show_stats && (tb[TCA_STATS] || tb[TCA_STATS2])) {
+               print_tcstats_attr(fp, tb, " ", NULL);
+               print_string(PRINT_FP, NULL, "\n", NULL);
+       }
+
+       close_json_object();
        fflush(fp);
        return 0;
 }
 
-
-int tc_filter_list(int argc, char **argv)
+static int tc_filter_get(int cmd, unsigned int flags, int argc, char **argv)
 {
-       struct tcmsg t;
-       struct rtnl_handle rth;
-       char d[16];
+       struct {
+               struct nlmsghdr n;
+               struct tcmsg            t;
+               char                    buf[MAX_MSG];
+       } req = {
+               .n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcmsg)),
+               /* NLM_F_ECHO is for backward compatibility. old kernels never
+                * respond without it and newer kernels will ignore it.
+                * In old kernels there is a side effect:
+                * In addition to a response to the GET you will receive an
+                * event (if you do tc mon).
+                */
+               .n.nlmsg_flags = NLM_F_REQUEST | NLM_F_ECHO | flags,
+               .n.nlmsg_type = cmd,
+               .t.tcm_parent = TC_H_UNSPEC,
+               .t.tcm_family = AF_UNSPEC,
+       };
+       struct nlmsghdr *answer;
+       struct filter_util *q = NULL;
        __u32 prio = 0;
        __u32 protocol = 0;
+       int protocol_set = 0;
+       __u32 chain_index;
+       int chain_index_set = 0;
+       __u32 block_index = 0;
+       __u32 parent_handle = 0;
        char *fhandle = NULL;
+       char  d[IFNAMSIZ] = {};
+       char  k[FILTER_NAMESZ] = {};
 
-       memset(&t, 0, sizeof(t));
-       t.tcm_family = AF_UNSPEC;
-       memset(d, 0, sizeof(d));
+       while (argc > 0) {
+               if (strcmp(*argv, "dev") == 0) {
+                       NEXT_ARG();
+                       if (d[0])
+                               duparg("dev", *argv);
+                       if (block_index) {
+                               fprintf(stderr, "Error: \"dev\" and \"block\" are mutually exlusive\n");
+                               return -1;
+                       }
+                       strncpy(d, *argv, sizeof(d)-1);
+               } else if (matches(*argv, "block") == 0) {
+                       NEXT_ARG();
+                       if (block_index)
+                               duparg("block", *argv);
+                       if (d[0]) {
+                               fprintf(stderr, "Error: \"dev\" and \"block\" are mutually exlusive\n");
+                               return -1;
+                       }
+                       if (get_u32(&block_index, *argv, 0) || !block_index)
+                               invarg("invalid block index value", *argv);
+               } else if (strcmp(*argv, "root") == 0) {
+                       if (req.t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"root\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       req.t.tcm_parent = TC_H_ROOT;
+               } else if (strcmp(*argv, "ingress") == 0) {
+                       if (req.t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"ingress\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       req.t.tcm_parent = TC_H_MAKE(TC_H_CLSACT,
+                                                    TC_H_MIN_INGRESS);
+               } else if (strcmp(*argv, "egress") == 0) {
+                       if (req.t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"egress\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       req.t.tcm_parent = TC_H_MAKE(TC_H_CLSACT,
+                                                    TC_H_MIN_EGRESS);
+               } else if (strcmp(*argv, "parent") == 0) {
+
+                       NEXT_ARG();
+                       if (req.t.tcm_parent)
+                               duparg("parent", *argv);
+                       if (get_tc_classid(&parent_handle, *argv))
+                               invarg("Invalid parent ID", *argv);
+                       req.t.tcm_parent = parent_handle;
+               } else if (strcmp(*argv, "handle") == 0) {
+                       NEXT_ARG();
+                       if (fhandle)
+                               duparg("handle", *argv);
+                       fhandle = *argv;
+               } else if (matches(*argv, "preference") == 0 ||
+                          matches(*argv, "priority") == 0) {
+                       NEXT_ARG();
+                       if (prio)
+                               duparg("priority", *argv);
+                       if (get_u32(&prio, *argv, 0) || prio > 0xFFFF)
+                               invarg("invalid priority value", *argv);
+               } else if (matches(*argv, "protocol") == 0) {
+                       __u16 id;
+
+                       NEXT_ARG();
+                       if (protocol_set)
+                               duparg("protocol", *argv);
+                       if (ll_proto_a2n(&id, *argv))
+                               invarg("invalid protocol", *argv);
+                       protocol = id;
+                       protocol_set = 1;
+               } else if (matches(*argv, "chain") == 0) {
+                       NEXT_ARG();
+                       if (chain_index_set)
+                               duparg("chain", *argv);
+                       if (get_u32(&chain_index, *argv, 0))
+                               invarg("invalid chain index value", *argv);
+                       chain_index_set = 1;
+               } else if (matches(*argv, "help") == 0) {
+                       usage();
+                       return 0;
+               } else {
+                       if (!**argv)
+                               invarg("invalid filter name", *argv);
+
+                       strncpy(k, *argv, sizeof(k)-1);
+
+                       q = get_filter_kind(k);
+                       argc--; argv++;
+                       break;
+               }
+
+               argc--; argv++;
+       }
+
+       if (cmd == RTM_GETTFILTER) {
+               if (!protocol_set) {
+                       fprintf(stderr, "Must specify filter protocol\n");
+                       return -1;
+               }
+
+               if (!prio) {
+                       fprintf(stderr, "Must specify filter priority\n");
+                       return -1;
+               }
+
+               req.t.tcm_info = TC_H_MAKE(prio<<16, protocol);
+       }
+
+       if (chain_index_set)
+               addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);
+
+       if (req.t.tcm_parent == TC_H_UNSPEC) {
+               fprintf(stderr, "Must specify filter parent\n");
+               return -1;
+       }
+
+       if (cmd == RTM_GETTFILTER) {
+               if (k[0])
+                       addattr_l(&req.n, sizeof(req), TCA_KIND, k, strlen(k)+1);
+               else {
+                       fprintf(stderr, "Must specify filter type\n");
+                       return -1;
+               }
+       }
+
+       if (d[0])  {
+               ll_init_map(&rth);
+
+               req.t.tcm_ifindex = ll_name_to_index(d);
+               if (!req.t.tcm_ifindex)
+                       return -nodev(d);
+               filter_ifindex = req.t.tcm_ifindex;
+       } else if (block_index) {
+               req.t.tcm_ifindex = TCM_IFINDEX_MAGIC_BLOCK;
+               req.t.tcm_block_index = block_index;
+               filter_block_index = block_index;
+       } else {
+               fprintf(stderr, "Must specify netdevice \"dev\" or block index \"block\"\n");
+               return -1;
+       }
+
+       if (cmd == RTM_GETTFILTER &&
+           q->parse_fopt(q, fhandle, argc, argv, &req.n))
+               return 1;
+
+       if (!fhandle && cmd == RTM_GETTFILTER) {
+               fprintf(stderr, "Must specify filter \"handle\"\n");
+               return -1;
+       }
+
+       if (argc) {
+               if (matches(*argv, "help") == 0)
+                       usage();
+               fprintf(stderr,
+                       "Garbage instead of arguments \"%s ...\". Try \"tc filter help\".\n",
+                       *argv);
+               return -1;
+       }
+
+       if (rtnl_talk(&rth, &req.n, &answer) < 0) {
+               fprintf(stderr, "We have an error talking to the kernel\n");
+               return 2;
+       }
+
+       new_json_obj(json);
+       print_filter(answer, (void *)stdout);
+       delete_json_obj();
+
+       free(answer);
+       return 0;
+}
+
+static int tc_filter_list(int cmd, int argc, char **argv)
+{
+       struct {
+               struct nlmsghdr n;
+               struct tcmsg t;
+               char buf[MAX_MSG];
+       } req = {
+               .n.nlmsg_len = NLMSG_LENGTH(sizeof(struct tcmsg)),
+               .n.nlmsg_type = cmd,
+               .t.tcm_parent = TC_H_UNSPEC,
+               .t.tcm_family = AF_UNSPEC,
+       };
+       char d[IFNAMSIZ] = {};
+       __u32 prio = 0;
+       __u32 protocol = 0;
+       __u32 chain_index;
+       __u32 block_index = 0;
+       char *fhandle = NULL;
 
        while (argc > 0) {
                if (strcmp(*argv, "dev") == 0) {
                        NEXT_ARG();
                        if (d[0])
                                duparg("dev", *argv);
+                       if (block_index) {
+                               fprintf(stderr, "Error: \"dev\" cannot be used in the same time as \"block\"\n");
+                               return -1;
+                       }
                        strncpy(d, *argv, sizeof(d)-1);
+               } else if (matches(*argv, "block") == 0) {
+                       NEXT_ARG();
+                       if (block_index)
+                               duparg("block", *argv);
+                       if (d[0]) {
+                               fprintf(stderr, "Error: \"block\" cannot be used in the same time as \"dev\"\n");
+                               return -1;
+                       }
+                       if (get_u32(&block_index, *argv, 0) || !block_index)
+                               invarg("invalid block index value", *argv);
                } else if (strcmp(*argv, "root") == 0) {
-                       if (t.tcm_parent) {
-                               fprintf(stderr, "Error: \"root\" is duplicate parent ID\n");
-                               exit(-1);
+                       if (req.t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"root\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       filter_parent = req.t.tcm_parent = TC_H_ROOT;
+               } else if (strcmp(*argv, "ingress") == 0) {
+                       if (req.t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"ingress\" is duplicate parent ID\n");
+                               return -1;
                        }
-                       filter_parent = t.tcm_parent = TC_H_ROOT;
+                       filter_parent = TC_H_MAKE(TC_H_CLSACT,
+                                                 TC_H_MIN_INGRESS);
+                       req.t.tcm_parent = filter_parent;
+               } else if (strcmp(*argv, "egress") == 0) {
+                       if (req.t.tcm_parent) {
+                               fprintf(stderr,
+                                       "Error: \"egress\" is duplicate parent ID\n");
+                               return -1;
+                       }
+                       filter_parent = TC_H_MAKE(TC_H_CLSACT,
+                                                 TC_H_MIN_EGRESS);
+                       req.t.tcm_parent = filter_parent;
                } else if (strcmp(*argv, "parent") == 0) {
                        __u32 handle;
+
                        NEXT_ARG();
-                       if (t.tcm_parent)
+                       if (req.t.tcm_parent)
                                duparg("parent", *argv);
                        if (get_tc_classid(&handle, *argv))
-                               invarg(*argv, "invalid parent ID");
-                       filter_parent = t.tcm_parent = handle;
+                               invarg("invalid parent ID", *argv);
+                       filter_parent = req.t.tcm_parent = handle;
                } else if (strcmp(*argv, "handle") == 0) {
                        NEXT_ARG();
                        if (fhandle)
@@ -313,82 +683,126 @@ int tc_filter_list(int argc, char **argv)
                        if (prio)
                                duparg("priority", *argv);
                        if (get_u32(&prio, *argv, 0))
-                               invarg(*argv, "invalid preference");
+                               invarg("invalid preference", *argv);
                        filter_prio = prio;
                } else if (matches(*argv, "protocol") == 0) {
                        __u16 res;
+
                        NEXT_ARG();
                        if (protocol)
                                duparg("protocol", *argv);
                        if (ll_proto_a2n(&res, *argv))
-                               invarg(*argv, "invalid protocol");
+                               invarg("invalid protocol", *argv);
                        protocol = res;
                        filter_protocol = protocol;
+               } else if (matches(*argv, "chain") == 0) {
+                       NEXT_ARG();
+                       if (filter_chain_index_set)
+                               duparg("chain", *argv);
+                       if (get_u32(&chain_index, *argv, 0))
+                               invarg("invalid chain index value", *argv);
+                       filter_chain_index_set = 1;
+                       filter_chain_index = chain_index;
                } else if (matches(*argv, "help") == 0) {
                        usage();
                } else {
-                       fprintf(stderr, " What is \"%s\"? Try \"tc filter help\"\n", *argv);
-                       exit(-1);
+                       fprintf(stderr,
+                               " What is \"%s\"? Try \"tc filter help\"\n",
+                               *argv);
+                       return -1;
                }
 
                argc--; argv++;
        }
 
-       t.tcm_info = TC_H_MAKE(prio<<16, protocol);
-
-       if (rtnl_open(&rth, 0) < 0) {
-               fprintf(stderr, "Cannot open rtnetlink\n");
-               exit(1);
-       }
+       req.t.tcm_info = TC_H_MAKE(prio<<16, protocol);
 
        ll_init_map(&rth);
 
        if (d[0]) {
-               if ((t.tcm_ifindex = ll_name_to_index(d)) == 0) {
-                       fprintf(stderr, "Cannot find device \"%s\"\n", d);
-                       rtnl_close(&rth);
-                       exit(1);
+               req.t.tcm_ifindex = ll_name_to_index(d);
+               if (!req.t.tcm_ifindex)
+                       return -nodev(d);
+               filter_ifindex = req.t.tcm_ifindex;
+       } else if (block_index) {
+               if (!tc_qdisc_block_exists(block_index)) {
+                       fprintf(stderr, "Cannot find block \"%u\"\n", block_index);
+                       return 1;
                }
-               filter_ifindex = t.tcm_ifindex;
+               req.t.tcm_ifindex = TCM_IFINDEX_MAGIC_BLOCK;
+               req.t.tcm_block_index = block_index;
+               filter_block_index = block_index;
        }
 
-       if (rtnl_dump_request(&rth, RTM_GETTFILTER, &t, sizeof(t)) < 0) {
+       if (filter_chain_index_set)
+               addattr32(&req.n, sizeof(req), TCA_CHAIN, chain_index);
+
+       if (rtnl_dump_request_n(&rth, &req.n) < 0) {
                perror("Cannot send dump request");
-               rtnl_close(&rth);
-               exit(1);
+               return 1;
        }
 
-       if (rtnl_dump_filter(&rth, print_filter, stdout, NULL, NULL) < 0) {
+       new_json_obj(json);
+       if (rtnl_dump_filter(&rth, print_filter, stdout) < 0) {
                fprintf(stderr, "Dump terminated\n");
-               exit(1);
+               return 1;
        }
+       delete_json_obj();
 
-       rtnl_close(&rth);
        return 0;
 }
 
-int do_filter(int argc, char **argv)
+int do_filter(int argc, char **argv, void *buf, size_t buflen)
 {
        if (argc < 1)
-               return tc_filter_list(0, NULL);
+               return tc_filter_list(RTM_GETTFILTER, 0, NULL);
        if (matches(*argv, "add") == 0)
-               return tc_filter_modify(RTM_NEWTFILTER, NLM_F_EXCL|NLM_F_CREATE, argc-1, argv+1);
+               return tc_filter_modify(RTM_NEWTFILTER, NLM_F_EXCL|NLM_F_CREATE,
+                                       argc-1, argv+1, buf, buflen);
        if (matches(*argv, "change") == 0)
-               return tc_filter_modify(RTM_NEWTFILTER, 0, argc-1, argv+1);
+               return tc_filter_modify(RTM_NEWTFILTER, 0, argc-1, argv+1,
+                                       buf, buflen);
        if (matches(*argv, "replace") == 0)
-               return tc_filter_modify(RTM_NEWTFILTER, NLM_F_CREATE, argc-1, argv+1);
+               return tc_filter_modify(RTM_NEWTFILTER, NLM_F_CREATE, argc-1,
+                                       argv+1, buf, buflen);
        if (matches(*argv, "delete") == 0)
-               return tc_filter_modify(RTM_DELTFILTER, 0,  argc-1, argv+1);
-#if 0
+               return tc_filter_modify(RTM_DELTFILTER, 0, argc-1, argv+1,
+                                       buf, buflen);
        if (matches(*argv, "get") == 0)
                return tc_filter_get(RTM_GETTFILTER, 0,  argc-1, argv+1);
-#endif
        if (matches(*argv, "list") == 0 || matches(*argv, "show") == 0
            || matches(*argv, "lst") == 0)
-               return tc_filter_list(argc-1, argv+1);
-       if (matches(*argv, "help") == 0)
+               return tc_filter_list(RTM_GETTFILTER, argc-1, argv+1);
+       if (matches(*argv, "help") == 0) {
                usage();
-       fprintf(stderr, "Command \"%s\" is unknown, try \"tc filter help\".\n", *argv);
-       exit(-1);
+               return 0;
+       }
+       fprintf(stderr, "Command \"%s\" is unknown, try \"tc filter help\".\n",
+               *argv);
+       return -1;
 }
 
+int do_chain(int argc, char **argv, void *buf, size_t buflen)
+{
+       if (argc < 1)
+               return tc_filter_list(RTM_GETCHAIN, 0, NULL);
+       if (matches(*argv, "add") == 0) {
+               return tc_filter_modify(RTM_NEWCHAIN, NLM_F_EXCL | NLM_F_CREATE,
+                                       argc - 1, argv + 1, buf, buflen);
+       } else if (matches(*argv, "delete") == 0) {
+               return tc_filter_modify(RTM_DELCHAIN, 0,
+                                       argc - 1, argv + 1, buf, buflen);
+       } else if (matches(*argv, "get") == 0) {
+               return tc_filter_get(RTM_GETCHAIN, 0,
+                                    argc - 1, argv + 1);
+       } else if (matches(*argv, "list") == 0 || matches(*argv, "show") == 0 ||
+                  matches(*argv, "lst") == 0) {
+               return tc_filter_list(RTM_GETCHAIN, argc - 1, argv + 1);
+       } else if (matches(*argv, "help") == 0) {
+               chain_usage();
+               return 0;
+       }
+       fprintf(stderr, "Command \"%s\" is unknown, try \"tc chain help\".\n",
+               *argv);
+       return -1;
+}