Merge pull request #12798 from donaldsharp/rib_match_multicast

[mirror_frr.git] / vtysh / vtysh_user.c

diff --git a/vtysh/vtysh_user.c b/vtysh/vtysh_user.c
index a7067984c488ace7131e6195e703561c281f20bd..a0667acc7ed8ce942ee71206ec32b6a9a9e3dbc8 100644 (file)
--- a/vtysh/vtysh_user.c
+++ b/vtysh/vtysh_user.c
@@ -1,21 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
 /* User authentication for vtysh.
  * Copyright (C) 2000 Kunihiro Ishiguro
- *
- * This file is part of GNU Zebra.
- *
- * GNU Zebra is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2, or (at your option) any
- * later version.
- *
- * GNU Zebra is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; see the file COPYING; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
 #include <zebra.h>
@@ -71,6 +56,10 @@ static int vtysh_pam(const char *user)
                fprintf(stderr, "vtysh_pam: Failure to initialize pam: %s(%d)",
                        pam_strerror(pamh, ret), ret);
 
+       if (pam_acct_mgmt(pamh, 0) != PAM_SUCCESS)
+               fprintf(stderr, "%s: Failed in account validation: %s(%d)",
+                       __func__, pam_strerror(pamh, ret), ret);
+
        /* close Linux-PAM */
        if (pam_end(pamh, ret) != PAM_SUCCESS) {
                pamh = NULL;
@@ -115,7 +104,8 @@ void user_config_write(void)
 
        for (ALL_LIST_ELEMENTS(userlist, node, nnode, user)) {
                if (user->nopassword) {
-                       sprintf(line, "username %s nopassword", user->name);
+                       snprintf(line, sizeof(line), "username %s nopassword",
+                                user->name);
                        config_add_line(config_top, line);
                }
        }