/* Interface between zebra message and rtm message. */
static int kernel_rtm_ipv4(int cmd, const struct prefix *p,
- struct route_entry *re)
+ const struct nexthop_group *ng, uint32_t metric)
{
struct sockaddr_in *mask = NULL;
#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */
/* Make gateway. */
- for (ALL_NEXTHOPS(re->ng, nexthop)) {
+ for (ALL_NEXTHOPS_PTR(ng, nexthop)) {
if (CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_RECURSIVE))
continue;
* other than ADD and DELETE?
*/
if ((cmd == RTM_ADD && NEXTHOP_IS_ACTIVE(nexthop->flags))
- || (cmd == RTM_DELETE
- && CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_FIB))) {
+ || (cmd == RTM_DELETE)) {
if (nexthop->type == NEXTHOP_TYPE_IPV4
|| nexthop->type == NEXTHOP_TYPE_IPV4_IFINDEX) {
sin_gate.sin_addr = nexthop->gate.ipv4;
(union sockunion *)mask,
gate ? (union sockunion *)&sin_gate
: NULL,
- smplsp, ifindex, bh_type, re->metric);
+ smplsp, ifindex, bh_type, metric);
- if (IS_ZEBRA_DEBUG_RIB) {
+ if (IS_ZEBRA_DEBUG_KERNEL) {
if (!gate) {
zlog_debug(
- "%s: %s: attention! gate not found for re %p",
- __func__, prefix_buf, re);
- route_entry_dump(p, NULL, re);
+ "%s: %s: attention! gate not found for re",
+ __func__, prefix_buf);
} else
inet_ntop(AF_INET, &sin_gate.sin_addr,
gate_buf, INET_ADDRSTRLEN);
* did its work. */
case ZEBRA_ERR_NOERROR:
nexthop_num++;
- if (IS_ZEBRA_DEBUG_RIB)
+ if (IS_ZEBRA_DEBUG_KERNEL)
zlog_debug(
"%s: %s: successfully did NH %s",
__func__, prefix_buf, gate_buf);
+
+ if (cmd == RTM_ADD)
+ SET_FLAG(nexthop->flags,
+ NEXTHOP_FLAG_FIB);
+
break;
/* The only valid case for this error is kernel's
"%s: rtm_write() returned %d for command %d",
__func__, error, cmd);
continue;
- break;
- /* Given that our NEXTHOP_FLAG_FIB matches real kernel
- * FIB, it isn't
- * normal to get any other messages in ANY case.
- */
- case ZEBRA_ERR_RTNOEXIST:
- case ZEBRA_ERR_RTUNREACH:
+ /* Note any unexpected status returns */
default:
flog_err(
EC_LIB_SYSTEM_CALL,
break;
}
} /* if (cmd and flags make sense) */
- else if (IS_ZEBRA_DEBUG_RIB)
+ else if (IS_ZEBRA_DEBUG_KERNEL)
zlog_debug("%s: odd command %s for flags %d", __func__,
lookup_msg(rtm_type_str, cmd, NULL),
nexthop->flags);
/* If there was no useful nexthop, then complain. */
if (nexthop_num == 0) {
if (IS_ZEBRA_DEBUG_KERNEL)
- zlog_debug("%s: No useful nexthops were found in RIB entry %p",
- __func__, re);
+ zlog_debug("%s: No useful nexthops were found in RIB prefix %s",
+ __func__, prefix2str(p, prefix_buf,
+ sizeof(prefix_buf)));
return 1;
}
/* Interface between zebra message and rtm message. */
static int kernel_rtm_ipv6(int cmd, const struct prefix *p,
- struct route_entry *re)
+ const struct nexthop_group *ng, uint32_t metric)
{
struct sockaddr_in6 *mask;
struct sockaddr_in6 sin_dest, sin_mask, sin_gate;
#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */
/* Make gateway. */
- for (ALL_NEXTHOPS(re->ng, nexthop)) {
+ for (ALL_NEXTHOPS_PTR(ng, nexthop)) {
if (CHECK_FLAG(nexthop->flags, NEXTHOP_FLAG_RECURSIVE))
continue;
error = rtm_write(cmd, (union sockunion *)&sin_dest,
(union sockunion *)mask,
gate ? (union sockunion *)&sin_gate : NULL,
- smplsp, ifindex, bh_type, re->metric);
- (void)error;
+ smplsp, ifindex, bh_type, metric);
+
+ /* Update installed nexthop info on success */
+ if ((cmd == RTM_ADD) && (error == ZEBRA_ERR_NOERROR))
+ SET_FLAG(nexthop->flags, NEXTHOP_FLAG_FIB);
nexthop_num++;
}
return 0; /*XXX*/
}
-static int kernel_rtm(int cmd, const struct prefix *p, struct route_entry *re)
+static int kernel_rtm(int cmd, const struct prefix *p,
+ const struct nexthop_group *ng, uint32_t metric)
{
switch (PREFIX_FAMILY(p)) {
case AF_INET:
- return kernel_rtm_ipv4(cmd, p, re);
+ return kernel_rtm_ipv4(cmd, p, ng, metric);
case AF_INET6:
- return kernel_rtm_ipv6(cmd, p, re);
+ return kernel_rtm_ipv6(cmd, p, ng, metric);
}
return 0;
}
-enum zebra_dplane_result kernel_route_rib(struct route_node *rn,
- const struct prefix *p,
- const struct prefix *src_p,
- struct route_entry *old,
- struct route_entry *new)
+/*
+ * Update or delete a prefix from the kernel,
+ * using info from a dataplane context struct.
+ */
+enum zebra_dplane_result kernel_route_update(struct zebra_dplane_ctx *ctx)
{
- int route = 0;
+ enum zebra_dplane_result res = ZEBRA_DPLANE_REQUEST_SUCCESS;
- if (src_p && src_p->prefixlen) {
- flog_warn(EC_ZEBRA_UNSUPPORTED_V6_SRCDEST,
- "%s: IPv6 sourcedest routes unsupported!", __func__);
- return ZEBRA_DPLANE_REQUEST_FAILURE;
+ if (dplane_ctx_get_src(ctx) != NULL) {
+ zlog_err("route add: IPv6 sourcedest routes unsupported!");
+ res = ZEBRA_DPLANE_REQUEST_FAILURE;
+ goto done;
}
frr_elevate_privs(&zserv_privs) {
- if (old)
- route |= kernel_rtm(RTM_DELETE, p, old);
-
- if (new)
- route |= kernel_rtm(RTM_ADD, p, new);
-
- }
+ if (dplane_ctx_get_op(ctx) == DPLANE_OP_ROUTE_DELETE)
+ kernel_rtm(RTM_DELETE, dplane_ctx_get_dest(ctx),
+ dplane_ctx_get_ng(ctx),
+ dplane_ctx_get_metric(ctx));
+ else if (dplane_ctx_get_op(ctx) == DPLANE_OP_ROUTE_INSTALL)
+ kernel_rtm(RTM_ADD, dplane_ctx_get_dest(ctx),
+ dplane_ctx_get_ng(ctx),
+ dplane_ctx_get_metric(ctx));
+ else if (dplane_ctx_get_op(ctx) == DPLANE_OP_ROUTE_UPDATE) {
+ /* Must do delete and add separately -
+ * no update available
+ */
+ kernel_rtm(RTM_DELETE, dplane_ctx_get_dest(ctx),
+ dplane_ctx_get_old_ng(ctx),
+ dplane_ctx_get_old_metric(ctx));
+
+ kernel_rtm(RTM_ADD, dplane_ctx_get_dest(ctx),
+ dplane_ctx_get_ng(ctx),
+ dplane_ctx_get_metric(ctx));
+ } else {
+ zlog_err("Invalid routing socket update op %s (%u)",
+ dplane_op2str(dplane_ctx_get_op(ctx)),
+ dplane_ctx_get_op(ctx));
+ res = ZEBRA_DPLANE_REQUEST_FAILURE;
+ }
+ } /* Elevated privs */
- if (new) {
- kernel_route_rib_pass_fail(
- rn, p, new,
- (!route) ? ZEBRA_DPLANE_INSTALL_SUCCESS
- : ZEBRA_DPLANE_INSTALL_FAILURE);
- } else {
- kernel_route_rib_pass_fail(rn, p, old,
- (!route)
- ? ZEBRA_DPLANE_DELETE_SUCCESS
- : ZEBRA_DPLANE_DELETE_FAILURE);
- }
+done:
- return ZEBRA_DPLANE_REQUEST_SUCCESS;
+ return res;
}
int kernel_neigh_update(int add, int ifindex, uint32_t addr, char *lla,
projects / mirror_frr.git / blobdiff