]> git.proxmox.com Git - mirror_qemu.git/commit - .gitlab-ci.yml
qemu-iotests, qtest: rewrite test 067 as a qtest
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 7 Oct 2020 10:43:03 +0000 (06:43 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 12 Oct 2020 15:50:50 +0000 (11:50 -0400)
commitd8a18da56df93b7f778fb97ba370031597d19ffd
tree0a874d0cc3a6f1ffc90b3c1a34f96123e5e2af83
parent9a613ddccce125e4cc3a4a23c294837c906440d6
qemu-iotests, qtest: rewrite test 067 as a qtest

Test 067 from qemu-iotests is executing QMP commands to hotplug
and hot-unplug disks, devices and blockdevs.  Because the power
of the text-based test harness is limited, it is actually limiting
the checks that it does, for example by skipping DEVICE_DELETED
events.

tests/qtest already has a similar test, drive_del-test.c.
We can merge them, and even reuse some of the existing code in
drive_del-test.c.  This will improve the quality of the test by
covering DEVICE_DELETED events and testing multiple architectures
(therefore covering multiple PCI hotplug mechanisms as well as s390x
virtio-ccw).

The only difference is that the new test will always use null-co:// for
the medium rather than qcow2 or raw, but this should be irrelevant for
what the test is covering.  For example there are no "qemu-img check"
runs in 067 that would check that the file is properly closed.

The new tests requires PCI hot-plug support, so drive_del-test
is moved from qemu-system-ppc to qemu-system-ppc64.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
.gitlab-ci.yml
tests/qemu-iotests/067 [deleted file]
tests/qemu-iotests/067.out [deleted file]
tests/qemu-iotests/group
tests/qtest/drive_del-test.c
tests/qtest/meson.build