]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit - Makefile
Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n"
authorMasahiro Yamada <masahiroy@kernel.org>
Fri, 19 Jun 2020 15:09:55 +0000 (00:09 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sun, 21 Jun 2020 15:19:14 +0000 (00:19 +0900)
commit2c6d9636ad92083d79a060edc84259526c153670
tree781050e27f127022f60bf2327a43360d641bd882
parent0f50d21ade110e519425a5c1e2cfee7a130d1a0e
Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n"

This reverts commit e0b250b57dcf403529081e5898a9de717f96b76b,
which broke build systems that need to install files to a certain
path, but do not set INSTALL_MOD_PATH when invoking 'make install'.

  $ make INSTALL_PATH=/tmp/destdir install
  mkdir: cannot create directory ‘/lib/modules/5.8.0-rc1+/’: Permission denied
  Makefile:1342: recipe for target '_builtin_inst_' failed
  make: *** [_builtin_inst_] Error 1

While modules.builtin is useful also for CONFIG_MODULES=n, this change
in the behavior is quite unexpected. Maybe "make modules_install"
can install modules.builtin irrespective of CONFIG_MODULES as Jonas
originally suggested.

Anyway, that commit should be reverted ASAP.

Reported-by: Douglas Anderson <dianders@chromium.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Cc: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Makefile