]> git.proxmox.com Git - pve-manager.git/commit - PVE/VZDump.pm
vzdump: warn when both storage and dumpdir are defined in vzdump.conf
authorFabian Ebner <f.ebner@proxmox.com>
Fri, 4 Dec 2020 09:15:17 +0000 (10:15 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Mon, 7 Dec 2020 08:31:12 +0000 (09:31 +0100)
commitf1dd762969d2dc392c3c31121eac127d516c8fc8
tree6c5130139f5252d082cccffb30cd21e5ba71552a
parentad2e3a09074320e4068bd25b679b8772140b306a
vzdump: warn when both storage and dumpdir are defined in vzdump.conf

and prefer storage, because the storage configuration might contain more
settings. Warning is preferable over dying, because all backups would be
affected (even if they don't use the vzdump.conf parameters) and the settings
could've been compatible (i.e. dumpdir being the storage's dump dir). Previously
one of the two options would randomly be chosen in the loop in new(), because of
perl hash iteration.

Reported here: https://forum.proxmox.com/threads/vzdump-times-out-very-often-on-zfs-storage-pool.80035/post-354277

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
PVE/VZDump.pm