]> git.proxmox.com Git - mirror_qemu.git/commit - accel/tcg/tcg-accel-ops-mttcg.c
Revert "accel/tcg: Init TCG cflags in vCPU thread handler"
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 21 Oct 2022 16:34:09 +0000 (17:34 +0100)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 25 Oct 2022 12:01:14 +0000 (22:01 +1000)
commit0585105c806d3bf301eebc33115a0790fcfc1d9c
treef2edb831f88690f09267969c741a99111247ba2b
parente750a7ace492f0b450653d4ad368a77d6f660fb8
Revert "accel/tcg: Init TCG cflags in vCPU thread handler"

Commit a82fd5a4ec24d was intended to be a code cleanup, but
unfortunately it has a bug. It moves the initialization of the
TCG cflags from the "start a new vcpu" function to the
thread handler; this is fine when each vcpu has its own thread,
but when we are doing round-robin of vcpus on a single thread
we end up only initializing the cflags for CPU 0, not for any
of the others.

The most obvious effect of this bug is that running in icount
mode with more than one CPU is broken; typically the guest
hangs shortly after it brings up the secondary CPUs.

This reverts commit a82fd5a4ec24d923ff1e6da128c0fd4a74079d99.

Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20221021163409.3674911-1-peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
accel/tcg/tcg-accel-ops-mttcg.c
accel/tcg/tcg-accel-ops-rr.c