]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - arch/x86/kernel/head_32.S
x86/asm: Don't use the confusing '.ifeq' directive
authorJosh Poimboeuf <jpoimboe@redhat.com>
Fri, 20 Oct 2017 16:21:35 +0000 (11:21 -0500)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Sat, 6 Jan 2018 12:22:43 +0000 (13:22 +0100)
commit981dedac1061fb47d0b04e07f6752be195d7e41a
tree67287208cf0ea9282c1393318dccd46ad794c030
parent55f73c32ba6438e8886f348722d2b25aef129d40
x86/asm: Don't use the confusing '.ifeq' directive

CVE-2017-5754

I find the '.ifeq <expression>' directive to be confusing.  Reading it
quickly seems to suggest its opposite meaning, or that it's missing an
argument.

Improve readability by replacing all of its x86 uses with
'.if <expression> == 0'.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andrei Vagin <avagin@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/757da028e802c7e98d23fbab8d234b1063e161cf.1508516398.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
(cherry picked from commit 82c62fa0c49aa305104013cee4468772799bb391)
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
arch/x86/entry/entry_64.S
arch/x86/kernel/head_32.S
arch/x86/kernel/head_64.S