]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - arch/x86/kvm/vmx.c
KVM: VMX: Don't expose unrestricted_guest is enabled if ept is disabled
authorWanpeng Li <wanpeng.li@hotmail.com>
Mon, 9 Oct 2017 22:51:53 +0000 (15:51 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 12 Oct 2017 12:01:54 +0000 (14:01 +0200)
commit8ad8182e935030f5af5122ce0c137529cb53b013
treefdbbabc5aa37550e4db1f2c1e20ced9ec44ad9e2
parenta554d207dc46b205dcd707888ba31b13c7cfc009
KVM: VMX: Don't expose unrestricted_guest is enabled if ept is disabled

SDM mentioned:

 "If either the â€œunrestricted guest†VM-execution control or the â€œmode-based
  execute control for EPT†VM- execution control is 1, the â€œenable EPTâ€
  VM-execution control must also be 1."

However, we can still observe unrestricted_guest is Y after inserting the kvm-intel.ko
w/ ept=N. It depends on later starts a guest in order that the function
vmx_compute_secondary_exec_control() can be executed, then both the module parameter
and exec control fields will be amended.

This patch fixes it by amending module parameter immediately during vmcs data setup.

Reviewed-by: Jim Mattson <jmattson@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Jim Mattson <jmattson@google.com>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx.c