]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit - arch/x86/pci/broadcom_bus.c
x86/PCI: Fix Broadcom CNB20LE unintended sign extension (redux)
authorColin Ian King <colin.king@canonical.com>
Thu, 25 Oct 2018 13:52:31 +0000 (14:52 +0100)
committerBjorn Helgaas <helgaas@kernel.org>
Fri, 9 Nov 2018 00:01:14 +0000 (18:01 -0600)
commit53bb565fc5439f2c8c57a786feea5946804aa3e9
treeefddacc1ac1d82add09e750b821f3649a43fb4e4
parent651022382c7f8da46cb4872a545ee1da6d097d2a
x86/PCI: Fix Broadcom CNB20LE unintended sign extension (redux)

In the expression "word1 << 16", word1 starts as u16, but is promoted to a
signed int, then sign-extended to resource_size_t, which is probably not
what was intended.  Cast to resource_size_t to avoid the sign extension.

This fixes an identical issue as fixed by commit 0b2d70764bb3 ("x86/PCI:
Fix Broadcom CNB20LE unintended sign extension") back in 2014.

Detected by CoverityScan, CID#138749, 138750 ("Unintended sign extension")

Fixes: 3f6ea84a3035 ("PCI: read memory ranges out of Broadcom CNB20LE host bridge")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bjorn Helgaas <helgaas@kernel.org>
arch/x86/pci/broadcom_bus.c