]> git.proxmox.com Git - mirror_qemu.git/commit - backends/dbus-vmstate.c
dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies
authorPriyankar Jain <priyankar.jain@nutanix.com>
Fri, 26 Nov 2021 14:15:17 +0000 (14:15 +0000)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 18 Aug 2022 06:35:44 +0000 (10:35 +0400)
commit2748583211d6e4d14f8862c65276b2d6cc1681ad
tree07ee251f77de3a1fc78126bdcde931e75fda1d60
parentc7208a6e0d049f9e8af15df908168a79b1f99685
dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies

The purpose of dbus_get_proxies to construct the proxies corresponding to the
IDs registered to dbus-vmstate.

Currenty, this function returns an error in case there is any failure
while instantiating proxy for "all" the names on dbus.

Ideally this function should error out only if it is not able to find and
validate the proxies registered to the backend otherwise any offending
process(for eg: the process purposefully may not export its Id property on
the dbus) may connect to the dbus and can lead to migration failures.

This commit ensures that dbus_get_proxies returns an error if it is not
able to find and validate the proxies of interest(the IDs registered
during the dbus-vmstate instantiation).

Signed-off-by: Priyankar Jain <priyankar.jain@nutanix.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1637936117-37977-1-git-send-email-priyankar.jain@nutanix.com>
backends/dbus-vmstate.c