]> git.proxmox.com Git - mirror_frr.git/commit - bgpd/bgp_nexthop.c
bgpd: Reduce multiaccess_check_v4 overhead for subgroups
authorDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 27 Sep 2017 00:06:13 +0000 (20:06 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 27 Sep 2017 00:06:13 +0000 (20:06 -0400)
commit65d4e0c69b5cb6e7811784ef563e1b23ba162cff
treef23648ad5e15b7050dd250a210baa5d550078fe8
parent6988ea42d2785058124b114b49799787fb002050
bgpd: Reduce multiaccess_check_v4 overhead for subgroups

Perf results at scale( >1k peers) showed a non-trivial
amount of time spent in bgp_multiaccess_check_v4.  Upon
function examination we are looking up the nexthops
connected node in each call as well as having to unlock
it after each iteration.  Rewrite to lookup the nexthop
node once.

This should reduce the node lookup by aproximately 1/2
which should yield some performance results.  There are
probably better things to do here but would require
deeper thought.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/bgp_nexthop.c
bgpd/bgp_nexthop.h
bgpd/bgp_route.c