]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - block/badblocks.c
badblocks: fix wrong return value in badblocks_set if badblocks are disabled
authorLiu Bo <bo.li.liu@oracle.com>
Fri, 3 Nov 2017 17:24:44 +0000 (11:24 -0600)
committerShaohua Li <shli@fb.com>
Fri, 3 Nov 2017 18:29:50 +0000 (11:29 -0700)
commit39b4954c0a1556f8f7f1fdcf59a227117fcd8a0b
tree91ea4eb6e8b4cbe512ddade95f43651d3a873d34
parentb90f6ff080c52e2f05364210733df120e3c4e597
badblocks: fix wrong return value in badblocks_set if badblocks are disabled

MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if
badblocks are disabled, otherwise, rdev_set_badblocks() will record
superblock changes and return success in that case and md will fail to
report an IO error which it should.

This bug has existed since badblocks were introduced in commit
9e0e252a048b ("badblocks: Add core badblock management code").

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Acked-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
block/badblocks.c