]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - block/bfq-iosched.c
projects / mirror_ubuntu-bionic-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 75ba4ad) | patch
block, bfq: don't dereference bic before null checking it
authorColin Ian King <colin.king@canonical.com>
Thu, 20 Apr 2017 14:07:18 +0000 (15:07 +0100)
committerJens Axboe <axboe@fb.com>
Thu, 20 Apr 2017 14:19:23 +0000 (08:19 -0600)
commit8c9ff1addad515037abc1b14684f9d6fd480c247
tree9c4727a695f1f8f0e92fa5c94de94b1478fd318atree
parent75ba4ada8286d415bcaab993ce1f11125b8aa13ecommit | diff
block, bfq: don't dereference bic before null checking it

The call to bfq_check_ioprio_change will dereference bic, however,
the null check for bic is after this call.  Move the the null
check on bic to before the call to avoid any potential null
pointer dereference issues.

Detected by CoverityScan, CID#1430138 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/bfq-iosched.c diff | blob | blame | history
ubuntu-bionic-kernel mirror