]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit - block/bfq-iosched.h
block, bfq: print SHARED instead of pid for shared queues in logs
authorFrancesco Pollicino <fra.fra.800@gmail.com>
Tue, 12 Mar 2019 08:59:33 +0000 (09:59 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 1 Apr 2019 14:15:40 +0000 (08:15 -0600)
commit1e66413c4f68e2a61a210e4f5ff5df7a2ab86a5b
tree49e5f455fa84648d09b82a92e114dfb6975adaca
parent84a746891e1d8364485c0a37533fe6c1380270d4
block, bfq: print SHARED instead of pid for shared queues in logs

The function "bfq_log_bfqq" prints the pid of the process
associated with the queue passed as input.

Unfortunately, if the queue is shared, then more than one process
is associated with the queue. The pid that gets printed in this
case is the pid of one of the associated processes.
Which process gets printed depends on the exact sequence of merge
events the queue underwent. So printing such a pid is rather
useless and above all is often rather confusing because it
reports a random pid between those of the associated processes.

This commit addresses this issue by printing SHARED instead of a pid
if the queue is shared.

Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: Francesco Pollicino <fra.fra.800@gmail.com>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c
block/bfq-iosched.h