]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - block/blk-core.c
block: drain queue before waiting for q_usage_counter becoming zero
authorMing Lei <ming.lei@redhat.com>
Wed, 29 Nov 2017 23:56:35 +0000 (07:56 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 5 Jan 2018 16:09:48 +0000 (09:09 -0700)
commit454be724f6f99cc7e7bbf15067128be9868186c6
tree6471f6c7b9d06b8172eb05edf07ec45680637aef
parent6d0e4827b72afc71349784336d5eb6df4df106e6
block: drain queue before waiting for q_usage_counter becoming zero

Now we track legacy requests with .q_usage_counter in commit 055f6e18e08f
("block: Make q_usage_counter also track legacy requests"), but that
commit never runs and drains legacy queue before waiting for this counter
becoming zero, then IO hang is caused in the test of pulling disk during IO.

This patch fixes the issue by draining requests before waiting for
q_usage_counter becoming zero, both Mauricio and chenxiang reported this
issue, and observed that it can be fixed by this patch.

Link: https://marc.info/?l=linux-block&m=151192424731797&w=2
Fixes: 055f6e18e08f("block: Make q_usage_counter also track legacy requests")
Cc: Wen Xiong <wenxiong@us.ibm.com>
Tested-by: "chenxiang (M)" <chenxiang66@hisilicon.com>
Tested-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c
block/blk-mq.c
block/blk.h