]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - block/blk-flush.c
block: set REQ_SYNC if we clear REQ_FUA|REQ_PREFLUSH
authorJens Axboe <axboe@fb.com>
Wed, 9 Nov 2016 02:39:28 +0000 (19:39 -0700)
committerJens Axboe <axboe@fb.com>
Wed, 9 Nov 2016 02:39:28 +0000 (19:39 -0700)
commitae5b2ec8ad5e017126cd4552220f25ce8a6b92e9
tree8adef3f0d868cdb67dd8d4aba11edf210341ebdf
parentb57d74aff9ab92fbfb7c197c384d1adfa2827b2e
block: set REQ_SYNC if we clear REQ_FUA|REQ_PREFLUSH

If we insert a flush request, we clear REQ_PREFLUSH and/or REQ_FUA,
depending on flush settings. Since op_is_sync() factors those flags
in for deciding whether this request is sync or not, we should
set REQ_SYNC to avoid screwing up this accounting.

This should be less fragile.

Reported-by: Logan Gunthorpe <logang@deltatee.com>
Fixes: b685d3d65ac ("block: treat REQ_FUA and REQ_PREFLUSH as synchronous")
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-flush.c