]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - block/blk-zoned.c
block: zoned: fix harmless maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 21 Oct 2016 15:42:33 +0000 (17:42 +0200)
committerJens Axboe <axboe@fb.com>
Tue, 25 Oct 2016 02:51:22 +0000 (20:51 -0600)
commit3c4da75814c4b8871116940eb32d3a5243026918
tree8d589efd82695f294ed859c5ac0d802f9c1f2c3f
parent89d9475610771b5e5fe1879075f0fc9ba6e3755f
block: zoned: fix harmless maybe-uninitialized warning

The blkdev_report_zones produces a harmless warning when
-Wmaybe-uninitialized is set, after gcc gets a little confused
about the multiple 'goto' here:

block/blk-zoned.c: In function 'blkdev_report_zones':
block/blk-zoned.c:188:13: error: 'nz' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Moving the assignment to nr_zones makes this a little simpler
while also avoiding the warning reliably. I'm removing the
extraneous initialization of 'int ret' in the same patch, as
that is semi-related and could cause an uninitialized use of
that variable to not produce a warning.

Fixes: 6a0cb1bc106f ("block: Implement support for zoned block devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Shaun Tancheff <shaun.tancheff@seagate.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-zoned.c