]> git.proxmox.com Git - mirror_qemu.git/commit - block/blkdebug.c
blkdebug: Set request_alignment during .bdrv_refresh_limits()
authorEric Blake <eblake@redhat.com>
Thu, 23 Jun 2016 22:37:13 +0000 (16:37 -0600)
committerKevin Wolf <kwolf@redhat.com>
Tue, 5 Jul 2016 14:46:25 +0000 (16:46 +0200)
commit835db3ee7b2ab9643bcfc2a9816133e93c78476f
tree572eb9c78cf07291fa0613aa6444d34bca26e0d5
parent24ce9a20260713e86377cfa78fb8699335759f4f
blkdebug: Set request_alignment during .bdrv_refresh_limits()

We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.

Note that when the user does not provide "align", then we were
defaulting to bs->request_alignment - but at this stage in the
initialization, that was always 512.  We were also rejecting an
explicit "align":0 from the user; this patch now allows that,
as an explicit request for the default alignment (which may not
always be 512 in the future).

qemu-iotests 77 is particularly sensitive to the fact that we
can specify an artificial alignment override in blkdebug, and
that override must continue to work even when limits are
refreshed on an already open device.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/blkdebug.c
qapi/block-core.json