]> git.proxmox.com Git - mirror_qemu.git/commit - block/iscsi.c
block/iscsi: avoid data corruption with cache=writeback
authorPeter Lieven <pl@kamp.de>
Mon, 16 Jan 2017 15:17:12 +0000 (16:17 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 27 Jan 2017 17:07:31 +0000 (18:07 +0100)
commit1da45e0c4cf4719fa75898d019e0874b9b2bc774
treedfc9aa1b87b65e1bb9c4b8ad1649ec988fb89891
parentb8bab8eb6934cbf6577a18a9c5657d7707379ac0
block/iscsi: avoid data corruption with cache=writeback

nb_cls_shrunk in iscsi_allocmap_update can become -1 if the
request starts and ends within the same cluster. This results
in passing -1 to bitmap_set and bitmap_clear and they don't
handle negative values properly. In the end this leads to data
corruption.

Fixes: e1123a3b40a1a9a625a29c8ed4debb7e206ea690
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <1484579832-18589-1-git-send-email-pl@kamp.de>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
block/iscsi.c