]> git.proxmox.com Git - mirror_qemu.git/commit - block/nvme.c
block/nvme: don't access CQE after moving cq.head
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 17 Jun 2020 13:21:57 +0000 (14:21 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 23 Jun 2020 14:46:08 +0000 (15:46 +0100)
commit04b3fb39c815e6de67c5003e610d1cdecc911980
treea22cf62646ba060d29a58e8ab1bee6112ba41265
parentd38253cf8b44e3b94a5b327d014ab035ae1126ed
block/nvme: don't access CQE after moving cq.head

Do not access a CQE after incrementing q->cq.head and releasing q->lock.
It is unlikely that this causes problems in practice but it's a latent
bug.

The reason why it should be safe at the moment is that completion
processing is not re-entrant and the CQ doorbell isn't written until the
end of nvme_process_completion().

Make this change now because QEMU expects completion processing to be
re-entrant and later patches will do that.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200617132201.1832152-4-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/nvme.c