]> git.proxmox.com Git - mirror_qemu.git/commit - block/nvme.c
block/nvme: support nested aio_poll()
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 17 Jun 2020 13:22:01 +0000 (14:22 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 23 Jun 2020 14:46:08 +0000 (15:46 +0100)
commit7838c67f22a81fcf669785cd6c0876438422071a
tree55d08313439c1728cd0883cf2c924213a861701c
parentb75fd5f55467307a6e367bc349a8ea6ce30d8a1c
block/nvme: support nested aio_poll()

QEMU block drivers are supposed to support aio_poll() from I/O
completion callback functions. This means completion processing must be
re-entrant.

The standard approach is to schedule a BH during completion processing
and cancel it at the end of processing. If aio_poll() is invoked by a
callback function then the BH will run. The BH continues the suspended
completion processing.

All of this means that request A's cb() can synchronously wait for
request B to complete. Previously the nvme block driver would hang
because it didn't process completions from nested aio_poll().

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Message-id: 20200617132201.1832152-8-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/nvme.c
block/trace-events