]> git.proxmox.com Git - mirror_qemu.git/commit - block/qapi-sysemu.c
block: Fix locking in media change monitor commands
authorKevin Wolf <kwolf@redhat.com>
Fri, 13 Oct 2023 15:33:01 +0000 (17:33 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 31 Oct 2023 12:51:28 +0000 (13:51 +0100)
commitfed824501501518b1ad3dc08a39f8f855508190d
tree8989ee1a6f41260684f5ffd2c00cea61b8ce27ec
parent87fe52ceca697e2ff8d42e881538219ced86f760
block: Fix locking in media change monitor commands

blk_insert_bs() requires that the caller holds the AioContext lock for
the node to be inserted. Since commit c066e808e11, neglecting to do so
causes a crash when the child has to be moved to a different AioContext
to attach it to the BlockBackend.

This fixes qmp_blockdev_insert_anon_medium(), which is called for the
QMP commands 'blockdev-insert-medium' and 'blockdev-change-medium', to
correctly take the lock.

Cc: qemu-stable@nongnu.org
Fixes: https://issues.redhat.com/browse/RHEL-3922
Fixes: c066e808e11a5c181b625537b6c78e0de27a4801
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231013153302.39234-2-kwolf@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qapi-sysemu.c