]> git.proxmox.com Git - mirror_qemu.git/commit - block/qapi.c
block/qapi: Clean up how we print to monitor or stdout
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Apr 2019 19:17:55 +0000 (21:17 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 18 Apr 2019 20:18:59 +0000 (22:18 +0200)
commite1ce7d747bc071f86a77683b433b852001163c2c
treeb9459e51db7b87862c632ecb47342488bbd9b1a4
parentac7ff4cf5f20eee8cec228209f6b3ca557c60639
block/qapi: Clean up how we print to monitor or stdout

bdrv_snapshot_dump(), bdrv_image_info_specific_dump(),
bdrv_image_info_dump() and their helpers take an fprintf()-like
callback and a FILE * to pass to it.

hmp.c passes monitor_printf() cast to fprintf_function and the current
monitor cast to FILE *.

qemu-img.c and qemu-io-cmds.c pass fprintf and stdout.

The type-punning is technically undefined behaviour, but works in
practice.  Clean up: drop the callback, and call qemu_printf()
instead.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190417191805.28198-8-armbru@redhat.com>
block/qapi.c
hmp.c
include/block/qapi.h
qemu-img.c
qemu-io-cmds.c