]> git.proxmox.com Git - mirror_qemu.git/commit - block/qcow2-cluster.c
qcow2: Prevent allocating L2 tables at offset 0
authorAlberto Garcia <berto@igalia.com>
Fri, 3 Nov 2017 14:18:51 +0000 (16:18 +0200)
committerMax Reitz <mreitz@redhat.com>
Tue, 14 Nov 2017 17:06:25 +0000 (18:06 +0100)
commit9883975050deffc147a3903d07ff995ecdc8a100
tree9e1257d6dccbbf925a35ede332beeb3234dd94b9
parent6bf45d59f98c898b7d7997a333765c8ee41236ea
qcow2: Prevent allocating L2 tables at offset 0

If the refcount data is corrupted then we can end up trying to
allocate a new L2 table at offset 0 in the image, triggering an
assertion in the qcow2 cache that would crash QEMU:

  qcow2_cache_entry_mark_dirty: Assertion `c->entries[i].offset != 0' failed

This patch adds an explicit check for this scenario and a new test
case.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 92dac37191ae7844a2da22c122204eb493cc3133.1509718618.git.berto@igalia.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/qcow2-cluster.c
tests/qemu-iotests/060
tests/qemu-iotests/060.out