]> git.proxmox.com Git - mirror_qemu.git/commit - block/qcow2.c
qcow2: Fix NULL dereference in qcow2_open() error path (CVE-2014-0146)
authorKevin Wolf <kwolf@redhat.com>
Wed, 26 Mar 2014 12:06:04 +0000 (13:06 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 1 Apr 2014 13:22:35 +0000 (15:22 +0200)
commit11b128f4062dd7f89b14abc8877ff20d41b28be9
treedbbe66c763e4fd486d13703617ba092e7e7437e6
parent6b7d4c55586a849aa8313282d79432917eade3bf
qcow2: Fix NULL dereference in qcow2_open() error path (CVE-2014-0146)

The qcow2 code assumes that s->snapshots is non-NULL if s->nb_snapshots
!= 0. By having the initialisation of both fields separated in
qcow2_open(), any error occuring in between would cause the error path
to dereference NULL in qcow2_free_snapshots() if the image had any
snapshots.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/qcow2.c
tests/qemu-iotests/080
tests/qemu-iotests/080.out