]> git.proxmox.com Git - mirror_qemu.git/commit - block/qcow2.c
block/qcow2: simplify qcow2_co_invalidate_cache()
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 2 Feb 2021 12:49:54 +0000 (15:49 +0300)
committerEric Blake <eblake@redhat.com>
Mon, 8 Mar 2021 22:03:27 +0000 (16:03 -0600)
commite6247c9c9f9e4d01b00036f017da53d130981727
tree18257d1dea98c57408e7e34ffee0e13bbe44cb56
parent772c4cad13b97b8e8ef8592228707f7a5557f939
block/qcow2: simplify qcow2_co_invalidate_cache()

qcow2_do_open correctly sets errp on each failure path. So, we can
simplify code in qcow2_co_invalidate_cache() and drop explicit error
propagation.

Add ERRP_GUARD() as mandated by the documentation in
include/qapi/error.h so that error_prepend() is actually called even if
errp is &error_fatal.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210202124956.63146-13-vsementsov@virtuozzo.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
block/qcow2.c