]> git.proxmox.com Git - mirror_qemu.git/commit - block/qcow2.c
block: use int64_t instead of uint64_t in driver write handlers
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Fri, 3 Sep 2021 10:28:00 +0000 (13:28 +0300)
committerEric Blake <eblake@redhat.com>
Wed, 29 Sep 2021 18:46:31 +0000 (13:46 -0500)
commite75abedab7e10043ed81b1cbc3033409aff0159e
tree7d786ebfbb38f8657be0a7ce77d054693c4d431f
parentf7ef38dd1310d7d9db76d0aa16899cbc5744f36d
block: use int64_t instead of uint64_t in driver write handlers

We are generally moving to int64_t for both offset and bytes parameters
on all io paths.

Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.

We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).

So, convert driver write handlers parameters which are already 64bit to
signed type.

While being here, convert also flags parameter to be BdrvRequestFlags.

Now let's consider all callers. Simple

  git grep '\->bdrv_\(aio\|co\)_pwritev\(_part\)\?'

shows that's there three callers of driver function:

 bdrv_driver_pwritev() and bdrv_driver_pwritev_compressed() in
 block/io.c, both pass int64_t, checked by bdrv_check_qiov_request() to
 be non-negative.

 qcow2_save_vmstate() does bdrv_check_qiov_request().

Still, the functions may be called directly, not only by drv->...
Let's check:

git grep '\.bdrv_\(aio\|co\)_pwritev\(_part\)\?\s*=' | \
awk '{print $4}' | sed 's/,//' | sed 's/&//' | sort | uniq | \
while read func; do git grep "$func(" | \
grep -v "$func(BlockDriverState"; done

shows several callers:

qcow2:
  qcow2_co_truncate() write at most up to @offset, which is checked in
    generic qcow2_co_truncate() by bdrv_check_request().
  qcow2_co_pwritev_compressed_task() pass the request (or part of the
    request) that already went through normal write path, so it should
    be OK

qcow:
  qcow_co_pwritev_compressed() pass int64_t, it's updated by this patch

quorum:
  quorum_co_pwrite_zeroes() pass int64_t and int - OK

throttle:
  throttle_co_pwritev_compressed() pass int64_t, it's updated by this
  patch

vmdk:
  vmdk_co_pwritev_compressed() pass int64_t, it's updated by this
  patch

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210903102807.27127-5-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
30 files changed:
block/blkdebug.c
block/blklogwrites.c
block/blkreplay.c
block/blkverify.c
block/copy-before-write.c
block/copy-on-read.c
block/crypto.c
block/file-posix.c
block/file-win32.c
block/filter-compress.c
block/io.c
block/mirror.c
block/nbd.c
block/nfs.c
block/null.c
block/nvme.c
block/preallocate.c
block/qcow.c
block/qcow2.c
block/quorum.c
block/raw-format.c
block/rbd.c
block/throttle.c
block/trace-events
block/vdi.c
block/vmdk.c
block/vpc.c
block/vvfat.c
include/block/block_int.h
tests/unit/test-block-iothread.c