]> git.proxmox.com Git - mirror_qemu.git/commit - block/qed.c
block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts()
authorMarkus Armbruster <armbru@redhat.com>
Thu, 14 Jun 2018 19:14:32 +0000 (21:14 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 15 Jun 2018 12:49:44 +0000 (14:49 +0200)
commit92adf9dbcd3cf9cedddae995b04a99f5c42ae08c
treed0528b94f615b5a24d7b97757b42e081331a0f87
parent374c52467a38c2e811f6c0db4edc9ea7d5f34341
block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts()

The following pattern occurs in the .bdrv_co_create_opts() methods of
parallels, qcow, qcow2, qed, vhdx and vpc:

    qobj = qdict_crumple_for_keyval_qiv(qdict, errp);
    qobject_unref(qdict);
    qdict = qobject_to(QDict, qobj);
    if (qdict == NULL) {
         ret = -EINVAL;
         goto done;
    }

    v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
    [...]
    ret = 0;
done:
    qobject_unref(qdict);
    [...]
    return ret;

If qobject_to() fails, we return failure without setting errp.  That's
wrong.  As far as I can tell, it cannot fail here.  Clean it up
anyway, by removing the useless conversion.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/parallels.c
block/qcow.c
block/qcow2.c
block/qed.c
block/vhdx.c
block/vpc.c