]> git.proxmox.com Git - mirror_qemu.git/commit - block/qed.c
error: Use error_prepend() where it makes obvious sense
authorMarkus Armbruster <armbru@redhat.com>
Fri, 18 Dec 2015 15:35:15 +0000 (16:35 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 13 Jan 2016 14:16:17 +0000 (15:16 +0100)
commite43bfd9c876676e884b561eca009a571992a4b76
tree10fb32df04ffc41e124b1c1807017788168722ad
parentc29b77f955ff2f7b57c1e71e9dc26243eefd0b28
error: Use error_prepend() where it makes obvious sense

Done with this Coccinelle semantic patch

    @@
    expression FMT, E1, E2;
    expression list ARGS;
    @@
    -    error_setg(E1, FMT, ARGS, error_get_pretty(E2));
    +    error_propagate(E1, E2);/*###*/
    +    error_prepend(E1, FMT/*@@@*/, ARGS);

followed by manual cleanup, first because I can't figure out how to
make Coccinelle transform strings, and second to get rid of now
superfluous error_propagate().

We now use or propagate the original error whole instead of just its
message obtained with error_get_pretty().  This avoids suppressing its
hint (see commit 50b7b00), but I can't see how the errors touched in
this commit could come with hints.  It also improves the message
printed with &error_abort when we screw up (see commit 1e9b65b).

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
block.c
block/qcow2.c
block/qed.c
hw/block/dataplane/virtio-blk.c
hw/scsi/vhost-scsi.c
hw/usb/bus.c