]> git.proxmox.com Git - mirror_qemu.git/commit - block/sheepdog.c
block: Use g_new() & friends to avoid multiplying sizes
authorMarkus Armbruster <armbru@redhat.com>
Tue, 19 Aug 2014 08:31:09 +0000 (10:31 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 20 Aug 2014 09:51:28 +0000 (11:51 +0200)
commit02c4f26b1517d9e403ec10d6f6ca3c0276d19e43
tree72ab6699d8ce12001632bf30fe4bcd801678465b
parent5839e53bbc0fec56021d758aab7610df421ed8c8
block: Use g_new() & friends to avoid multiplying sizes

g_new(T, n) is safer than g_malloc(sizeof(*v) * n) for two reasons.
One, it catches multiplication overflowing size_t.  Two, it returns
T * rather than void *, which lets the compiler catch more type
errors.

Perhaps a conversion to g_malloc_n() would be neater in places, but
that's merely four years old, and we can't use such newfangled stuff.

This commit only touches allocations with size arguments of the form
sizeof(T), plus two that use 4 instead of sizeof(uint32_t).  We can
make the others safe by converting to g_malloc_n() when it becomes
available to us in a couple of years.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/bochs.c
block/parallels.c
block/qcow2-cache.c
block/qed-check.c
block/rbd.c
block/sheepdog.c
hw/block/nvme.c
qemu-io-cmds.c