]> git.proxmox.com Git - mirror_qemu.git/commit - block/sheepdog.c
sheepdog: fix dynamic grow for running qcow2 format
authorLiu Yuan <namei.unix@gmail.com>
Fri, 13 Dec 2013 17:29:28 +0000 (01:29 +0800)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 20 Dec 2013 08:11:57 +0000 (09:11 +0100)
commite50d7607f1800c9f9c576229c6119e4c82f456d6
tree0e1971bd2eefccd6e372a6f7d8db12961e9790fb
parentf8251db121c3f051b22a7536b97d160c30bcccd4
sheepdog: fix dynamic grow for running qcow2 format

When running qcow2 over sheepdog, we might meet following problem

  qemu-system-x86_64: shrinking is not supported

And cause IO errors to Guest. This is because we abuse bs->total_sectors, which
is manipulated by generic block layer and race with sheepdog code.

We should directly check if offset > vdi_size to dynamically enlarge the volume
instead of 'offset > bs->total_sectors', which will cause problem when following
case happens:

   vdi_size > offset > bs->total_sectors

   # then trigger sd_truncate() to shrink the volume wrongly.

Cc: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Reported-by: Hadrien KOHL <hadrien.kohl@gmail.com>
Signed-off-by: Liu Yuan <namei.unix@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/sheepdog.c